ServletPrefix in diffable tag

3 views
Skip to first unread message

icefox

unread,
Jul 14, 2010, 4:59:49 AM7/14/10
to Diffable
Hi,

First of all, thank you for providing to the community a such tool.
The idea of providing only diff between version is really brilliant.

I just have one suggestion, which is to define the servletPrefix
property in the config property
or directly as a parameter of your DiffableServlet in the web.xml
file.
Otherwise the user will have to repeat the servletPrefix property for
each tag, while it can be configured once.

My choice would be to put it directly in Servlet parameter in the
web.xml file as it's nearer to the mapping definition of the servlet,
which is done in the web.xml file.

I also have to say that I'm the Project Leader of Jawr (https://
jawr.dev.java.net/)
and I will probably work on the integration of diffable in Jawr.

Thanks again for sharing your project.

Cheers,
icefox

Joshua Harrison

unread,
Jul 14, 2010, 12:47:22 PM7/14/10
to Diffable
Icefox,

Thanks a lot for your interest and your kind words!

I completely agree with the suggestion and have created an issue for
this: http://code.google.com/p/diffable/issues/detail?id=5.

I was looking at JAWR the other day after noticing a Tweet that about
whether Diffable would work with it, and I definitely think it would
as long as the diffing step came after the JAWR compression step. I
think it's a very exciting opportunity; please do keep us informed of
your work in this area, and I would be more than happy to help where I
can.

Thanks,
Joshua
Reply all
Reply to author
Forward
0 new messages