Add a semicolon to the end of the script

34 views
Skip to first unread message

SwineDk

unread,
Feb 8, 2012, 6:21:43 AM2/8/12
to Diapo slideshow
Diapo is a great slideshow plugin, but it could do even better with
a ; (semicolon) at the end of the file.

When minifying and bundling Diapo with other libraries inside a single
javascript file, it returns an error. The last line in the javascript
library should end with a ; (semicolon). That way it won't break the
minification :-)

It would be great if you could add this for future versions. Currently
we are adding this semicolon by ourselves, but it could be good, if it
wasn't necessary :-)

Manuel Masia

unread,
Feb 8, 2012, 9:16:15 AM2/8/12
to diapo-s...@googlegroups.com
Thank you Swine... at the moment I'm working on a new plugin that will replace Diapo, but really appreciated.

Manuel :-)

--
Manuel Masia – Pixedelic
via Brescia, 15
47841 - Cattolica (RN)
p. iva 03718310406
 
http://www.pixedelic.com/

SwineDk

unread,
Feb 13, 2012, 9:25:33 AM2/13/12
to Diapo slideshow
Sounds nice :-)

Do say if you need a tester, as I am quite fond of Diapo and wouldn't
mind testing a superior plugin ;-)

I've even got some suggestions already to improvements :-)

1. Make it easy to disable/remove it from elements (revert to
original).
2. When activating it, test if it have already been added to the
object, so it won't "re-apply" the plugin.
3. Only add the plugin if the element exists. Diapo fails, if you
write $('#BoxId').diapo(); on a page, where <div id="BoxId"/> doesn't
exist.
4. Don't activate the plugin, if only one slide is available, but make
it possible to override, as it could be good to add new slides through
external Ajax functionality.


On 8 Feb., 15:16, Manuel Masia <m...@pixedelic.com> wrote:
> Thank you Swine... at the moment I'm working on a new plugin that will
> replace Diapo, but really appreciated.
>
> Manuel :-)
>
> --
> Manuel Masia – Pixedelic
> via Brescia, 15
> 47841 - Cattolica (RN)
> p. iva 03718310406
>
> *http://www.pixedelic.com/*

Jacob Block

unread,
Feb 13, 2012, 11:12:29 AM2/13/12
to Diapo slideshow
Ditto on the testing! Please post in this group when you put something
out :)

Jacob
Reply all
Reply to author
Forward
0 new messages