Re: Issue 2 in diagrams: Merge polygon code from Dmitry Olshansky

2 views
Skip to first unread message

diag...@googlecode.com

unread,
Jun 19, 2011, 1:45:05 PM6/19/11
to diagrams...@googlegroups.com
Updates:
Summary: Merge polygon code from Dmitry Olshansky
Owner: ---
Labels: Milestone-Release0.4

Comment #4 on issue 2 by byor...@gmail.com: Merge polygon code from Dmitry
Olshansky
http://code.google.com/p/diagrams/issues/detail?id=2

Here's the code from Dima. Someone needs to go through, clean it up, and
decide what pieces we can/should merge into the Shapes module.

Attachments:
Polygons.hs 6.2 KB

diag...@googlecode.com

unread,
Jun 19, 2011, 2:21:20 PM6/19/11
to diagrams...@googlegroups.com
Updates:
Labels: Difficulty-Hard

Comment #5 on issue 2 by byor...@gmail.com: Merge polygon code from Dmitry
Olshansky
http://code.google.com/p/diagrams/issues/detail?id=2

(No comment was entered for this change.)

diag...@googlecode.com

unread,
Sep 2, 2011, 11:55:55 AM9/2/11
to diagrams...@googlegroups.com
Updates:
Status: Fixed

Comment #7 on issue 2 by byor...@gmail.com: Merge polygon code from Dmitry
Olshansky
http://code.google.com/p/diagrams/issues/detail?id=2

Fri Sep 2 11:51:32 EDT 2011 Brent Yorgey <byo...@cis.upenn.edu>
* Massive refactoring of Polygons module, and finally remove all polygon
functionality from Shapes. This closes #2; most of the code in
Polygons is originally based on code written by Dmitry Olshansky
(thanks Dima!).

This is somewhat of a disruptive change since the type of the
'polygon' function has changed. However, I hope users will find the
new version much more expressive.

Next steps:
1. Update all existing examples to compile again.
2. Add a number of functions to the Shapes module to construct
various common shapes using the tools provided by Polygons, to
give users more easy ways to do common things without needing the
full generality of the polygon function.


Reply all
Reply to author
Forward
0 new messages