[timbunce/devel-nytprof] 2dee44: Fix for the double opening of the web browser

1 view
Skip to first unread message

Tim Bunce

unread,
Dec 31, 2017, 12:46:25 PM12/31/17
to develnyt...@googlegroups.com
Branch: refs/heads/master
Home: https://github.com/timbunce/devel-nytprof
Commit: 2dee446b7a6d6ee30ece14b0bd743439ca5b9414
https://github.com/timbunce/devel-nytprof/commit/2dee446b7a6d6ee30ece14b0bd743439ca5b9414
Author: Daniel Șuteu <tri...@gmail.com>
Date: 2017-01-21 (Sat, 21 Jan 2017)

Changed paths:
M bin/nytprofhtml

Log Message:
-----------
Fix for the double opening of the web browser

When [Browser::Open](https://metacpan.org/pod/Browser::Open) is available and it opens a browser, it returns the result of `system()` (see [source code](https://metacpan.org/source/CFRANKS/Browser-Open-0.04/lib/Browser/Open.pm#L72)), which is the exit code of the process. On success, the exit code is zero, so we now check this and return without trying to open the browser again.

Previously, the browser was opening twice when the `--open` flag was provided.


Commit: b2c36783d0d1b3a2070ea6097f322ea627b15f69
https://github.com/timbunce/devel-nytprof/commit/b2c36783d0d1b3a2070ea6097f322ea627b15f69
Author: Tim Bunce <Tim....@pobox.com>
Date: 2017-12-31 (Sun, 31 Dec 2017)

Changed paths:
M bin/nytprofhtml

Log Message:
-----------
Merge pull request #107 from trizen/patch-2

Fix for the double opening of the web browser


Compare: https://github.com/timbunce/devel-nytprof/compare/15d7247028ca...b2c36783d0d1
Reply all
Reply to author
Forward
0 new messages