[PR] Fix PATH getting wiped on Windows during install

7 views
Skip to first unread message

antoine9...@gmail.com

unread,
Jan 4, 2020, 6:46:37 PM1/4/20
to dev-suite
Hi,

Here's a patch for the issue I just sent:


Not sure my Rust style is on point, feel free to request changes :)

Cheers,

--
Antoine Martin

Michael Gattozzi

unread,
Jan 5, 2020, 6:06:48 PM1/5/20
to antoine9...@gmail.com, dev-suite
Hey Antoine!

Thanks for taking the time to fix this PATH issue. I really appreciate it! I've merged it as is for now since I'd like to do a point release to fix the more glaring issues and things can get cleaned up later if they need to be. I had no idea this was the case so thank you for catching this again. I have to admit I don't know many of Window's corner cases or weird platform behavior as well as I do Linux or OSX so this insight is great. I learned something new. You can see your changes and issue have been merged here-> https://github.com/mgattozzi/dev-suite/commit/c8e11a8f9817bc780cb5858a946e5845788badd5

Best,
Michael Gattozzi

--
You received this message because you are subscribed to the Google Groups "dev-suite" group.
To unsubscribe from this group and stop receiving emails from it, send an email to dev-suite+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/dev-suite/bcf31f50-acef-42b5-a894-9a7599e097c3%40googlegroups.com.
Reply all
Reply to author
Forward
0 new messages