20160630 CFEngine development digest - what's happening in master branch

[Dimitrios Apostolou]

20160630 CFEngine development digest - what's happening in master branch
=================================================================

1.1 CFE-2260 ifelse() (cherry-picked to 3.7.4 and 3.9.1)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

By default function evaluation is skipped when arguments contain
unexpanded variables. This fix allows the following case to work:

,----
| bundle agent main
| {
| vars:
| # Since init.passwd_file is defined, I expect the value to be
| # the value of init.passwd_file
| "use_passwd_file"
| string => ifelse( isvariable("init.passwd_file"), $(init.passwd_file),
| "/etc/passwd");
|
| # Since init.shadow_file is not defined, I expect that the value
| # will be "/etc/shadow"
| "use_shadow_file"
| string => ifelse( isvariable("init.shadow_file"), $(init.shadow_file),
| "/etc/shadow");
| }
`----

Thanks to Ted Zlatanov (@tzz) for providing the fix.


1.2 CFE-2345 rlist_test segfault fix and thread-safety fixes
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

One unit test (rlist_test.c) was segfaulting on Ubuntu 16.04. This
brought up some thread-safety issues in our `Rlist' data structure (it
is *not* thread-safe, never was, thus it shouldn't be locked). The
full fix was committed to master, and the small segfault fix was
cherry-picked to 3.6.x, 3.7.x, 3.9.x.

Thanks to Lars Tangvald and Yann Soubeyrand for the report and initial
patches.


1.3 CFE-2287 isipinsubnet() new function and iprange() implementation refactoring
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

After plenty of discussions, reviews and pull requests, the new
function `isipinsubnet(subnet_range, ip1, ip2)' was introduced. The
preexisting `iprange()' function was not changed after all, but its
implementation was very much simplified.

Many thanks to Ted Zlatanov (@tzz) for pushing this forward with code,
comments and documentation.


1.4 CFE-2386 *behaviour change* in cf-execd
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The C code no longer appends `-Dfrom_cfexecd' to `exec_command'. If
needed this should be done in policy. Strictly only for master branch.

Many thanks to Nick Anderson for pushing this forward.