Re: [google-depan] tugrul.mail commented on revision r31.

0 views
Skip to first unread message

Lee Carver

unread,
Sep 25, 2008, 4:03:22 AM9/25/08
to Tugrul Ince, depa...@googlegroups.com
codesite...@google.com wrote:
> [google-depan] tugrul.mail commented on revision r31.
> Details are at http://code.google.com/p/google-depan/source/detail?r=31
>
> Score: Positive
>
> General Comment:
> LGTM, but one quick question: It seems to me that we need ..args files
> for projects that have custom build property ("custom = true"
> in build.properties). DepanApp and DepanJava have these args files, but
> DepanCore does not, although its build.properties file has "custom
> = true". I am not sure if that even makes sense, but I wanted to
> mention just to make sure we are not missing a file in this commit.

It puzzled me, too, at first.

I haven't found a definitive reference, but it appears to be related to a
plugin's use of Eclipse modules. DepanCore is "pure" .. no dependencies on any
of the Eclipse RCP/Workbench plugins.

These ..args files seem to be completely undocumented (so are about.html
files!), but it also seems to be an internally-consistent explanation for
Eclipse's behavior.

So Yes, it is intentional that DepanCore does *not* have a ..args file even
though it has a custom build.xml.

Thanks for watching out
Lee

Reply all
Reply to author
Forward
0 new messages