Code review request for r44

[Yohann]

Hi,

A quick code review that updates DepAn (and getThirdParty script) to
the latest versions of xstream, asm and jung.

http://code.google.com/p/google-depan/source/detail?r=44

Thanks,
--
YC

http://five.sentenc.es/

[Lee Carver]

It would be nice to put each third-party library into a versioned directory,
like I did for xstream:

More like:
third-party/
asm/asm-3.1/asm-*3.1.jar
jung/jung-beta1/jung-*-beta1.jar

It helps keeps the craziness down when new versions become available.

Also, don't forget to update issues 32, 33, and 35

What about joda-time?

Thanks
Lee

[Yohann]

On Wed, Nov 12, 2008 at 11:59 AM, Lee Carver <le...@google.com> wrote:
> It would be nice to put each third-party library into a versioned directory,
> like I did for xstream:

I will check that.
But for xstream (and asm, joda-time, junit), it only comes from the
fact that the zip file actually contains a directory called
XXX-version. it is apparently not the case anymore for jung since the
beta version.

That might cause other path problems, I will check again before submitting..

>
> More like:
> third-party/
> asm/asm-3.1/asm-*3.1.jar
> jung/jung-beta1/jung-*-beta1.jar
>
> It helps keeps the craziness down when new versions become available.
>
> Also, don't forget to update issues 32, 33, and 35
>
> What about joda-time?

I will check that too, thanks

>
> Thanks
> Lee
>
> Yohann wrote:
>>
>> Hi,
>>
>> A quick code review that updates DepAn (and getThirdParty script) to
>> the latest versions of xstream, asm and jung.
>>
>> http://code.google.com/p/google-depan/source/detail?r=44
>>
>> Thanks,
>
>

--
YC

http://five.sentenc.es/