You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to DendroPy Users
Hi - I see that I can set 'extract_comment_metadata=True' when reading newick/nexus files (and it is True by default), but I can't see much in the docs (e.g. by searching for the string 'comment' or 'comments') about what it does. Inspection of the tree objects shows that they contain a 'comments' attribute - I guess this is the "approved" way to access them? Would it be possible to add this as an attribute listed in https://dendropy.org/library/treemodel.html#dendropy.datamodel.treemodel.Tree?
Yan
Jeet Sukumaran
unread,
Jan 26, 2019, 12:24:11 PM1/26/19
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to dendrop...@googlegroups.com
The various Tree, Node, Edge, etc. classes already have a ``comment``
attribute, which is a list of comment strings. What would you like to
see added?
----------------------------------------------------
Jeet Sukumaran
----------------------------------------------------
Assistant Professor
Biology Department
San Diego State University
----------------------------------------------------
Lab:
https://sukumaranlab.org/ Blog:
https://jeetblogs.org/ Repositories:
https://github.com/jeetsukumaran Photography:
https://www.flickr.com/photos/jeetsukumaran/ Calendar:
https://goo.gl/dG5Axs ----------------------------------------------------
Email:
jsuku...@sdsu.edu (work)
jeetsu...@gmail.com (personal)
----------------------------------------------------
Mailing Address:
Biology Department, LS 262
San Diego State University
5500 Campanile Drive
San Diego, CA 92182-4614
----------------------------------------------------
Yan Wong
unread,
Jan 27, 2019, 5:31:40 PM1/27/19
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to DendroPy Users
On Saturday, 26 January 2019 17:24:11 UTC, Jeet Sukumaran wrote:
The various Tree, Node, Edge, etc. classes already have a ``comment``
attribute, which is a list of comment strings. What would you like to
see added?
It's just that the "comment" attribute is not actually documented anywhere I can see (although perhaps I've missed it). I would sort-of expect it to be documented, or at least the attribute name mentioned somewhere. I had to list out the attributes of a Tree object to find the precise attribute name. Since it wasn't present in the documentation, I worried that this attribute was an unsupported addition to DendroPy. But as I said, perhaps I just missed the documentation?
Thanks!
Yan
Jeet Sukumaran
unread,
Jan 28, 2019, 2:16:17 PM1/28/19
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to dendrop...@googlegroups.com
Ah, I see. I'm not sure, but I don't believe it is formally documented.
Should do so, I guess. In the mean time, you can rest assured that it is
not going anywhere or change in the way it works anytime soon. I.e., it
is "official".
-- jeet
Yan Wong
unread,
Jan 29, 2019, 12:08:58 PM1/29/19
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to DendroPy Users
Thanks. That's just what I needed to know. I guess others might find it useful if it were mentioned somewhere in the docs, if only in passing (like the seed_node attribute is mentioned but not, I think, given an explicit place in the documentation). Perhaps within