[Deluge] #2355: Twisted 13.1 incompatible?
Deluge
------------------------+---------------------------------------------------
Reporter: semi225599 | Owner:
Type: bug | Status: new
Priority: major | Milestone: Future
Component: other | Version: 1.3.6
Keywords: |
------------------------+---------------------------------------------------
Just upgraded to the latest Twisted (13.1) and downloading blocklists now
hangs. I looked at the output, and there is a Traceback in some twisted
files; I don't have the output anymore as I downgraded for functionality,
but I remember at the end:
'module' object has no method _parse
To make matters worse, this causes everything else in Deluge to freeze,
torrents appear paused, and I can't close the process without killing it.
Using Arch Linux 32-bit, Deluge 1.3.6, upgraded from Twisted 13.0 to 13.1
--
Ticket URL: <http://dev.deluge-torrent.org/ticket/2355>
Deluge <http://deluge-torrent.org/>
Deluge project
Deluge
------------------------+---------------------------------------------------
Reporter: semi225599 | Owner:
Type: bug | Status: new
Priority: major | Milestone: Future
Component: other | Version: 1.3.6
Keywords: |
------------------------+---------------------------------------------------
Comment(by semi225599):
Output:
{{{
Unhandled error in Deferred:
Unhandled Error
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/deluge/plugins/init.py", line 48,
in enable
self.plugin.enable()
File "/usr/lib/python2.7/site-
packages/deluge/plugins/Blocklist-1.2-py2.7.egg/blocklist/core.py", line
116, in enable
File "/usr/lib/python2.7/site-packages/twisted/internet/task.py", line
173, in start
self()
File "/usr/lib/python2.7/site-packages/twisted/internet/task.py", line
218, in __call__
d = defer.maybeDeferred(self.f, *self.a, **self.kw)
--- <exception caught here> ---
File "/usr/lib/python2.7/site-packages/twisted/internet/defer.py", line
137, in maybeDeferred
result = f(*args, **kw)
File "/usr/lib/python2.7/site-
packages/deluge/plugins/Blocklist-1.2-py2.7.egg/blocklist/core.py", line
151, in check_import
File "/usr/lib/python2.7/site-
packages/deluge/plugins/Blocklist-1.2-py2.7.egg/blocklist/core.py", line
260, in download_list
File "/usr/lib/python2.7/site-packages/deluge/httpdownloader.py", line
195, in download_file
scheme, host, port, path = client._parse(url)
exceptions.AttributeError: 'module' object has no attribute '_parse'
}}}
--
Ticket URL: <http://dev.deluge-torrent.org/ticket/2355#comment:1>
Deluge
------------------------+---------------------------------------------------
Reporter: semi225599 | Owner:
Type: bug | Status: new
Priority: major | Milestone: Future
Component: other | Version: 1.3.6
Keywords: |
------------------------+---------------------------------------------------
Comment(by Respen):
I am having the exact same problem with Blocklist and twisted 13.1,
apparently. I am getting almost exactly the same error message. My error
message is exactly the same past the <exception caught here> line.
Downgrading to twisted 13.0 like the reporter suggested fixed the problem,
as does disabling the Blocklist plugin. Only when actively telling
(including setting the plugin to import on program start) the plugin to
download and/or import a list (local or remote) does the problem occur.
Like the reporter, I am using Arch Linux i686, Deluge 1.3.6, and upgraded
Twisted 13.0 to 13.1.
--
Ticket URL: <http://dev.deluge-torrent.org/ticket/2355#comment:2>
Deluge
------------------------+---------------------------------------------------
Reporter: semi225599 | Owner:
Type: bug | Status: new
Priority: major | Milestone: Future
Component: other | Version: 1.3.6
Keywords: |
------------------------+---------------------------------------------------
Comment(by cb474):
I am also having this problem and downgrading to Twisted 13.0 also solved
the problem for me.
The error I get is mostly, but not entirely the same:
I started a thread on the problem here: http://forum.deluge-
torrent.org/viewtopic.php?f=9&t=44885&p=187595.
And there's a bug report for Arch on it here:
https://bugs.archlinux.org/task/36298
--
Ticket URL: <http://dev.deluge-torrent.org/ticket/2355#comment:3>
Deluge
------------------------+---------------------------------------------------
Reporter: semi225599 | Owner:
Type: bug | Status: new
Priority: major | Milestone: Future
Component: other | Version: 1.3.6
Keywords: |
------------------------+---------------------------------------------------
* cc: cb47492@… (added)
--
Ticket URL: <http://dev.deluge-torrent.org/ticket/2355#comment:4>
Deluge
------------------------+---------------------------------------------------
Reporter: semi225599 | Owner:
Type: bug | Status: new
Priority: major | Milestone: Future
Component: other | Version: 1.3.6
Keywords: |
------------------------+---------------------------------------------------
Comment(by mintchkin):
Sorry, this is my first time doing one of these, but if it helps at all,
this bug appears to affect any action that requires downloading a file
(including trying to download a torrent file) and can be fixed by changing
the lines from:
deluge-1.3.6\deluge\httpdownloader.py
{{{
41 : import os.path
42 : import zlib
...
195: scheme, host, port, path = client._parse(url)
196: factory = HTTPDownloader(url, filename, callback, headers,
force_filename, allow_compression)
197: if scheme == "https":
}}}
to something like:
deluge-1.3.6\deluge\httpdownloader.py
{{{
41 : import os.path
42 : import zlib
xxx: import urlparse
...
xxx: parsed = urlparse(url)
xxx: scheme, host= parsed[:2]
xxx: port = parsed.port or (443 if scheme == 'https' else 80)
xxx: path = parsed.path or '/'
196: factory = HTTPDownloader(url, filename, callback, headers,
force_filename, allow_compression)
197: if scheme == "https":
}}}
which should perform identically to the now defunct
twisted.web.client._parse()
--
Ticket URL: <https://dev.deluge-torrent.org/ticket/2355#comment:5>
Deluge
------------------------+---------------------------------------------------
Reporter: semi225599 | Owner:
Type: bug | Status: new
Priority: major | Milestone: Future
Component: other | Version: 1.3.6
Keywords: |
------------------------+---------------------------------------------------
Comment(by mintchkin):
...oops...the new import line should be:
{{{
...
xxx: from urlparse import urlparse
...
}}}
...awkward...
--
Ticket URL: <http://dev.deluge-torrent.org/ticket/2355#comment:6>
Deluge
------------------------+---------------------------------------------------
Reporter: semi225599 | Owner:
Type: bug | Status: new
Priority: major | Milestone: Future
Component: other | Version: 1.3.6
Keywords: |
------------------------+---------------------------------------------------
Comment(by semi225599):
^ Tried this code change and it now works.
--
Ticket URL: <http://dev.deluge-torrent.org/ticket/2355#comment:7>
Deluge
-------------------------+--------------------------------------------------
Reporter: semi225599 | Owner:
Type: bug | Status: closed
Priority: major | Milestone: 1.3.7
Component: other | Version: 1.3.6
Resolution: fixed | Keywords:
-------------------------+--------------------------------------------------
Changes (by Cas):
* status: new => closed
* resolution: => fixed
* milestone: Future => 1.3.7
Comment:
The fix is already applied to our codebase: [http://git.deluge-
torrent.org/deluge/commit/?h=1.3-stable&id=06ee112344f7 06ee112344f7]
--
Ticket URL: <http://dev.deluge-torrent.org/ticket/2355#comment:8>
Deluge
-------------------------+--------------------------------------------------
Type: bug | Status: reopened
Priority: major | Milestone: 1.3.7
Component: other | Version: master (git branch)
Resolution: | Keywords:
-------------------------+--------------------------------------------------
Changes (by monstermunchkin):
* status: closed => reopened
* version: 1.3.6 => master (git branch)
* resolution: fixed =>
Comment:
The upstream fix does not work as the import is incorrect and
'uri.originFrom' doesn't exist. I attached a patch which fixes both
issues.
--
Ticket URL: <http://dev.deluge-torrent.org/ticket/2355#comment:9>
Deluge
----------------------------+--------------------------
Reporter: semi225599 | Owner:
Type: bug | Status: reopened
Priority: major | Milestone: 1.3.7
Resolution: | Keywords:
----------------------------+--------------------------
Comment (by andar):
I've applied the fix. Thanks.
--
Ticket URL: <http://dev.deluge-torrent.org/ticket/2355#comment:10>
Deluge
----------------------------+--------------------------
Type: bug | Status: closed
Priority: major | Milestone: 1.3.7
Component: other/unknown | Version: master (git)
----------------------------+--------------------------
Changes (by andar):
* status: reopened => closed
* resolution: => Fixed
--
Ticket URL: <http://dev.deluge-torrent.org/ticket/2355#comment:11>
Deluge
----------------------------+--------------------------
Type: bug | Status: closed
Priority: major | Milestone: 1.3.7
Component: other/unknown | Version: master (git)
Resolution: Fixed | Keywords:
----------------------------+--------------------------
Comment (by keretamalam):
I am about to leave and cannot look into this further right now, but I do
want to mention that relying on pkg-config itself is not a problem (as you
said, we also use it later), the problem is that on some systems, the .pc
file for pkg-config is supplying wrong information (whereas on yours, it's
botan-config that is wrong), so that's why I'm trying to make it work with
both (while one of them is bad).
[http://maskodoq.blogspot.com/2014/03/unit-link-terbaik-di-indonesia.html
Unit Link Terbaik di Indonesia Commonwealth Life Investra Link]
[http://maskodoq.blogspot.com/2013/07/CiptoJunaedy.html Cipto Junaedy]
[http://etnisjawa.blogspot.com/2013/08/apakah-cipto-junaedy-bohong.html
Cipto Junaedy]
--
Ticket URL: <http://dev.deluge-torrent.org/ticket/2355#comment:12>