[Deluge] #1466: Performance warning: Send Buffer Watermark
Deluge
-----------------------------------+----------------------------------------
Reporter: cinderblock | Owner:
Type: feature-request | Status: new
Priority: major | Milestone: Future
Component: libtorrent | Version: 1.3.1
Keywords: watermark,send buffer |
-----------------------------------+----------------------------------------
I just took a look at my log file with debug turned on (trying to make
some small improvements of my own) I'm getting a ton of alerts from
libtorrent, like 60 every second, all from the same torrent.
{{{
[DEBUG ] 16:26:38 alertmanager:123 performance_alert: <TORRENT_NAME>:
performance warning: send buffer watermark too low (upload rate will
suffer)
}}}
Google only found one other reference to this "bug" here on the
[http://forum.deluge-torrent.org/viewtopic.php?f=7&t=33839 forums].
This error is coming directly from libtorrent as there is no alert handler
defined for it.
The libtorrent documentation shows the correct
[http://www.rasterbar.com/products/libtorrent/tuning.html#send-buffer-low-
watermark solution] (increasing read buffer) but I can't figure out where
I might add that setting setter to the deluge source. (Just started
looking at python/deluge)
libtorrent also claims to have many presets for different types of servers
(min memory, high performance seed, ...) which have appropriate default
settings. Maybe this is the best place to start and implement a preset
picker in the preferences.
So really, this "feature-request" is for more control over the libtorrent
session settings to optimize performance, not to clean up debug outputs...
--
Ticket URL: <http://dev.deluge-torrent.org/ticket/1466>
Deluge <http://deluge-torrent.org/>
Deluge project
Deluge
-----------------------------------+----------------------------------------
Reporter: cinderblock | Owner:
Type: feature-request | Status: new
Priority: major | Milestone: Future
Component: libtorrent | Version: 1.3.1
Keywords: watermark,send buffer |
-----------------------------------+----------------------------------------
* cc: cameron@… (added)
--
Ticket URL: <http://dev.deluge-torrent.org/ticket/1466#comment:1>
Deluge
-----------------------------------+----------------------------------------
Reporter: cinderblock | Owner:
Type: feature-request | Status: new
Component: core | Version: 1.3.1
Keywords: watermark,send buffer |
-----------------------------------+----------------------------------------
Changes (by Cas):
* component: libtorrent => core
* milestone: Future => 1.4.0
--
Ticket URL: <http://dev.deluge-torrent.org/ticket/1466#comment:2>
Deluge
-----------------------------------+----------------------------------------
Reporter: cinderblock | Owner:
Type: feature-request | Status: new
Component: core | Version: 1.3.1
Keywords: watermark,send buffer |
-----------------------------------+----------------------------------------
Comment(by joshbeck):
I've made a patch off of the latest git master that solves this problem
automatically. Whenever there's a performance_alert, it doubles the size
of the send buffer. It works well for me. I was able to get up to 900KB/s
with it, and the performance_alerts stopped after the buffer grew to
1.6MB.
--
Ticket URL: <http://dev.deluge-torrent.org/ticket/1466#comment:3>
Deluge
-----------------------------------+----------------------------------------
Reporter: cinderblock | Owner:
Priority: major | Milestone: 1.4.0
Component: core | Version: 1.3.1
Keywords: watermark,send buffer |
-----------------------------------+----------------------------------------
Changes (by Cas):
* type: feature-request => patch
--
Ticket URL: <http://dev.deluge-torrent.org/ticket/1466#comment:4>
Deluge
-----------------------------------+----------------------------------------
Reporter: cinderblock | Owner:
Priority: major | Milestone: 1.4.0
Component: core | Version: 1.3.1
Keywords: watermark,send buffer |
-----------------------------------+----------------------------------------
Comment(by non7top):
This patch still applies cleanly to git master. Please commit.
--
Ticket URL: <http://dev.deluge-torrent.org/ticket/1466#comment:5>
Deluge
-----------------------------------+----------------------------------------
Reporter: cinderblock | Owner:
Priority: major | Milestone: 1.4.0
Component: core | Version: 1.3.1
Keywords: watermark,send buffer |
-----------------------------------+----------------------------------------
Changes (by non7top):
* cc: non7top@… (added)
--
Ticket URL: <http://dev.deluge-torrent.org/ticket/1466#comment:6>
Deluge
-----------------------------------+----------------------------------------
Reporter: cinderblock | Owner:
Priority: major | Milestone: 1.4.0
Component: core | Version: 1.3.1
Keywords: watermark,send buffer |
-----------------------------------+----------------------------------------
Comment(by andar):
I think this patch should look for the specific alert string "send buffer
watermark too low" and only then increase the watermark. The reasoning is
that there could be other performance alerts that aren't related to the
send buffer watermark.
--
Ticket URL: <http://dev.deluge-torrent.org/ticket/1466#comment:7>
Deluge
-----------------------------------+----------------------------------------
Reporter: cinderblock | Owner:
Priority: major | Milestone: 1.4.0
Component: core | Version: 1.3.1
Keywords: watermark,send buffer |
-----------------------------------+----------------------------------------
Changes (by ancient):
* cc: ancient@… (added)
--
Ticket URL: <http://dev.deluge-torrent.org/ticket/1466#comment:8>
Deluge
-----------------------------------+----------------------------------------
Reporter: cinderblock | Owner:
Priority: major | Milestone: 1.4.0
Component: core | Version: 1.3.1
Keywords: watermark,send buffer |
-----------------------------------+----------------------------------------
Comment(by tyeken8):
This patch is based on joshbeck ones.
Fix typos of that one.[[BR]]
Double the buffer only if the performance warning is about that.[[BR]]
Change cap to 50MB, since it seems the send buffer watermark should be
roughly your max upload per second. So 5MB is insufficient for a Gigabit
Ethernet.
--
Ticket URL: <http://dev.deluge-torrent.org/ticket/1466#comment:9>
Deluge
-----------------------------------+----------------------------------------
Reporter: cinderblock | Owner:
Priority: major | Milestone: 1.3.6
Component: core | Version: 1.3.1
Keywords: watermark,send buffer |
-----------------------------------+----------------------------------------
Changes (by Cas):
* milestone: 1.4.0 => 1.3.6
--
Ticket URL: <http://dev.deluge-torrent.org/ticket/1466#comment:10>
Deluge
Reporter: cinderblock | Owner:
Type: patch | Status: new
Priority: major | Milestone: 1.4.0
Component: Core | Version: 1.3.1
Resolution: | Keywords: watermark,send buffer
--------------------------+-----------------------------------
Comment (by amain):
Patch applies also nicely (some offsets) to 1.3.3. Flooding is stopped and
send buffer change is logged:
{{{
[DEBUG ] 11:47:51 torrentmanager:1099 performance_alert: ...:
performance warning: send buffer watermark too low (upload rate will
suffer)
[DEBUG ] 11:47:51 torrentmanager:1107 send_buffer_watermark set to
204800..
[DEBUG ] 11:47:51 torrentmanager:1099 performance_alert: ...:
performance warning: send buffer watermark too low (upload rate will
suffer)
[DEBUG ] 11:47:51 torrentmanager:1107 send_buffer_watermark set to
409600..
}}}
Thanks!
--
Ticket URL: <http://dev.deluge-torrent.org/ticket/1466#comment:10>
Deluge
Reporter: cinderblock | Owner: Cas
Type: patch | Status: assigned
Priority: major | Milestone: 1.4.0
Component: Core | Version: 1.3.1
Resolution: | Keywords: watermark,send buffer
--------------------------+-----------------------------------
* status: new => assigned
* owner: => Cas
Comment:
I have pushed a fix to develop: [ce6abe024758] (It is limited to 3MiB but
if a larger size is required the libtorrent plugin in the forum can be
used to alter `send_buffer_watermark`)
I have been unable to test it with an actual performance alert from
libtorrent so needs someone to verify it works correctly.
--
Ticket URL: <http://dev.deluge-torrent.org/ticket/1466#comment:11>
Deluge
Reporter: cinderblock | Owner: Cas
Priority: major | Milestone: 1.4.0
Component: Core | Version: 1.3.1
--------------------------+-----------------------------------
Changes (by Cas):
* status: assigned => closed
* resolution: => Fixed
Comment:
Finally got an alert to test this and looks to be good.
--
Ticket URL: <http://dev.deluge-torrent.org/ticket/1466#comment:12>
Deluge
Reporter: cinderblock | Owner: Cas
Type: patch | Status: closed
Priority: major | Milestone: 1.4.0
Component: Core | Version: 1.3.1
Resolution: Fixed | Keywords: watermark,send buffer
--------------------------+-----------------------------------
Comment (by keretamalam):
I am about to leave and cannot look into this further right now, but I do
want to mention that relying on pkg-config itself is not a problem (as you
said, we also use it later), the problem is that on some systems, the .pc
file for pkg-config is supplying wrong information (whereas on yours, it's
botan-config that is wrong), so that's why I'm trying to make it work with
both (while one of them is bad).
[http://maskodoq.blogspot.com/2014/03/unit-link-terbaik-di-indonesia.html
Unit Link Terbaik di Indonesia Commonwealth Life Investra Link]
[http://maskodoq.blogspot.com/2013/07/CiptoJunaedy.html Cipto Junaedy]
[http://etnisjawa.blogspot.com/2013/08/apakah-cipto-junaedy-bohong.html
Cipto Junaedy]
--
Ticket URL: <http://dev.deluge-torrent.org/ticket/1466#comment:13>