[Deluge] #3382: Notifications-0.3: improve smtplib.SMTP.sendmail() error logging

0 views
Skip to first unread message

Deluge

unread,
Apr 11, 2020, 9:30:43 AM4/11/20
to delug...@googlegroups.com
#3382: Notifications-0.3: improve smtplib.SMTP.sendmail() error logging
----------------------------+---------------------------
Reporter: lalbornoz | Type: patch
Status: new | Priority: minor
Milestone: needs verified | Component: Plugin
Version: 2.0.3 | Keywords: notifications
----------------------------+---------------------------
The Notifications plugin as of version 0.3 only includes the value of an
'''smtplib.SMTPException''' implicitly converted to a string in the log
file on error:

{{{
Apr 11 15:06:08 [REDACTED] deluged[31554]: 15:06:08 [ERROR
][deluge_notifications.core :160 ] There was an error sending the
notification email: {}
}}}

The patch enclosed includes both the exception type inasmuch as value in
the logged error to aid debugging, e.g. yielding:

{{{
Apr 11 15:19:41 [REDACTED] deluged[539]: 15:19:41 [ERROR
][deluge_notifications.core :162 ] There was an error sending the
notification email: <class 'smtplib.SMTPRecipientsRefused'>, {}
}}}

--
Ticket URL: <https://dev.deluge-torrent.org/ticket/3382>
Deluge <https://deluge-torrent.org/>
Deluge Project

Deluge

unread,
Apr 11, 2020, 9:30:56 AM4/11/20
to delug...@googlegroups.com
#3382: Notifications-0.3: improve smtplib.SMTP.sendmail() error logging
------------------------+----------------------------
Reporter: lalbornoz | Owner:

Type: patch | Status: new
Priority: minor | Milestone: needs verified
Component: Plugin | Version: 2.0.3
Resolution: | Keywords: notifications
------------------------+----------------------------
Changes (by lalbornoz):

* Attachment "deluge-2.0.3+smtp_errors_Notifications_plugin.patch" added.

Reply all
Reply to author
Forward
0 new messages