[Deluge] #3291: deluge-console exit code always "0"

[Deluge]

#3291: deluge-console exit code always "0"
----------------------------+------------------------
Reporter: fdge00 | Type: bug
Status: new | Priority: minor
Milestone: needs verified | Component: Console UI
Version: 1.3.15 | Keywords:
----------------------------+------------------------
OS: CentOS Linux release 7.6.1810 (Core)

if executing deluge-console and the command fails it still returns with an
error code of 0

{{{
deluge-console "config allow_remote"
Failed to connect to 127.0.0.1:58846 with reason: Connection refused

echo $?
0
}}}

--
Ticket URL: <https://dev.deluge-torrent.org/ticket/3291>
Deluge <https://deluge-torrent.org/>
Deluge Project

[Deluge]

#3291: deluge-console exit code always "0"

------------------------------+--------------------
Reporter: fdge00 | Owner:
Type: feature-request | Status: new
Priority: minor | Milestone: Future

Component: Console UI | Version: 1.3.15

Resolution: | Keywords:
------------------------------+--------------------
Changes (by Cas):

* type: bug => feature-request
* milestone: needs verified => Future

--
Ticket URL: <https://dev.deluge-torrent.org/ticket/3291#comment:1>

[Deluge]

#3291: deluge-console exit code always "0"

------------------------------+--------------------
Reporter: fdge00 | Owner:
Type: feature-request | Status: new
Priority: minor | Milestone: Future

Component: Console UI | Version: 1.3.15

Resolution: | Keywords:
------------------------------+--------------------

Comment (by marcelpaulo):

deluge 2.1.1 on Xubuntu 22.04 seems to set the exit code always to **1**,
whether the command succeeded:

{{{
paulo@monk:~/Downloads$ deluge-console status
Total upload: 0.0 KiB/s
Total download: 0.0 KiB/s
DHT Nodes: 370
Total torrents: 5
Allocating: 0
Checking: 0
Downloading: 1
Seeding: 4
Paused: 0
Error: 0
Queued: 0
Moving: 0
<Deferred at 0x7f1c18cc1f00 current result: None>
paulo@monk:~/Downloads$ echo $?
1
}}}

or failed:

{{{
paulo@monk:~/Downloads$ deluge-console add xxx
/home/paulo/Downloads/xxx does not exist!
<Deferred at 0x7fde1dc95c00 current result: None>
paulo@monk:~/Downloads$ echo $?
1
}}}

This prevents deluge-console from being properly used in scripts. It would
be useful if it could set its exit code to reflect if the operation worked
or not.

--
Ticket URL: <https://dev.deluge-torrent.org/ticket/3291#comment:2>

[Deluge]

#3291: deluge-console exit code always "0"

------------------------------+--------------------
Reporter: fdge00 | Owner:
Type: feature-request | Status: new
Priority: minor | Milestone: Future

Component: Console UI | Version: 1.3.15

Resolution: | Keywords:
------------------------------+--------------------

Comment (by Cas):

Replying to [comment:2 marcelpaulo]:

> deluge 2.1.1 on Xubuntu 22.04 seems to set the exit code always to
**1**, whether the command succeeded

This is a bug that was fixed recently and should be in the next release,
see #3582

--
Ticket URL: <https://dev.deluge-torrent.org/ticket/3291#comment:3>