Squeryl/Record support

10 views
Skip to first unread message

carlos.montemuino

unread,
Oct 23, 2012, 6:55:21 PM10/23/12
to dbsc...@googlegroups.com
Hi there, I just performed a pull request (#4) with Squeryl/Record support.
Besides code itself, I paid special attention on documentation. I'm much used to javadoc, so perhaps I made a couple of mistakes doing the same with scaladoc.
I think we have a bug in TestDataMaker.createAndGroupStudents
I'm getting an ArrayIndexOutOfBoundsExceptions there. As soon as the pull request is accepted, I'll try to create a unit test to confirm the problem.

Dave Briccetti

unread,
Oct 23, 2012, 9:54:44 PM10/23/12
to dbsc...@googlegroups.com
That’s very good, Carlos, Thanks a lot. I made some simplifications to some of the code, and changed some of the doc comments. If you don’t agree with anything, please, let’s discuss.

carlos.montemuino

unread,
Nov 1, 2012, 4:18:07 PM11/1/12
to dbsc...@googlegroups.com
Now I did one (and learn how to do it again), if you agree I could do the same with Assessment, AssessmentTag, Group, Musician, MusicianGroup, and User.

Dave Briccetti

unread,
Nov 1, 2012, 9:06:02 PM11/1/12
to dbsc...@googlegroups.com
It might be good to make the page for editing the set of instruments first, so we can enjoy the newly-gained benefits of using Record (and reassure me that we are on the right path). Let’s see if that gives us enough value to justify converting some of the other tables to Record. In any case, some of the tables, like MusicianGroup, may not benefit at all from using Record.

carlos.montemuino

unread,
Nov 2, 2012, 4:12:46 AM11/2/12
to dbsc...@googlegroups.com
ok, I'll do such way.
Reply all
Reply to author
Forward
0 new messages