Reviewing Carlos’s change: Database, Record, connection pool, etc.

[Dave Briccetti]

I don't have Review Board set up yet, so could I ask a Lift expert to review Carlos’s change? Is this a good way to go?

https://github.com/cmontemuino/dbschools/commit/86fae1b7d85f96d29e5cb76fa1e320fd4fc0cb4d

Thanks!

[Diego Medina]

On Thu, Oct 18, 2012 at 6:58 PM, Dave Briccetti <dcbri...@gmail.com> wrote:
> I don't have Review Board set up yet, so could I ask a Lift expert to review

At work we have been using github for code review and it has worked
pretty well, so I don't think you'll have to setup review board
(unless you prefer to, of course)


Thanks

Diego

> Carlos’s change? Is this a good way to go?
>
> https://github.com/cmontemuino/dbschools/commit/86fae1b7d85f96d29e5cb76fa1e320fd4fc0cb4d
>
> Thanks!
>

> --
>
>



--
Diego Medina
Lift/Scala Developer
di...@fmpwizard.com
http://www.fmpwizard.com

[Dave Briccetti]

Well that does seem to work nicely. Thanks!

On Thursday, October 18, 2012 4:18:33 PM UTC-7, di...@fmpwizard.com wrote:

At work we have been using github for code review ...