Janitizing

4 views
Skip to first unread message

Russo

unread,
Jun 9, 2009, 9:32:06 AM6/9/09
to DBJMIN
Hello Fellows, I am the janitor. I wash the shit away.

Right now, the shit is coming in the form of hundreds of warnings of
'raw type' when using parameterized types such as List or ArrayList.

Speaking of lists, the best practice tells us to always declare the
variable using the interface type, and construct using the concrete
type, e.g.:

List<String> myList = new ArrayList<String>();

There's a huge number of declarations of variables of the type
ArrayList, and that should be avoided, if nothing else, for the sake
of elegance.

I realize that some of the database drivers and JDBC APIs still use
raw types, so we can't simply replace everything, but I'll try to
replace these declarations whenever it's possible, one at a time, and
make small commits, for each piece.

Also, I'd like to run the Eclipse formatter on the whole source code
tree. Do you have any problems with that?

At some point, I intend to come with a build.xml for ANT, and we can
start thinking about automating builds (nightly builds?)

Cheers,
Russo

JOSE DAMICO

unread,
Jun 9, 2009, 4:17:53 PM6/9/09
to dbj...@googlegroups.com
Not problems at all!

Take care with shit, it is alive and can take you to the place where
it came from.

Thx a lot. I was afraid to touch these classes.

[]s

Damico

2009/6/9 Russo <rus...@gmail.com>:

Alexei Znamensky

unread,
Jun 27, 2009, 7:32:36 PM6/27/09
to dbjmin
I just made a big commit with a lot of changes. Although I tried to be as careful as possible, it would be really nice if we have some testing being done on the code.

Cheers,
Russo

2009/6/9 JOSE DAMICO <jd.co...@gmail.com>



--
Alexei Znamensky [russoz_gmail_com] [russoz.wordpress.com] [www.flickr.com/photos/alexeiz]
"Though we live in trying times, we're the ones who have to try"
Reply all
Reply to author
Forward
0 new messages