Contribution request

[David Bernard]

Hi,

To follow the process of [Contributing](https://code.google.com/p/dartbox2d/wiki/Contributing).

After signing the CLA, I send a email to the mailing list to say

  "Hello I have some changes to submit, but not yet send to Rietveld."

/davidB

[Dominic Hamon]

Hi David

You've picked an interesting time to have patches as I just moved the project to github, where pull requests can be considered much more easily.

I hope it's not too much of a pain to move your local repo over.

Dominic Hamon | Google

There are no bad ideas; only good ideas that go horribly wrong.

--
You received this message because you are subscribed to the Google Groups "Dartbox2d discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to dartbox2d-disc...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

[David Bernard]

:-D

When I wrote the previous mail (I removed the sentence, "using github pull request should easier for contribution").

I'll do the pull-request when github project will be ready. I made 3 local branches (one for each patch/pull-request) + 1 where every thing is merged for my usage.

[Dominic Hamon]

it should be ready to go now at http://github.com/google/dartbox2d.

I just need to confirm that we received the CLA and then i can accept your pull requests. Thank you so much!

[David Bernard]

Thanks you, for your work. (I stopped porting 'chypmunk physics' after 2 days, and migrate my code to dartbox2d, when I port my game from js to dart).

I submit 2 pull request, as the 3 third was already include in the updated master (getRange => sublist)