Incremental review for http://codereview.appspot.com/6440043

[Rupert Key]

Hi, Dominic

Done a chunk of code review on http://codereview.appspot.com/6440043 but not yet published.

Would be nice to know I'm doing the right sort of thing.  Does Rietveld (/you) handle partial/incremental review responses?

Wasn't sure whether you wanted (a) Dart, (b) Box2D, (c) performance and/or (d) design feedback so giving my best of (a) with bits of (b).  There're a couple of comments on (c) but little (d) -- happy to do but takes more groking/thinking ;-)  (might end-up doing regardless since paging new code into head will likely cause anyway!)  If any too much, please do say and ignore -- need to tune my levels ;-)  Alternatively, some of it can probably be left to future patches.

Cheers, R.

[Dominic Hamon]

On Wed, Jul 25, 2012 at 7:49 AM, Rupert Key <ruper...@gmail.com> wrote:

Hi, Dominic

Done a chunk of code review on http://codereview.appspot.com/6440043 but not yet published.

Would be nice to know I'm doing the right sort of thing.  Does Rietveld (/you) handle partial/incremental review responses?

If you mail your responses and put a note that it's still in progress, that helps me start work in parallel with your review. I won't commit until you reply with LGTM or something similar.

 

Wasn't sure whether you wanted (a) Dart, (b) Box2D, (c) performance and/or (d) design feedback so giving my best of (a) with bits of (b).  There're a couple of comments on (c) but little (d) -- happy to do but takes more groking/thinking ;-)  (might end-up doing regardless since paging new code into head will likely cause anyway!)  If any too much, please do say and ignore -- need to tune my levels ;-)  Alternatively, some of it can probably be left to future patches.

Whatever you have the time/energy for before you're happy to see this in the project. I want it to be a useful example of something a little more involved than a ball in a box, and having it be style-compliant and performant and Box2D correct and Dartish are all important :)

If you comment on something I disagree with, I'll let you know ;)

 

Cheers, R.

[Rupert Key]

On Wed, Jul 25, 2012 at 4:43 PM, Dominic Hamon <dom...@google.com> wrote:

On Wed, Jul 25, 2012 at 7:49 AM, Rupert Key <ruper...@gmail.com> wrote:

Done a chunk of code review on http://codereview.appspot.com/6440043 but not yet published.

Would be nice to know I'm doing the right sort of thing.  Does Rietveld (/you) handle partial/incremental review responses?

If you mail your responses and put a note that it's still in progress, that helps me start work in parallel with your review. I won't commit until you reply with LGTM or something similar.

Was going to send then saw only 3 more files so I've rushed through them.  (hope not missed too much!)

 

Wasn't sure whether you wanted (a) Dart, (b) Box2D, (c) performance and/or (d) design feedback so giving my best of (a) with bits of (b).  There're a couple of comments on (c) but little (d) -- happy to do but takes more groking/thinking ;-)  (might end-up doing regardless since paging new code into head will likely cause anyway!)  If any too much, please do say and ignore -- need to tune my levels ;-)  Alternatively, some of it can probably be left to future patches.

Whatever you have the time/energy for before you're happy to see this in the project. I want it to be a useful example of something a little more involved than a ball in a box, and having it be style-compliant and performant and Box2D correct and Dartish are all important :)

Couldn't agree more on the 'more real' demo point of view!  (I'm deliberating on whether to open-source my game in its entirety but I /do/ want to make some cash from /some/ of this ;-) )

 

If you comment on something I disagree with, I'll let you know ;)

Great!  The more feedback the better.  (for my growth, mwahahaha)

Cheers, R.