Issue 1279 in dactyl: Commit 7147 breaks tab-options.js

[dac...@googlecode.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium Project-Pentadactyl

New issue 1279 by philipp....@gmail.com: Commit 7147 breaks tab-options.js
https://code.google.com/p/dactyl/issues/detail?id=1279

Updating pentadactyl to hg 7147 or later breaks :tabclose when using
tab-options.js.

Neither using :tabclose nor clicking the close button on an active tab
closes said tab. Closing inactive tabs using the close button works.

What steps will reproduce the problem?
---
1. Install pentadactyl hg 7147 or later
2. Install tab-options.js from
http://dactyl.sf.net/pentadactyl/plugins#tab-options-plugin (either normal
oder -dev, doesn't matter)
3. Try to close a tab using :tabclose

What is the expected output? What do you see instead?
---
The currently active tab should close. It doesn't.

What is the output of :yank :version?
---
Pentadactyl hg7147-default (2015-02-22 21:01 -0800) running on:
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:36.0) Gecko/20100101 Firefox/36.0

Can you reproduce this problem with all custom configuration and plugins
disabled (i.e., running firefox -pentadactyl '+u NONE')?
---
No, since it seems to be related to tab-options.js. Reproducable with a new
profile with just pentadactyl and tab-options.js, though.


--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[dac...@googlecode.com]

Comment #1 on issue 1279 by maglion...@gmail.com: Commit 7147 breaks
tab-options.js
https://code.google.com/p/dactyl/issues/detail?id=1279

Works for me.

[dac...@googlecode.com]

Comment #2 on issue 1279 by philipp....@gmail.com: Commit 7147 breaks
tab-options.js
https://code.google.com/p/dactyl/issues/detail?id=1279

Which pentadactyl version did you use?

I've noticed that, even with hg 7146, the 'previous' option of tabclose
doesn't work, instead 'left' is used.

[dac...@googlecode.com]

Updates:
Status: Accepted

Comment #3 on issue 1279 by dougk...@gmail.com: Commit 7147 breaks
tab-options.js
https://code.google.com/p/dactyl/issues/detail?id=1279

There's some issues with updating plugins on the site at the moment but you
can use the attached until that's remedied.

Attachments:
tab-options-dev.js 7.7 KB

[dac...@googlecode.com]

Comment #4 on issue 1279 by philipp....@gmail.com: Commit 7147 breaks
tab-options.js
https://code.google.com/p/dactyl/issues/detail?id=1279

Thank you, the updated plugin you linked fixes the issues, latest
Pentadactyl (hg 7160) works fine now.

Pentadactyl hg7160-default (2015-03-02 19:01 -0800) running on:

Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:36.0) Gecko/20100101 Firefox/36.0