Issue 1213 in dactyl: Hint characters do not appear anymore

[dac...@googlecode.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium Project-Pentadactyl

New issue 1213 by Dario.Gj...@gmail.com: Hint characters do not appear
anymore
https://code.google.com/p/dactyl/issues/detail?id=1213

What steps will reproduce the problem?
1. Open up a webpage, for example 5digits.org
2. Press f/F/;v/whatever, you will see that no hint characters appear. The
links get the highlight and everything, but no hint characters.
3. Doing the same on an integral help page, such as :helpall, works as
expected.

What is the expected output? What do you see instead?

I should get highlighted links + hit characters for each of them. I get
highlighted links only (on pages other than internal ones).

What is the output of :yank :version, or the exact Pentadactyl version and
Firefox build identifier (see the about: page)?

I am running the latest Firefox and Pentadactyl nightlies (2014-09-17).

Can you reproduce this problem with all custom configuration and plugins
disabled (i.e., running firefox -pentadactyl '+u NONE')?

Yes, fresh Firefox profile (all that's added
is 'extensions.checkCompatibility.nightly set to false) + fresh Pentadactyl
yields the same result.

Please provide any additional information below.

Unfortunately, I cannot provide any more details such as the exact date of
when this happened. I know that the Firefox JS parser is currently
undergoing some changes.

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[dac...@googlecode.com]

Comment #1 on issue 1213 by Dario.Gj...@gmail.com: Hint characters do not
appear anymore
https://code.google.com/p/dactyl/issues/detail?id=1213

Here are the exact versions:

Pentadactyl hg7123 (created 2014/09/19 00:00:03) running on:
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:35.0) Gecko/20100101 Firefox/35.0

As well as two screenshots showing the issue.

Attachments:
Screenshot 2014-09-19 13.48.24.png 153 KB
Screenshot 2014-09-19 13.48.29.png 86.9 KB

[dac...@googlecode.com]

Comment #2 on issue 1213 by christie...@gmail.com: Hint characters do not
appear anymore
https://code.google.com/p/dactyl/issues/detail?id=1213

I'm noticing the same issue with Pentadactyl hg7123 and Nightly 35.0a1
(2014-09-22) as well as Aurora 34.0a2 (2014-09-22). Seems to work ok on
Beta 33.0 and Release 32.0.

[dac...@googlecode.com]

Comment #3 on issue 1213 by l.daniel...@gmail.com: Hint characters do not
appear anymore
https://code.google.com/p/dactyl/issues/detail?id=1213

I've reported this on IRC a couple of weeks ago. Glad to see it has made
its way into the issue tracker as well--I thought it was just my setup.

Still seeing the issue on the latest Firefox Nightly with the latest
Pentadactyl nightlies.

I recall testing the stable releases and it working there, though, so I'm
guessing it's a problematic change in Firefox that hasn't been pushed yet.
But it'll likely be a big issue when Firefox releases shift, so hopefully
it gets some work (I'd attempt a fix myself, but I'm not familiar enough
with the codebase).

Thanks for a fantastic add-on though. Amazing work.

[dac...@googlecode.com]

Comment #4 on issue 1213 by l.daniel...@gmail.com: Hint characters do not
appear anymore
https://code.google.com/p/dactyl/issues/detail?id=1213

Any idea what the issue may be, or where in the codebase it'd be located?

[dac...@googlecode.com]

Comment #5 on issue 1213 by scf.c...@gmail.com: Hint characters do not
appear anymore
https://code.google.com/p/dactyl/issues/detail?id=1213

Reproduces with 34.

[dac...@googlecode.com]

Comment #6 on issue 1213 by Ales.Gu...@gmail.com: Hint characters do not
appear anymore
https://code.google.com/p/dactyl/issues/detail?id=1213

Reproduces with 35.0a2 (Firefox Developer Edition, "Mozilla/5.0 (X11; Linux
x86_64; rv:35.0) Gecko/20100101 Firefox/35.0")

[dac...@googlecode.com]

Comment #7 on issue 1213 by sliker.h...@gmail.com: Hint characters do not
appear anymore
https://code.google.com/p/dactyl/issues/detail?id=1213

Firefox 34.0.5 is now released, this bug still persists in 34+ and as such
Pentadactyl is no longer usable with any version of Firefox.

[dac...@googlecode.com]

Comment #8 on issue 1213 by duguyip...@gmail.com: Hint characters do not
appear anymore
https://code.google.com/p/dactyl/issues/detail?id=1213

Reproduces here with firefox 34.

[dac...@googlecode.com]

Comment #9 on issue 1213 by wufen...@gmail.com: Hint characters do not
appear anymore
https://code.google.com/p/dactyl/issues/detail?id=1213

You need to change file chrome/common/content/bindings.xml

16c16
< <binding id="hints" inheritstyle="false">
---
> <binding id="hints" inheritstyle="false"
> bindToUntrustedContent="true">

help page is trust content for pentadactyl, so it works as expected.

more info see
https://blog.mozilla.org/addons/2014/11/13/compatibility-for-firefox-34/

[dac...@googlecode.com]

Comment #10 on issue 1213 by dy...@energysavvy.com: Hint characters do not
appear anymore
https://code.google.com/p/dactyl/issues/detail?id=1213

I can verify wufen's fix--on FF 34.0, Ubuntu 14.04.

[dac...@googlecode.com]

Comment #11 on issue 1213 by voigt.al...@gmail.com: Hint characters do not
appear anymore
https://code.google.com/p/dactyl/issues/detail?id=1213

created a patch for you guys hope that will help you solve these problems
faster :)

cd
<copy patch here>
hg clone http://dactyl.googlecode.com/hg/ dactyl
cd dactyl
patch -p1 < ../penta_ff34.patch
make -C pentadactyl xpi
firefox downloads/pentadactyl-1.2pre.xpi

Attachments:
penta_ff34.patch 838 bytes

[dac...@googlecode.com]

Comment #12 on issue 1213 by thomascm...@gmail.com: Hint characters do not
appear anymore
https://code.google.com/p/dactyl/issues/detail?id=1213

Fantastic! The patch restores hints with firefox 34.0.5-1 on arch.

[dac...@googlecode.com]

Updates:
Status: Fixed

Comment #13 on issue 1213 by dougk...@gmail.com: Hint characters do not
appear anymore
https://code.google.com/p/dactyl/issues/detail?id=1213

This issue was closed by revision 1dfa562ad9a5.

[dac...@googlecode.com]

Comment #14 on issue 1213 by roopeshvaddepally: Hint characters do not
appear anymore
https://code.google.com/p/dactyl/issues/detail?id=1213

this problem is fixed, but there is not nightly xpi released with this fix.
can some one run a build for people who cannot compile their own addons?

The way I fixed right now is:
1) go to about:support
2) open profile folder from "Profile Folder" item of "Application Basics"
3) cd to extensions folder
4) close all instances of firefox to update the addon
5) open the xpi file with 7zip
6) navigate to "chrome/common/content" and open bindings.xml with notepad
7) find 'binding id="frame"' in the text and added '
bindToUntrustedContent="true"' to it
8) 7zip saved the changes back into the xpi
9) restarted firefox

I'm listing out the steps for anyone who wants to fix this issue without
building the addon (for whatever reason)

A ready to install xpi would greatly appreciated.

[dac...@googlecode.com]

Comment #15 on issue 1213 by yiziy...@gmail.com: Hint characters do not
appear anymore
https://code.google.com/p/dactyl/issues/detail?id=1213

@roopeshvaddepally I followed your advice step by step，but it didn't
work.:( and in the end,i rolled down firefox to version 31.that's the only
way to use pentadactyl.

[dac...@googlecode.com]

Comment #16 on issue 1213 by mi...@lazarescu.org: Hint characters do not
appear anymore
https://code.google.com/p/dactyl/issues/detail?id=1213

I got this fixed installing pentadactyl-latest.xpi from here:

http://5digits.org/nightly/pentadactyl-latest.xpi

Pentadactyl 1.2pre-hg7140-default (created 2015/01/19 11:31:45) running on:

Mozilla/5.0 (X11; Linux x86_64; rv:35.0) Gecko/20100101 Firefox/35.0