[cython/cython] Support weakref in limited api cdef classes (PR #5840)
da-woods
Fixes #5793.
Note that this won't work on Python versions <3.9. (The code will compile fine, but the classes won't be weak referenceable).
You can view, comment on, or merge this pull request online at:
https://github.com/cython/cython/pull/5840
Commit Summary
- 100850d Support weakref in limited api cdef classes
File Changes
(4 files)
- M Cython/Compiler/ModuleNode.py (31)
- M Cython/Compiler/Nodes.py (2)
- M Cython/Utility/ModuleSetupCode.c (1)
- M tests/run/isolated_limited_api_tests.srctree (10)
Patch Links:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
scoder
We could print a C compiler warning when we detect that case. That would make the problem visible. It's then best for users to either require a newer Python version or work around the missing feature at runtime. We shouldn't fail the compilation for this.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
da-woods
@da-woods pushed 1 commit.
- 2245ebb Add C warning
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
da-woods
@da-woods pushed 1 commit.
- 35a2ff9 Update message a little
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
da-woods
@da-woods pushed 1 commit.
- 6b375b6 Merge branch 'master' into limited-api-weakref
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.