[cython/cython] Add operator-equal operators (PR #6197)
Erik Whiting
Hello Cython community. I wanted to take a stab at this issue as it looks like it hasn't ben addressed yet. Hoping the build CI passes and if not someone can point me in the right direction perhaps? Tried running tests locally but got a syntax error from Shadow.py
You can view, comment on, or merge this pull request online at:
https://github.com/cython/cython/pull/6197
Commit Summary
- c67b0c2 Add operator-equal operators
File Changes
(7 files)
- M Cython/Compiler/ExprNodes.py (5)
- M Cython/Compiler/Parsing.py (1)
- M tests/compile/operators.h (5)
- M tests/run/cpp_operator_exc_handling.pyx (40)
- M tests/run/cpp_operator_exc_handling_helper.hpp (60)
- M tests/run/cpp_operators.pyx (33)
- M tests/run/cpp_operators_helper.h (24)
Patch Links:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
da-woods
Doesn't look like the CI passes unfortunately.
I think the trick to running the tests locally is not even to try to install Cython. Just change directory to wherever the Cython git repo is and do python3 runtests.py whatever. That should use the version you have checked out rather that whatever you have installed.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Erik Whiting
Doesn't look like the CI passes unfortunately.
I think the trick to running the tests locally is not even to try to install Cython. Just change directory to wherever the Cython git repo is and do
python3 runtests.py whatever. That should use the version you have checked out rather that whatever you have installed.
thanks! I will try that. I did see the CI failed, I have been looking at it but will not be able to do a deep dive on it until this weekend. My guess is that I need to add support for the operators in some of the files in Cython/Includes/libcpp directory. That is my guess anyway and where I'll start first. This is my first submission to Cython so it will take me a while to get the PR right, but I'm on it 🫡
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.