A new pull request

19 views
Skip to first unread message

Nguyen Sy Thanh Son

unread,
Aug 7, 2011, 11:27:17 PM8/7/11
to cutefl...@googlegroups.com
Hi,

I have made a new pull request on Github. Please have an attention and let me know your comment about it.

And as i know, FOSUserBundle is good user management bundle for Symfony 2. i think that  inherit this bundle is a nice way.
How do you think about installing a project management such as Redmine? Redmine is great project management software for development team.



--
Best regards,

Thanh Son, Nguyen Sy  (Mr.) | System Architect

Asia | Vietnam Mobile: +84 902286958 
Thanh Liet | Thanh Tri Dist. | Hanoi, Vietnam
Website: http://kvs.org.vn | email: thanhs...@kvs.org.vn

Timo Haberkern

unread,
Aug 8, 2011, 3:11:51 AM8/8/11
to cutefl...@googlegroups.com
Hi,

i will take a look at it in a few hours, but from hat I have seen so far it is looking pretty good :)

Yes I have thought about using redmine or JIRA for CuteFlow. We have a new server where it is possible to install such tools. At the moment I tend to use JIRA because it is easiert to install and maintain (in my opinion :) )

Timo

2011/8/8 Nguyen Sy Thanh Son <thanhs...@gmail.com>



--
------------------------------------------
Contact network: https://www.xing.com/profile/Timo_Haberkern
Follow me on twitter: http://www.twitter.com/thaberkern

http://symfony-zone.com/wordpress
http://www.shift-up.de
http://www.server2go-web.de

Timo Haberkern

unread,
Aug 8, 2011, 4:14:31 AM8/8/11
to cutefl...@googlegroups.com
Hi,

I just merged your changes :)

Timo

2011/8/8 Timo Haberkern <Timo.ha...@fantastic-bits.de>

Nguyen Sy Thanh Son

unread,
Aug 8, 2011, 12:44:25 PM8/8/11
to cutefl...@googlegroups.com
Hi,

Thank you,

And next step, it is OK if i would like to develop Forgot password function.

If i can, please let me know something about your requirement.

Timo Haberkern

unread,
Aug 9, 2011, 4:09:12 AM8/9/11
to cutefl...@googlegroups.com
Hi,


>And next step, it is OK if i would like to develop Forgot password function.
That would be great.
Please remember to create a branch before you start to develop. This will make the pull request handling a lot easier. And you should always do a Git Rebase before creating a pull request.

Here are the requirements:

1.) There is a link on the login page. By clicking this link  a new page with a form is opening. The user should be able to enter his E-Mail-Adress in this form.
2.) After submitting the form a token should be generated (see https://github.com/FriendsOfSymfony/FOSUserBundle/blob/master/Model/User.php - generateToken for a very good implementation). This token is saved via the User Entity class (add a confirmationToken property).
3.) A recovery email should be sent to the user. The E-Mail contains a link (with the token) to a form where the user can change his password. The token needs to be checked here! After changing the password the token should be set to NULL again
4.) After saving the user should be redirected to the login form

That's it :) If you have any questions please ask

Nguyen Sy Thanh Son

unread,
Aug 10, 2011, 9:54:32 PM8/10/11
to cutefl...@googlegroups.com
hi Timo,

Sorry about my late response. Because i am quite busy in this week.
I think i will get started to develop this function in this weekend and finish it in end of next week.

So, if my schedule is not break your schedule, i can do it for you.

Thank for your time!

Timo Haberkern

unread,
Aug 11, 2011, 2:31:32 AM8/11/11
to cutefl...@googlegroups.com
Hi,

that schedule is fine for me :)

Timo

2011/8/11 Nguyen Sy Thanh Son <thanhs...@gmail.com>

Timo Haberkern

unread,
Sep 20, 2011, 8:19:10 AM9/20/11
to cutefl...@googlegroups.com
Hi,

is there any progress on this?

Timo

2011/8/11 Nguyen Sy Thanh Son <thanhs...@gmail.com>

Nguyen Sy Thanh Son

unread,
Sep 20, 2011, 9:16:23 AM9/20/11
to cutefl...@googlegroups.com
Hi,

I am really sorry about my delay for long time. 

Past time, i had big family job (build a new house). So i can not keep my schedule to develop your reseting password function.

But, i think i will have more free time in Octorber, i will go on developing your project. Is it OK?

Once more, i am sorry my delay time.

Timo Haberkern

unread,
Sep 21, 2011, 2:19:51 AM9/21/11
to cutefl...@googlegroups.com
Hi,

sounds good to me. I wish you a successful time building your new house :)

Timo

2011/9/20 Nguyen Sy Thanh Son <thanhs...@gmail.com>
Reply all
Reply to author
Forward
0 new messages