I came back :-) Domain model observations

[Fernando Aspiazu]

Hi all,

I apologize to be absent during this time, it has been a rough period ultimately, mainly at the job, but now the situation is good and calm enough :-)

So, I read the specifications docs/history either on trello, github, and documents requirements given time ago, for which Me and Max are already thinking and designing the schema design based on the specified application data access and interactions.

Also, I'm seeing the current entities in datastore module and I noticed the use of Aspects for each one.

The result is an Aspect for each Entity class (it's good and works anyway).

I realise that the intention is to have getters and setters for each entity and, if it is the unique intention, I'd like to suggest you to use "Lombok" Project instead aspects in order to get the same result with less code and less classes to compile (maybe is more readable so).

Here the Lombok link: http://projectlombok.org/index.html

If everybody agree with this, I could proceed to make the changes and hopping it's possible with some new entities together.

As soon as it's possible, I will share you a document with the schema design of domain model to be approved by all you obviously :-)

I'm available for further ideas, suggestions and corrections.

Thanks.

Fernando.

[Koray Gülcü]

Hi Fernando,

It sounds interesting. But I think it's better to check if there are any spring AOP/AspectJ interoperability issues. I've just gone through open issues and #28 looks quite suspicious.

http://code.google.com/p/projectlombok/issues/list

Maybe you can try a proof-of-concept implementation by applying to a small subset of the entities and share your work with us so as to understand the benefits.

Best regards.
Koray

Koray Gülcü
koray...@gmail.com

Fernando.

--
CrowdGuru Developers Group
www.crowdguru.org
https://github.com/crowdguru/crowdguru
---
You received this message because you are subscribed to the Google Groups "CrowdGuru Development Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email to crowdguru-de...@googlegroups.com.
To post to this group, send an email to crowdg...@googlegroups.com.
Visit this group at http://groups.google.com/group/crowdguru-dev.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

[Fernando Aspiazu]

Hi Koray,

Yesterday I was trying to integrate lombok, indeed there are one problem with aspectJ.

Pratically, Lombok works similarly to AspectJ, both generate bytecode by launching ajc for aspects and javac for java code.

First, Lombok launches javac in order to make his work, after that AspectJ compiler is lauched and it overwrites the Lombok job, depriving POJO's of their getters and setters.

One solution might be launch first AspectJ compiler and after that launch Lombok compiler by using ANT-MAVEN-PLUGIN as explained here: https://weblogs.java.net/blog/fabriziogiudici/archive/2011/07/19/making-lombok-aspectj-and-maven-co-exist

I could try to test if that solution works as well.

At the moment, I don't consider this as a big problem, we can keep the actual aspects for each entity.

It remains my main target the domain model, in the meantime I can make the test above :-)

Regards.

Fernando.

[Koray Gülcü]

Agreed. At least we have an alternative way If it becomes too polluting :).

It's a good idea to focus on missing fundamentals at this point.

Koray Gülcü
koray...@gmail.com