Few simple questions..

9 views
Skip to first unread message

ifiult

unread,
Feb 10, 2012, 8:05:26 PM2/10/12
to Croogo
Hi guys, is a pleasure to join this group!

I have some questions...
- The Croogo 1.4 beta is fully compatible with the CakePHP 2.x?
- My another question, sorry I did not understand, but what is the
intent of this line? Why set null after insert data into database?
https://github.com/croogo/croogo/blob/1.4/Controller/UsersController.php#L175
Line: 175
$this->request->data['User']['password'] = null;


And a simple suggestion.. What do you think of the change on line 166
https://github.com/croogo/croogo/blob/1.4/Controller/UsersController.php
# L166
Current:
if (! empty ($ this-> request-> data)) {...
Change:
if (! empty ($ this-> request-> data) && $ this-> request-> is
('post')) {...

Thank you very much! ;)
(Sorry for my bad english, it is not my native language.)

Rachman Chavik

unread,
Feb 11, 2012, 6:54:00 AM2/11/12
to cro...@googlegroups.com
On Saturday, 11 February 2012 08:05:26 UTC+7, ifiult wrote:
Hi guys, is a pleasure to join this group!

I have some questions...
- The Croogo 1.4 beta is fully compatible with the CakePHP 2.x?

Yes, I'm developing against 2.x, although mostly 2.1.
 
- My another question, sorry I did not understand, but what is the
intent of this line? Why set null after insert data into database?
        https://github.com/croogo/croogo/blob/1.4/Controller/UsersController.php#L175
        Line: 175
        $this->request->data['User']['password'] = null;

I'm not sure, perhaps for security reasons?
 

And a simple suggestion.. What do you think of the change on line 166
https://github.com/croogo/croogo/blob/1.4/Controller/UsersController.php
# L166
Current:
if (! empty ($ this-> request-> data)) {...
Change:
if (! empty ($ this-> request-> data) && $ this-> request-> is
('post')) {...

That seems the way to go with 2.x.  There will a quite few changes like this because I only change $this->data to $this->request->data.
Perhaps you could submit a pull request in github ?
Reply all
Reply to author
Forward
0 new messages