Merging Roles to master

[Michael Goffin]

I am posting this to both crits-users and crits-developers to get feedback.

Roles is an extremely large feature with major changes to the interface and how CRITs is managed for users. Some highlights:

- Users no longer have sources assigned to them

- Users have Roles assigned to them

- Roles manage a user's access to different features of CRITs including entire pieces of the interface TLOs, and other things.

- Roles can also have sources assigned to them which grant users access to those sources.

- There is a requirement that at least one account in the system be granted the UberAdmin role (a special role with access to EVERYTHING, including ALL SOURCES)

- Services will have changes as well but this should be more background than anything.

This allows people to manage users in different ways:

- A Role per job description complete with sources and access to different parts of the system

- Roles which are focused on access to different parts of the system and Roles which only grant access to certain sources.

The latter seems like the more common use-case for people who have lots of sources to break down between different job descriptions, but the point is that this is very flexible.

Roles comes with a graphical view of  content so you can see what sources a user has access to after their roles are combined and which roles are granting that access. It will also come with a "Combinator" that will allow you to see what happens when multiple Roles are granted to a single user and verify that it is the expected level of access.

The issue here is that the amount of stuff to test is staggering, and the more time that takes, the more code is being committed every day, causing us to have to re-test everything. Our thought is that instead of allowing people to continue to commit code to non-Role code, we merge Roles into Master. This causes some problems:

- You will most definitely see some things break and we need those things reported!

- If you want to help contribute to fixing the code, we will need help with that as well (PLEASE)

- If you run Master in your production environment, you'll want to switch to stable_4 so your data doesn't get messed up by accident.

- Be prepared to reading UPDATING to ensure you know how to get your system working with Roles

- Your users will all lose access to everything they had access to before, so you'll need to spend time recreating their access through Roles

- You need to absolutely make sure your crits_services code is using the same branch as your core code is.

When we feel Master is stable enough, we will be branching stable_5. This means stable_4 will no longer be updated with new code/features and stable_5 will be the new hotness for production hosts.

So the general question is...what are people's thoughts on temporarily making Master much less bug-free than it is now with the intent of getting those bugs fixed in very short order and branching stable_5 for production use?

Mike

[Clinton D'souza]

I would be up for moving my dev environment to the master branch to help with supporting the roles integration and testing and reporting bugs. Currently stable_4 according to me is at a good place and has been working well for me and my team in terms of usability and automation, so I'm ready to help with testing the new Master branch should you go ahead with it. 

What happens to the issues raised about the current anomalies on the master branch ? Are they going to be worked on ? 

Thanks for the awesome work and great tool. Looking forward to the next release. 

Thanks, 

Clinton 

[Michael Goffin]

Awesome!

I suspect the issues that are currently around for Master will still apply. The Roles stuff really only adjusts the code so that prior to executing a potentially sensitive block of code, it verifies the user should be allowed to see/do that block of code (it sounds more awesome when you say it that way ;) ). So proper issues with functionality shouldn't really go away, just need to be fixed in a new set of code.

Mike

--
You received this message because you are subscribed to the Google Groups "crits-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to crits-users+unsubscribe@googlegroups.com.
To post to this group, send email to crits...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/crits-users/8be81e2d-a1d7-43d1-add8-4721aa46d1fa%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

[Michael Goffin]

I made the merge!