Groups keyboard shortcuts have been updated
Dismiss
See shortcuts

[VOTE] Release 0.9

3 views
Skip to first unread message

Julien Nioche

unread,
Oct 18, 2017, 5:24:52 AM10/18/17
to crawler...@googlegroups.com
Hi, 

We don't have any open issues flagged for 0.9 and we have recently added some nice improvements, which I think we should release ASAP.

There is a discussion in #177 about removing the DOM based sitemap parsing, we could do that in 0.9 or deprecate it for now and postpone its removal.

Please vote between:
(A) Deprecate DOM parser then release 0.9
(B) Remove DOM parser then release 0.9
(C) Don't release 0.9 yet - please explain why

Thanks!

Julien

Sebastian Nagel

unread,
Oct 18, 2017, 7:27:31 AM10/18/17
to crawler...@googlegroups.com
B

- although option A sounds better but ...

> (A) Deprecate DOM parser then release 0.9

What shall deprecation exactly mean? Move/swap classes?
SiteMapParser -> SiteMapParserDOM @Deprecated
SiteMapParserSAX -> SiteMapParser

SiteMapParserSAX extends the DOM-based SiteMapParser, we can hardly deprecate SiteMapParser.


I've checked whether SiteMapParser and SiteMapParserSAX are in sync and
opened #180 (normalize the RSS pubDate). Flagged as "milestone 0.9":
should get into the release for both A and B.

Sebastian


On 10/18/2017 11:24 AM, Julien Nioche wrote:
> Hi, 
>
> We don't have any open issues flagged for 0.9
> <https://github.com/crawler-commons/crawler-commons/issues?q=is%3Aopen+is%3Aissue+milestone%3A0.9> and
> we have recently added some nice improvements, which I think we should release ASAP.
>
> There is a discussion in #177 <https://github.com/crawler-commons/crawler-commons/issues/177> about
> removing the DOM based sitemap parsing, we could do that in 0.9 or deprecate it for now and postpone
> its removal.
>
> Please vote between:
> (A) Deprecate DOM parser then release 0.9
> (B) Remove DOM parser then release 0.9
> (C) Don't release 0.9 yet - please explain why
>
> Thanks!
>
> Julien
>
>
> --
> *
> */Open Source Solutions for Text Engineering/
> /
> /http://www.digitalpebble.com <http://www.digitalpebble.com/>
> http://digitalpebble.blogspot.com/
> #digitalpebble <http://twitter.com/digitalpebble>
>
> --
> You received this message because you are subscribed to the Google Groups "crawler-commons" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to
> crawler-commo...@googlegroups.com <mailto:crawler-commo...@googlegroups.com>.
> Visit this group at https://groups.google.com/group/crawler-commons.
> For more options, visit https://groups.google.com/d/optout.

Julien Nioche

unread,
Oct 18, 2017, 9:12:45 AM10/18/17
to crawler...@googlegroups.com
BTW my vote was 'B'

B

- although option A sounds better but ...

> (A) Deprecate DOM parser then release 0.9

What shall deprecation exactly mean?  Move/swap classes?
  SiteMapParser     -> SiteMapParserDOM @Deprecated
  SiteMapParserSAX  -> SiteMapParser

SiteMapParserSAX extends the DOM-based SiteMapParser, we can hardly deprecate SiteMapParser.

indeed. for some reason I thought we had already done #156 when I typed my previous email, but of course it is not the case.



I've checked whether SiteMapParser and SiteMapParserSAX are in sync and
opened #180 (normalize the RSS pubDate). Flagged as "milestone 0.9":
should get into the release for both A and B.

Merged

Thanks

Julien
 
--
You received this message because you are subscribed to the Google Groups "crawler-commons" group.
To unsubscribe from this group and stop receiving emails from it, send an email to crawler-commons+unsubscribe@googlegroups.com.

Ken Krugler

unread,
Oct 19, 2017, 11:35:20 AM10/19/17
to crawler...@googlegroups.com
A, though only mildly more than B.

— Ken

On Oct 18, 2017, at 2:24 AM, Julien Nioche <lists.dig...@gmail.com> wrote:

Hi, 

We don't have any open issues flagged for 0.9 and we have recently added some nice improvements, which I think we should release ASAP.

There is a discussion in #177 about removing the DOM based sitemap parsing, we could do that in 0.9 or deprecate it for now and postpone its removal.

Please vote between:
(A) Deprecate DOM parser then release 0.9
(B) Remove DOM parser then release 0.9
(C) Don't release 0.9 yet - please explain why

Thanks!

Julien

--------------------------
Ken Krugler
custom big data solutions & training
Hadoop, Cascading, Cassandra & Solr

Julien Nioche

unread,
Oct 27, 2017, 2:47:19 AM10/27/17
to crawler...@googlegroups.com
Hi,

Thanks for voting. Option B got 2 votes so we'll go for that. I'll merge #181 and will start releasing 0.9 later today.

Julien

 

--
You received this message because you are subscribed to the Google Groups "crawler-commons" group.
To unsubscribe from this group and stop receiving emails from it, send an email to crawler-commons+unsubscribe@googlegroups.com.
Visit this group at https://groups.google.com/group/crawler-commons.
For more options, visit https://groups.google.com/d/optout.
Reply all
Reply to author
Forward
0 new messages