Release v1.2 of CC

12 views
Skip to first unread message

Avi Hayun

unread,
Aug 20, 2021, 2:11:15 AM8/20/21
to crawler-commons

A year and a month have passed since releasing v1.1
I would be saddened to see 2021 pass without a release in it.

What do you think ?

Lewis John Mcgibbney

unread,
Aug 20, 2021, 6:04:22 AM8/20/21
to crawler...@googlegroups.com
Hi Avi,
I think it would be wise for us to upgrade this project to JDK11 compatibility. That would certainly justify a release.
Lewis 

--
You received this message because you are subscribed to the Google Groups "crawler-commons" group.
To unsubscribe from this group and stop receiving emails from it, send an email to crawler-commo...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/crawler-commons/02107176-5047-44cc-8512-be7255cd7cd3n%40googlegroups.com.
--
Lewis
Dr. Lewis J. McGibbney Ph.D, B.Sc
Skype: lewis.john.mcgibbney



Avi Hayun

unread,
Aug 20, 2021, 6:27:47 AM8/20/21
to crawler...@googlegroups.com
Good idea,

Any tips about what should be included in this upgrade except updating the pom.xml file and running the tests?

Will it cause failings in projects which already use our library ?

Ken Krugler

unread,
Aug 20, 2021, 11:58:27 AM8/20/21
to crawler...@googlegroups.com
Hi Lewis,

Are you talking about compiling w/Java 11 as the source, but still generating (via -target) Java 8 class files?

If so, then yes that seems like a good idea, though see https://bugs.openjdk.java.net/browse/JDK-8058150 about needing to also configure the build to avoid using new APIs that are only in Java 11 runtime.

— Ken


--------------------------
Ken Krugler
Custom big data solutions
Flink, Pinot, Solr, Elasticsearch





--------------------------
Ken Krugler
Custom big data solutions
Flink, Pinot, Solr, Elasticsearch



Lewis John Mcgibbney

unread,
Aug 20, 2021, 1:10:20 PM8/20/21
to crawler...@googlegroups.com
Please see inline 

On Fri, Aug 20, 2021 at 03:27 Avi Hayun <avra...@gmail.com> wrote:
Good idea,

Any tips about what should be included in this upgrade except updating the pom.xml file and running the tests?

I would check for Javac deprecation warnings. I anticipate issues with Javaric generation as well.


Will it cause failings in projects which already use our library ?

Java is now at 18 I think… 1.8 is pretty old. I don’t have the timelines at hand for long term support for the JDK 1.8 but I wouldn’t be surprised if it is not supported anymore.
I haven’t used 1.8 for a few years now… I kinda pegged everything on 11. 



On Fri, Aug 20, 2021 at 1:04 PM Lewis John Mcgibbney <lewis.m...@gmail.com> wrote:
Hi Avi,
I think it would be wise for us to upgrade this project to JDK11 compatibility. That would certainly justify a release.
Lewis 

On Thu, Aug 19, 2021 at 23:11 Avi Hayun <avra...@gmail.com> wrote:

A year and a month have passed since releasing v1.1
I would be saddened to see 2021 pass without a release in it.

What do you think ?

--
You received this message because you are subscribed to the Google Groups "crawler-commons" group.
To unsubscribe from this group and stop receiving emails from it, send an email to crawler-commo...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/crawler-commons/02107176-5047-44cc-8512-be7255cd7cd3n%40googlegroups.com.
--
Lewis
Dr. Lewis J. McGibbney Ph.D, B.Sc
Skype: lewis.john.mcgibbney



--
You received this message because you are subscribed to the Google Groups "crawler-commons" group.
To unsubscribe from this group and stop receiving emails from it, send an email to crawler-commo...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/crawler-commons/CAGaRif0FRFuhE93n5An-bingsr7m_JZeVpJd_sgy6GDtLv0ooA%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "crawler-commons" group.
To unsubscribe from this group and stop receiving emails from it, send an email to crawler-commo...@googlegroups.com.

Aécio

unread,
Aug 20, 2021, 2:27:01 PM8/20/21
to crawler...@googlegroups.com
The latest stable Java version is 16, and Java 17 (the next LTS version) is due next month (September) (https://en.wikipedia.org/wiki/Java_version_history). I would be in favor of moving on to Java 11, or at the very least that this should be the last one to support Java 8.

BTW, Nutch seems to have moved on to Java 11 as well.


Lewis John Mcgibbney

unread,
Aug 20, 2021, 9:12:21 PM8/20/21
to crawler...@googlegroups.com
Excellent thanks for clarifying.
I’ve been gradually making my way around the Apache search engine stack upgrading to JDK11… 

Avi Hayun

unread,
Aug 21, 2021, 2:48:33 PM8/21/21
to crawler...@googlegroups.com

Sebastian Nagel

unread,
Oct 1, 2021, 10:06:34 AM10/1/21
to crawler-commons
Hi,

there's now a security issue (https://github.com/crawler-commons/crawler-commons/pull/323 - already fixed) which would justify a soon release of 1.2

Maybe we postpone the Java / JDK upgrade?

I'll try to address the other two open issues for 1.2 - https://github.com/crawler-commons/crawler-commons/milestone/8

#321 - better to have it now to avoid extra API changes over releases
#322 - also security somehow

I'll try to work on #321 over the weekend. Are you working on #322, Avi Hayun?

Any other thoughts?

Sebastian

Aécio

unread,
Oct 4, 2021, 12:03:18 PM10/4/21
to crawler...@googlegroups.com
+1 to postpone the JDK upgrade in favor of a release.

--
You received this message because you are subscribed to the Google Groups "crawler-commons" group.
To unsubscribe from this group and stop receiving emails from it, send an email to crawler-commo...@googlegroups.com.

Lewis John Mcgibbney

unread,
Oct 4, 2021, 6:39:52 PM10/4/21
to crawler...@googlegroups.com

Avi Hayun

unread,
Oct 5, 2021, 7:18:35 AM10/5/21
to crawler...@googlegroups.com
I have removed myself from #322, so if anybody is free, let's finish this one and continue to a release

About the release, the J11 upgrade seems quite important, but it might be complicated, so I will stand with the majority on this one.

Sebastian Nagel

unread,
Oct 6, 2021, 12:46:21 PM10/6/21
to crawler...@googlegroups.com
Hi everybody,

all issues are resolved now. Thanks, everybody for contributions, reviews, etc.

I'll prepare a release candidate.

Sebastian

On 10/5/21 1:18 PM, Avi Hayun wrote:
> I have removed myself from #322, so if anybody is free, let's finish this one and continue to a release
>
> About the release, the J11 upgrade seems quite important, but it might be complicated, so I will stand with the majority on this one.
>
> On Tue, Oct 5, 2021 at 1:39 AM Lewis John Mcgibbney <lewis.m...@gmail.com <mailto:lewis.m...@gmail.com>> wrote:
>
> I agree
>
> On Mon, Oct 4, 2021 at 09:03 Aécio <aecio....@gmail.com <mailto:aecio....@gmail.com>> wrote:
>
> +1 to postpone the JDK upgrade in favor of a release.
>
> On Fri, Oct 1, 2021 at 10:06 AM 'Sebastian Nagel' via crawler-commons <crawler...@googlegroups.com
> <mailto:crawler...@googlegroups.com>> wrote:
>
> Hi,
>
> there's now a security issue (https://github.com/crawler-commons/crawler-commons/pull/323
> <https://github.com/crawler-commons/crawler-commons/pull/323> - already fixed) which would justify a soon release of 1.2
>
> Maybe we postpone the Java / JDK upgrade?
>
> I'll try to address the other two open issues for 1.2 - https://github.com/crawler-commons/crawler-commons/milestone/8
> <https://github.com/crawler-commons/crawler-commons/milestone/8>
>
> #321 - better to have it now to avoid extra API changes over releases
> #322 - also security somehow
>
> I'll try to work on #321 over the weekend. Are you working on #322, Avi Hayun?
>
> Any other thoughts?
>
> Sebastian
> On Friday, August 20, 2021 at 8:11:15 AM UTC+2 avra...@gmail.com <mailto:avra...@gmail.com> wrote:
>
> A year and a month have passed since releasing v1.1
> I would be saddened to see *2021* pass without a release in it.
>
> What do you think ?
>
> --
> You received this message because you are subscribed to the Google Groups "crawler-commons" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to crawler-commo...@googlegroups.com
> <mailto:crawler-commo...@googlegroups.com>.
> <https://groups.google.com/d/msgid/crawler-commons/f300f833-1b62-421f-8b82-71a837a02141n%40googlegroups.com?utm_medium=email&utm_source=footer>.
>
> --
> You received this message because you are subscribed to the Google Groups "crawler-commons" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to crawler-commo...@googlegroups.com
> <mailto:crawler-commo...@googlegroups.com>.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/crawler-commons/CAOrZYMiaRiA0J534qu4su64skytHVezj-_kzTFDtboG7wz%2BhCw%40mail.gmail.com
> <https://groups.google.com/d/msgid/crawler-commons/CAOrZYMiaRiA0J534qu4su64skytHVezj-_kzTFDtboG7wz%2BhCw%40mail.gmail.com?utm_medium=email&utm_source=footer>.
>
> --
> /Lewis
> /
> Dr. Lewis J. McGibbney Ph.D, B.Sc
> *Skype*: lewis.john.mcgibbney
>
>
>
> --
> You received this message because you are subscribed to the Google Groups "crawler-commons" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to crawler-commo...@googlegroups.com
> <mailto:crawler-commo...@googlegroups.com>.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/crawler-commons/CAGaRif2rK%3D6Z61MxDn7wT2j_0A1G46LGSv8nHwT%3DSV03G%2BC3Rg%40mail.gmail.com
> <https://groups.google.com/d/msgid/crawler-commons/CAGaRif2rK%3D6Z61MxDn7wT2j_0A1G46LGSv8nHwT%3DSV03G%2BC3Rg%40mail.gmail.com?utm_medium=email&utm_source=footer>.
>
> --
> You received this message because you are subscribed to a topic in the Google Groups "crawler-commons" group.
> To unsubscribe from this topic, visit https://groups.google.com/d/topic/crawler-commons/bIOUgR0qRaU/unsubscribe
> <https://groups.google.com/d/topic/crawler-commons/bIOUgR0qRaU/unsubscribe>.
> To unsubscribe from this group and all its topics, send an email to crawler-commo...@googlegroups.com
> <mailto:crawler-commo...@googlegroups.com>.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/crawler-commons/CAKLtEQNau%3DMfhL2qjgZhJW6N-LeJATTNk2G%3D8yL7%2BA3C3854JA%40mail.gmail.com
> <https://groups.google.com/d/msgid/crawler-commons/CAKLtEQNau%3DMfhL2qjgZhJW6N-LeJATTNk2G%3D8yL7%2BA3C3854JA%40mail.gmail.com?utm_medium=email&utm_source=footer>.

Sebastian Nagel

unread,
Oct 7, 2021, 3:32:43 PM10/7/21
to crawler...@googlegroups.com
Hi,

could anybody in the crawler-commons sonatype group
confirm my request to be added the group? See
https://issues.sonatype.org/browse/OSSRH-15721

Thanks!

Sebastian

Julien Nioche

unread,
Oct 8, 2021, 4:29:37 AM10/8/21
to crawler...@googlegroups.com

done!

To unsubscribe from this group and stop receiving emails from it, send an email to crawler-commo...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/crawler-commons/e35f8fe8-0cec-576d-4f70-1a282bb8adcc%40googlemail.com.


--
Reply all
Reply to author
Forward
0 new messages