[VOTE] release 1.3

[Sebastian Nagel]

Hi,

a first release candidate for 1.3 is ready

- changes:

https://github.com/crawler-commons/crawler-commons/blob/crawler-commons-1.3/CHANGES.txt

- git tag:

https://github.com/crawler-commons/crawler-commons/releases/tag/crawler-commons-1.3

- artifacts:
https://oss.sonatype.org/content/repositories/comgithubcrawler-commons-1023/


- you can test the release candidate with Maven by inserting the following into
your pom.xml:

<dependencies>
<dependency>
<groupId>com.github.crawler-commons</groupId>
<artifactId>crawler-commons</artifactId>
<version>1.3</version>
</dependency>
...

<repositories>
<repository>
<id>crawler-commons-release-test</id>
<name>Testing crawler-commons 1.3 release candidate</name>

<url>https://oss.sonatype.org/content/repositories/comgithubcrawler-commons-1023/</url>
</repository>
</repositories>


I'll update the Javadocs, README etc. once the vote has passed.


Here's my +1
- upgraded a sitemap parser test project to use crawler-commons 1.3 and
- parsed the sitemaps of a test collections without any regressions


Thanks,
Sebastian

[Avi Hayun]

I am +1 for this release

--
You received this message because you are subscribed to the Google Groups "crawler-commons" group.
To unsubscribe from this group and stop receiving emails from it, send an email to crawler-commo...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/crawler-commons/6d95c97c-3c06-ef40-ccc0-7b9b8d5bcac9%40googlemail.com.

[Richard Zowalla]

+1

- tested with a crawler4j session 

Gruß

Richard

[Aécio]

+1

--

Aécio

To view this discussion on the web visit https://groups.google.com/d/msgid/crawler-commons/CAHBhw7D5%2BFLNEhZU5jKXPL%2Bi4h177rdX6cM5qPJnxFVO6CKGZQ%40mail.gmail.com.

[Sebastian Nagel]

Thanks for the votes! I'll continue with the release...

+1 from
Aécio
Richard
Avi
Sebastian

On 7/24/22 22:48, Aécio wrote:
> +1
>
> --
> Aécio
>
>
> On Sat, Jul 23, 2022 at 9:22 AM Richard Zowalla <fear...@gmail.com
> <mailto:fear...@gmail.com>> wrote:
>
> +1
>
> - tested with a crawler4j session 
>
> Gruß
> Richard
>
> Am Di., 19. Juli 2022 um 13:00 Uhr schrieb 'Sebastian Nagel' via
> crawler-commons <crawler...@googlegroups.com

> <mailto:crawler...@googlegroups.com>>:

[Sebastian Nagel]

Hi,

unfortunately, I've found an issue while testing the Javadoc / API docs for 1.3,
see https://github.com/crawler-commons/crawler-commons/issues/378

The "broken" search.js is included in the file crawler-commons-1.3-javadoc.jar
- of course, it's only observable if it's unpacked and the search box is used
- for the web site I've committed a work-around and the API docs seem to work
https://crawler-commons.github.io/crawler-commons/1.3/

Anyway, shall I search for a reliable solution and then spin a new release
candidate? Or is the work-around sufficient?

Best,
Sebastian

[Richard Zowalla]

Hi,

I think, that fixing search.js is sufficient. Don't think that many users will use the extracted javadoc locally.

We can fix it permanently with 1.4 / 2.0 (whatever we want to name the next version with J11 baseline).

Gruß

Richard

--
You received this message because you are subscribed to the Google Groups "crawler-commons" group.
To unsubscribe from this group and stop receiving emails from it, send an email to crawler-commo...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/crawler-commons/c39bb593-d4ba-8b16-73f7-a60aba5e4a59%40googlemail.com.

[Sebastian Nagel]

Hi Richard,

thanks.

> Don't think that many users will
> use the extracted javadoc locally.

Yes, most use an IDE which implements a search and does not rely
on the Javascript search.

I'll continue with the release...

Best,
Sebastian

On 7/27/22 20:09, Richard Zowalla wrote:
> Hi,
>
> I think, that fixing search.js is sufficient. Don't think that many users will
> use the extracted javadoc locally.
> We can fix it permanently with 1.4 / 2.0 (whatever we want to name the next
> version with J11 baseline).
>
> Gruß
> Richard
>
> Am Di., 26. Juli 2022 um 17:40 Uhr schrieb 'Sebastian Nagel' via crawler-commons

> <crawler...@googlegroups.com <mailto:crawler...@googlegroups.com>>:

> >> <mailto:fear...@gmail.com <mailto:fear...@gmail.com>>> wrote:
> >>
> >>     +1
> >>
> >>     - tested with a crawler4j session 
> >>
> >>     Gruß
> >>     Richard
> >>
> >>     Am Di., 19. Juli 2022 um 13:00 Uhr schrieb 'Sebastian Nagel' via
> >>     crawler-commons <crawler...@googlegroups.com
> <mailto:crawler...@googlegroups.com>

> >>     <mailto:crawler...@googlegroups.com

> <mailto:crawler-commons%2Bunsu...@googlegroups.com>.

> To view this discussion on the web visit
> https://groups.google.com/d/msgid/crawler-commons/c39bb593-d4ba-8b16-73f7-a60aba5e4a59%40googlemail.com

> <https://groups.google.com/d/msgid/crawler-commons/c39bb593-d4ba-8b16-73f7-a60aba5e4a59%40googlemail.com>.

>
> --
> You received this message because you are subscribed to the Google Groups
> "crawler-commons" group.
> To unsubscribe from this group and stop receiving emails from it, send an email
> to crawler-commo...@googlegroups.com

> <mailto:crawler-commo...@googlegroups.com>.

> To view this discussion on the web visit

> https://groups.google.com/d/msgid/crawler-commons/CAHBhw7DG%2B5Fz7pvx6ae1NQqNighM%3DQQBBKC%3Dngq8m3T7QP3dvQ%40mail.gmail.com
> <https://groups.google.com/d/msgid/crawler-commons/CAHBhw7DG%2B5Fz7pvx6ae1NQqNighM%3DQQBBKC%3Dngq8m3T7QP3dvQ%40mail.gmail.com?utm_medium=email&utm_source=footer>.