[VOTE] release 1.2

[Sebastian Nagel]

Hi,

I have pushed a release candidate for 1.2

- changes:
https://github.com/crawler-commons/crawler-commons/blob/crawler-commons-1.2/CHANGES.txt

- git tag:
https://github.com/crawler-commons/crawler-commons/releases/tag/crawler-commons-1.2

- artifacts:
https://oss.sonatype.org/content/repositories/comgithubcrawler-commons-1015/


- you can test the release candidate with Maven by inserting the following into your pom.xml:

<dependencies>
<dependency>
<groupId>com.github.crawler-commons</groupId>
<artifactId>crawler-commons</artifactId>
<version>1.2</version>
</dependency>
...

<repositories>
<repository>
<id>crawler-commons-release-test</id>
<name>Testing crawler-commons 1.2 release candidate</name>
<url>https://oss.sonatype.org/content/repositories/comgithubcrawler-commons-1015/</url>
</repository>
</repositories>


I'll update the Javadocs, README etc. once the vote has passed.


Here's my +1


Thanks,
Sebastian

[Aécio]

For people using Gradle:

repositories {
    mavenCentral()
    maven {
        url "https://oss.sonatype.org/content/repositories/comgithubcrawler-commons-1015/"
    }
}

...

dependencies {

    implementation group: 'com.github.crawler-commons', name: 'crawler-commons', version: '1.2'

}

I tested it and it's all good.

+1

Thanks for the release Sebastian,

Aécio

--
You received this message because you are subscribed to the Google Groups "crawler-commons" group.
To unsubscribe from this group and stop receiving emails from it, send an email to crawler-commo...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/crawler-commons/189f79d0-c60a-c8e9-ac63-72f69332dfeb%40googlemail.com.

[Avi Hayun]

I am +1

What about the dependency upgrade (using the depndabot) and the gitAction instead of the travis - do they get into the release ?

[Sebastian Nagel]

Hi Avi,

> What about the dependency upgrade (using the dependabot) and the gitAction instead of the travis - do

> they get into the release ?

Good question. No, they're not included. They happened after the release candidate was prepared (creating the git tag, etc.) The upload of
the release candidate to the Sonatype staging repository was then delayed for two days because I had to wait until my account was linked to
the crawler-commons project.

Also: the dependency upgrades, afaics, only affect Maven plugins and unit test libs.
It's not about a security fix in an upstream dependency. Maybe no need to bother about it.

Best,
Sebastian

> <https://groups.google.com/d/msgid/crawler-commons/189f79d0-c60a-c8e9-ac63-72f69332dfeb%40googlemail.com>.

>
> --
> You received this message because you are subscribed to the Google Groups "crawler-commons" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to crawler-commo...@googlegroups.com

> <mailto:crawler-commo...@googlegroups.com>.

> To view this discussion on the web visit

> https://groups.google.com/d/msgid/crawler-commons/28b241af-e70a-402a-81e3-9539b8711de6n%40googlegroups.com
> <https://groups.google.com/d/msgid/crawler-commons/28b241af-e70a-402a-81e3-9539b8711de6n%40googlegroups.com?utm_medium=email&utm_source=footer>.

[Julien Nioche]

Thanks Sebastian,

Am getting some differences in the StormCrawler test for the sitemap extensions (number of elements returned is not the same). Will investigate but this should not be a blocker.

Julien

--
You received this message because you are subscribed to the Google Groups "crawler-commons" group.
To unsubscribe from this group and stop receiving emails from it, send an email to crawler-commo...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/crawler-commons/189f79d0-c60a-c8e9-ac63-72f69332dfeb%40googlemail.com.

--

Open Source Solutions for Text Engineering

http://www.digitalpebble.com
http://digitalpebble.blogspot.com/
#digitalpebble

[Julien Nioche]

This was simply due to https://github.com/crawler-commons/crawler-commons/issues/300

All good! +1 from me

[Sebastian Nagel]

Thanks for the votes! I'll continue with the release...

+1 from
Aécio
Avi
Julien
Sebastian

On 10/11/21 11:26 AM, Julien Nioche wrote:
> This was simply due to https://github.com/crawler-commons/crawler-commons/issues/300
> <https://github.com/crawler-commons/crawler-commons/issues/300>
>
> All good! +1 from me
>

> <mailto:crawler-commons%2Bunsu...@googlegroups.com>.

> To view this discussion on the web visit

> https://groups.google.com/d/msgid/crawler-commons/189f79d0-c60a-c8e9-ac63-72f69332dfeb%40googlemail.com
> <https://groups.google.com/d/msgid/crawler-commons/189f79d0-c60a-c8e9-ac63-72f69332dfeb%40googlemail.com>.
>
>
>
> --

> *
> */Open Source Solutions for Text Engineering/
> /
> /http://www.digitalpebble.com <http://www.digitalpebble.com/>
> http://digitalpebble.blogspot.com/ <http://digitalpebble.blogspot.com/>
> #digitalpebble <http://twitter.com/digitalpebble>
>
>
>
> --
> *
> */Open Source Solutions for Text Engineering/
> /
> /http://www.digitalpebble.com <http://www.digitalpebble.com/>
> http://digitalpebble.blogspot.com/ <http://digitalpebble.blogspot.com/>
> #digitalpebble <http://twitter.com/digitalpebble>

>
> --
> You received this message because you are subscribed to the Google Groups "crawler-commons" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to crawler-commo...@googlegroups.com

> <mailto:crawler-commo...@googlegroups.com>.

> To view this discussion on the web visit

> https://groups.google.com/d/msgid/crawler-commons/CA%2B-fM0sYPH4aCp_Qy-fjUVsNwXApMz0iBCmqOMiH5Mh9yfoWoA%40mail.gmail.com
> <https://groups.google.com/d/msgid/crawler-commons/CA%2B-fM0sYPH4aCp_Qy-fjUVsNwXApMz0iBCmqOMiH5Mh9yfoWoA%40mail.gmail.com?utm_medium=email&utm_source=footer>.