CCrashHandler::GenerateErrorReport() bug

84 views
Skip to first unread message

Gisle Vanem

unread,
Jul 24, 2015, 8:20:06 PM7/24/15
to Crashrpt
I found a a bug in "reporting/crashrpt/CrashHandler.cpp" around line 1291:

    if(pExceptionInfo->pexcptrs==NULL)
    {
      GetExceptionPointers(pExceptionInfo->code, &ExceptionPointers);
      pExceptionInfo->pexcptrs = &ExceptionPointers;
    }

Looks better if this is:

    if(pExceptionInfo->pexcptrs != NULL)
    {
      GetExceptionPointers(pExceptionInfo->code, &ExceptionPointers);
      pExceptionInfo->pexcptrs = &ExceptionPointers;
    }

I.e. Tests.exe works better with no crash in CrashSender :-)

--gv

a For

unread,
Feb 3, 2016, 7:13:18 PM2/3/16
to Crashrpt
original code looks correct...
Reply all
Reply to author
Forward
0 new messages