Submit patch

[Kostia Shepelevych]

Hello,

Could you please review & submit CoverStory patch with some fixes?

Thanks,
Kostia Shepelevych
Software MacKiev, SSE

===========================================
Done:
- added support for opening of single .gcov files
- fixed UI freeze in case of lots of processed files
- fixed UI freeze in case of lots of generated errors in log
- fixed unstopped progress spinner

[Thomas Van Lenten]

I think most of what you mention was fixed a little while ago, have you tried pulling the current sources?

TVL

--
You received this message because you are subscribed to the Google Groups "coverstory-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to coverstory-disc...@googlegroups.com.
To post to this group, send email to coverstor...@googlegroups.com.
Visit this group at http://groups.google.com/group/coverstory-discuss.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

[Kostia Shepelevych]

Hello,

Just in case my previous reply was not received. The provided patch is made against current sources (r184 and valid for r185) and the fixes included are crucial for CoverStory to be used with our projects (otherwise it is not usable at all, especially for iOS projects). I have now next patch to provide, so could you please let me know your decision on this patch?

Thanks and regards,

Kostia

Середа, 24 липня 2013 р. 09:44:37 UTC+3 користувач Tom Van Lenten написав:

I think most of what you mention was fixed a little while ago, have you tried pulling the current sources?

TVL

On Wed, Jul 24, 2013 at 1:26 AM, Kostia Shepelevych <sh...@mail.ru> wrote:

Hello,

Could you please review & submit CoverStory patch with some fixes?

Thanks,
Kostia Shepelevych
Software MacKiev, SSE

===========================================
Done:
- added support for opening of single .gcov files
- fixed UI freeze in case of lots of processed files
- fixed UI freeze in case of lots of generated errors in log
- fixed unstopped progress spinner

--
You received this message because you are subscribed to the Google Groups "coverstory-discuss" group.

To unsubscribe from this group and stop receiving emails from it, send an email to coverstory-discuss+unsub...@googlegroups.com.

[Dave MacLachlan]

Kostia,

Are you sure that your patch is required with the latest release? We're using it on a very large iOS app with no problems. Would you please break your patch up into subpatches and file bugs appropriately so that we can track what's being fixed and test against it?

Sorry to be a pain, but your patch is rather large and seems to address a whole pile of issues.

Cheers,
Dave

To unsubscribe from this group and stop receiving emails from it, send an email to coverstory-disc...@googlegroups.com.

[Dave MacLachlan]

BTW we really appreciate your patches. I really hope you will follow through so that we can apply them appropriately.

Cheers,

Dave

[Kostia Shepelevych]

Hello,

> Are you sure that your patch is required with the latest release?

Well, actually no. Now we use internally built CoverStory with all these fixes. It would be just correct (and better) to have it tracked centralized instead of local, moreover this might help for others as well.

> We're using it on a very large iOS app with no problems.

I believe you, but in our case it is "with". The world (of projects) is various. :)

> Would you please break your patch up into subpatches and file bugs appropriately so that we can track what's being fixed and test against it?

This will be not so fast, because, as you might imaging, to fix CoverStory is not my main responsibility here. But I'll try.

Kind regards,

Kostia

Пʼятниця, 26 липня 2013 р. 23:17:11 UTC+3 користувач dmaclach написав:

To unsubscribe from this group and stop receiving emails from it, send an email to coverstory-discuss+unsubscribe@googlegroups.com.

To post to this group, send email to coverstor...@googlegroups.com.

Visit this group at http://groups.google.com/group/coverstory-discuss.
For more options, visit https://groups.google.com/groups/opt_out.