the behavior of the dynamic_properties argument to views

19 views
Skip to first unread message

Ronny Pfannschmidt

unread,
Apr 13, 2012, 12:21:53 PM4/13/12
to couch...@googlegroups.com
hi,

currently the behavior of  is based on a boolean and it always changes the classes of the schema classes
by assinging to cls._allow_dynamic_properties

think that is rather problematic

i would like to propose slowly phasing it into not changing the classes unless requested,
(default of None, and not setting of the parameter if it is None)
and maybe creating dynamic/static subclasses of the static/dynamic classes that where given

ideally the parameter would eventually get removed, and one would have to use something more explicit like make_dynamic(StaticDocument) or make_static(DynamicDocument) when passing the schema

-- Ronny

Benoit Chesneau

unread,
Apr 14, 2012, 11:41:29 AM4/14/12
to couch...@googlegroups.com

What is important here is having a StaticDocument class. possibly without rewriting too much code. Having `make_*` is not really intuitive although. I would prefer to find a way to edit the class to make it really static. But i'm +1 to not touch to the class object dynamicallly and create instance based on a StaticDocument class.

- benoît

Reply all
Reply to author
Forward
0 new messages