Dear Emily,
Congratulations on finding a bug in my code which no-one else has
spotted in the 17 years since I wrote it!
Although this is undeniably a bug, I don't think it will make
much difference to the simulator outputs other than frac_out,
as long as the convective cloud properties such as convective
cloud water etc are all initialised to zero. The only effect
it will have I think is to have a single clear pixel which is
vertically overlapped like a convective cloud rather than a
normal clear-sky pixel.
I'd be interested to know if fixing the bug has any effect on
the other simulator outputs.
Thanks,
Mark
On Mon, Jul 24, 2017 at 02:05:23PM -0600, Emily Riley wrote:
> Hi Steve,
> Your suggested fix helped. I no longer have any sub-columns inside scops.f
> assigned 2 (i.e., convective cloud) when my input file contains no
> convective cloud information.
> Thanks for the suggestion,
> Emily
>
> On Jul 20, 2017, at 1:27 PM, Klein, Stephen A. <[1]
kle...@llnl.gov>
> wrote:
> Dear Emily,
>
> Thanks for identifying this issue. I will give it some attention soon,
> but fortunately it is a rare occurrence.
>
> You could perform a check for me. If you change the if statement from:
>
> "if (threshold(j,ibox).le.conv(j,ilev)) "
>
> to
>
> "if (threshold(j,ibox).le.conv(j,ilev) .and. conv(j,ilev).gt.0.) "
>
> does this eliminate the problem?
>
> Steve
>
> Email: [7]
em...@atmos.colostate.edu
> Website: [8]
emilymriley.weebly.com
>
> --
> You received this message because you are subscribed to the Google
> Groups "COSP users group" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to [9]
cosp-user+...@googlegroups.com.
> For more options,
> visit [10]
http://secure-web.cisco.com/1RgdZrqHlZn5oQymv_G4TV5k6jMC-Ic7TJ4q43MoF8EP_MIt32K8vYoEVeHHYNbgkWI02LR2mdAcewsg7iDikj1Pji7NHzI1iIjYNGzOdq2wJsfPqEZlLD12G_WeeaTY8EHBwONIE5MCUTsSg3vLzY8OU5gKo6xltL3z8Qbcn_cvGu7YQXLMgFwwTSlhFT9yH9w6LuWNYKmmd9PHD0zY8vkbzDhaHTz-swAvv5lh6LWuwHx1t8jfuHYIqUvXplhEa9axxTY8ZkG3CuNT2SuJypAR0Obc-8mkztqLVfLIGxCWL0AucBDmaB0d3KaXeno9cjboDwHTVvyf8aQvqVkCzatjFQGQaWfHd8dt1b81x8HdnWmybII2b7pOkfuqzVfALaQm0vXjf_VQ-xvJETBi4J-659A3KPptvEG-7UCtfGdoae_ybVnKX0rEimf0_p2WfiWB_GzaajHQIVkJQ4ZwvmIQ9JZXZDwzgjoUB9WGSwc8V0AmbfYuogbJJMAyy26K_/l34%3Ahttps%3A%2F%2Fgroups.google.com%2Fd%2Foptoute.
>
> --
> You received this message because you are subscribed to a topic in the
> Google Groups "COSP users group" group.
> To unsubscribe from this topic,
> visit [11]
https://groups.google.com/d/topic/cosp-user/uUn3L4nI4bI/unsubscribe.
> To unsubscribe from this group and all its topics, send an email
> to [12]
cosp-user+...@googlegroups.com.
> For more options, visit [13]
https://groups.google.com/d/optout.
>
> --
> You received this message because you are subscribed to the Google Groups
> "COSP users group" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to [14]
cosp-user+...@googlegroups.com.
> For more options, visit [15]
https://groups.google.com/d/optout.
>
> References
>
> Visible links
> 1. mailto:
kle...@llnl.gov
> 2. mailto:
cosp...@googlegroups.com
> 3. mailto:
emilyr...@gmail.com
> 4. mailto:
cosp...@googlegroups.com
> 5. mailto:
cosp...@googlegroups.com
> 6. mailto:
cosp...@googlegroups.com
> 7. mailto:
em...@atmos.colostate.edu
> 8.
http://emilymriley.weebly.com/
> 9.
http://secure-web.cisco.com/1R7-oOQY_Fg5XApkAeYruMXIQsejv2KRbdHXexpypczVBBmTyLAD8H4QHLQJupEDr41Rbv73m-0WbD521-T3-jUM06Noa3k8Xs1pCbik9L_Qo5abGjPRl2OAo1XK1BZSYEggbpi-wmevqIwCqtjBh6lFD5w454TVpHvC4ldZ-Mr2RYeb4oP8vsKrcwtq6x_2l87_cVBJ2q8c24k5U6ouvzSJYGhYXcWi-7SoJrCSgPyMHhB4CXAQ6vCopE7hdP8Cy-EOvBapR4Vz_jI0XNtkj0iuZMMxQ0huoWBbzCZv5p10XlSHWZYrsBkQjmS7gxpbEUUub7YmCp5AWqj2IsPk0yu3vwfKErfaqkg6iXG3emSdUU8K0ioHmHNYbzdM9lJfQYsk-9TwWibAVykKSXEt5gfRZ6hb0Pm2fSxMgRkxE1qwwCHUBqAjBeKxS7B_Gn5GAaQe94RJJm2ff3cWHGIqIh71zGmMpuPdQQRHktY21sgAOgSjXlCKFtivS7BJkHlWd/l45%3Amailto%3Acosp-user%2Bunsubscribe%40googlegroups.come
> 10.
http://secure-web.cisco.com/1RgdZrqHlZn5oQymv_G4TV5k6jMC-Ic7TJ4q43MoF8EP_MIt32K8vYoEVeHHYNbgkWI02LR2mdAcewsg7iDikj1Pji7NHzI1iIjYNGzOdq2wJsfPqEZlLD12G_WeeaTY8EHBwONIE5MCUTsSg3vLzY8OU5gKo6xltL3z8Qbcn_cvGu7YQXLMgFwwTSlhFT9yH9w6LuWNYKmmd9PHD0zY8vkbzDhaHTz-swAvv5lh6LWuwHx1t8jfuHYIqUvXplhEa9axxTY8ZkG3CuNT2SuJypAR0Obc-8mkztqLVfLIGxCWL0AucBDmaB0d3KaXeno9cjboDwHTVvyf8aQvqVkCzatjFQGQaWfHd8dt1b81x8HdnWmybII2b7pOkfuqzVfALaQm0vXjf_VQ-xvJETBi4J-659A3KPptvEG-7UCtfGdoae_ybVnKX0rEimf0_p2WfiWB_GzaajHQIVkJQ4ZwvmIQ9JZXZDwzgjoUB9WGSwc8V0AmbfYuogbJJMAyy26K_/l34%3Ahttps%3A%2F%2Fgroups.google.com%2Fd%2Foptoute
> 11.
https://groups.google.com/d/topic/cosp-user/uUn3L4nI4bI/unsubscribe
> 12. mailto:
cosp-user+...@googlegroups.com
> 13.
https://groups.google.com/d/optout
> 14. mailto:
cosp-user+...@googlegroups.com
> 15.
https://groups.google.com/d/optout
--
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Mark Webb Climate Scientist
Met Office Hadley Centre
FitzRoy Road Exeter EX1 3PB United Kingdom
Tel:
+44 (0)1392 884515 Fax:
+44 (0)1392 885681
E-mail:mark...@metoffice.gov.uk http://www.metoffice.gov.uk
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~