A tiny issue in cosp_modis_simulator.F90 (COSP v1.4.1)

[Tsuyoshi Koshiro]

Hi,

I found a tiny issue with the MODIS simulator updated in COSP 1.4.1.

For the new outputs, joint-histograms of particle sizes and optical
depth (tau), all values of the first tau bin are undefined, though
they are not used for analysis. The following lines should be added
in cosp_modis_simulator.F90 for setting missing values:

allocate(x%Optical_Thickness_vs_Cloud_Top_Pressure(nPoints, numModisTauBins+1, numModisPressureBins))
allocate(x%Optical_Thickness_vs_ReffICE(nPoints, numModisTauBins+1, numModisReffIceBins))
allocate(x%Optical_Thickness_vs_ReffLIQ(nPoints, numModisTauBins+1, numModisReffLiqBins))
x%Optical_Thickness_vs_Cloud_Top_Pressure(:, :, :) = R_UNDEF
+ x%Optical_Thickness_vs_ReffICE(:, :, :) = R_UNDEF
+ x%Optical_Thickness_vs_ReffLIQ(:, :, :) = R_UNDEF
END SUBROUTINE CONSTRUCT_COSP_MODIS

In addition, these values are in units of not "%" but "1", right?

Best regards,

Tsuyoshi

--
Tsuyoshi Koshiro <tkos...@mri-jma.go.jp>
Research Associate, Climate Research Department,
Meteorological Research Institute, Japan Meteorological Agency
1-1 Nagamine, Tsukuba, Ibaraki, 305-0052, Japan
Phone:+81-29-853-8593 Fax:+81-29-855-2552

[Tsuyoshi Koshiro]

Hi again,

My explanation was not clear enough in the previous email.

> For the new outputs, joint-histograms of particle sizes and optical
> depth (tau), all values of the first tau bin are undefined, though
> they are not used for analysis. The following lines should be added
> in cosp_modis_simulator.F90 for setting missing values:
>
> allocate(x%Optical_Thickness_vs_Cloud_Top_Pressure(nPoints, numModisTauBins+1, numModisPressureBins))
> allocate(x%Optical_Thickness_vs_ReffICE(nPoints, numModisTauBins+1, numModisReffIceBins))
> allocate(x%Optical_Thickness_vs_ReffLIQ(nPoints, numModisTauBins+1, numModisReffLiqBins))
> x%Optical_Thickness_vs_Cloud_Top_Pressure(:, :, :) = R_UNDEF
> + x%Optical_Thickness_vs_ReffICE(:, :, :) = R_UNDEF
> + x%Optical_Thickness_vs_ReffLIQ(:, :, :) = R_UNDEF
> END SUBROUTINE CONSTRUCT_COSP_MODIS

These values are set as follows in cosp_modis_simulator.F90 (L273-274):

modisSim%Optical_Thickness_vs_ReffICE(sunlit(:),2:numModisTauBins+1,:) = jointHistogram2(:, :, :)
modisSim%Optical_Thickness_vs_ReffLIQ(sunlit(:),2:numModisTauBins+1,:) = jointHistogram3(:, :, :)

Thus, the first tau bin is dummy. I think this is correct, but the
values in the first tau bin are undefined.

> In addition, these values are in units of not "%" but "1", right?

Although the CMIP6 data request defines that these values are in units
of "%", the outputs seem to be in units of "1". Perhaps the following
lines are needed in cosp_simulator.F90:

if (cfg%Lclmodis) then
where(modis%Optical_Thickness_vs_Cloud_Top_Pressure /= R_UNDEF) modis%Optical_Thickness_vs_Cloud_Top_Pressure = &
modis%Optical_Thickness_vs_Cloud_Top_Pressure*100.0
endif
+ if (cfg%Lcrimodis) then
+ where(modis%Optical_Thickness_vs_ReffIce /= R_UNDEF) modis%Optical_Thickness_vs_ReffIce = &
+ modis%Optical_Thickness_vs_ReffIce*100.0
+ endif
+ if (cfg%Lcrlmodis) then
+ where(modis%Optical_Thickness_vs_ReffLiq /= R_UNDEF) modis%Optical_Thickness_vs_ReffLiq = &
+ modis%Optical_Thickness_vs_ReffLiq*100.0
+ endif


Any comments would be appreciated.

Many thanks,

Tsuyoshi

--
Tsuyoshi Koshiro <tkos...@mri-jma.go.jp>
Research Associate, Climate Research Department,
Meteorological Research Institute, Japan Meteorological Agency
1-1 Nagamine, Tsukuba, Ibaraki, 305-0052, Japan

At Fri, 06 Oct 2017 15:33:11 +0900,

[Bodas-Salcedo, Alejandro]

Dear Tsuyoshi,

Many thanks for reporting this. I've had a look at this and I think you're right, those lines should be in the 1.4.1 patch.

Regards,

Alejandro

> --
> You received this message because you are subscribed to the Google Groups
> "COSP users group" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to
> cosp-user+...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.