Issue 49 in cortex-vfx: port cortex to windows

[corte...@googlecode.com]

Status: New
Owner: ----

New issue 49 by sunhaohu...@gmail.com: port cortex to windows
http://code.google.com/p/cortex-vfx/issues/detail?id=49

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?


Please use labels and text to provide additional information.
add __declspec(dllimport)/(dllexport) to class declarations
add typename to C::value_type
empty object cannot be saved or hashed on windows.it's stl's fault not my
fault!
I only compile most of the ops.
some bugs remain check results.txt

[corte...@googlecode.com]

Comment #1 on issue 49 by sunhaohu...@gmail.com: port cortex to windows
http://code.google.com/p/cortex-vfx/issues/detail?id=49

add __declspec(dllimport)/(dllexport) to class declarations
add typename to C::value_type
empty object cannot be saved or hashed on windows.it's stl's fault not my
fault!
I only compile most of the ops.
some bugs remain check results.txt

Attachments:
49.patch 518 KB

[corte...@googlecode.com]

Comment #2 on issue 49 by sunhaohu...@gmail.com: port cortex to windows
http://code.google.com/p/cortex-vfx/issues/detail?id=49

ADD msvc project file

Attachments:
49.patch 2.3 MB

[corte...@googlecode.com]

Comment #3 on issue 49 by hra...@gmail.com: port cortex to windows
http://code.google.com/p/cortex-vfx/issues/detail?id=49

Tried to build the latest trunk with this patch in Linux and it fails:

include/IECore/IntrusivePtr.inl: In copy
constructor 'IECore::IntrusivePtr<T>::IntrusivePtr(const
IECore::IntrusivePtr<T>&)':
include/IECore/IntrusivePtr.inl:71: error: 'RefCounted' was not declared in
this scope
include/IECore/IntrusivePtr.inl:71: error: expected primary-expression
before ')' token
include/IECore/IntrusivePtr.inl:71: error: there are no arguments
to 'intrusive_ptr_add_ref' that depend on a template parameter, so a
declaration of 'intrusive_ptr_add_ref' must be available


It seems you've used 'RefCounted' class in IntrusivePtr.inl, but
RefCounted.h includes IntrusivePtr.inl itself. As RefCounted is not yet
defined, gcc doesn't like it!

Does MSVC builds it without errors?

-H

[corte...@googlecode.com]

Comment #4 on issue 49 by sunhaohu...@gmail.com: port cortex to windows
http://code.google.com/p/cortex-vfx/issues/detail?id=49

if I don't use RefCounted msvc will throw "can not convert from xxx to
RefCounted*" error when dll exporting some template class.It's really hard
to dllexport specific template class.I also want to have a better a way to
handle this.Can we add #ifndef WIN32/#endif to this?

[corte...@googlecode.com]

Comment #5 on issue 49 by thehaddo...@gmail.com: port cortex to windows
http://code.google.com/p/cortex-vfx/issues/detail?id=49

Roberto, do you think you could create a branch (from the trunk) for this
and apply the patch to it? That way people can look at the diffs and add
code reviews very easily, and we can start to get things shaped up so they
could be merged back. From my first (admittedly quick) look at the patch,
there's a fair bit of tidying up needed before it's suitable for the
trunk...

[corte...@googlecode.com]

Comment #6 on issue 49 by sunhaohu...@gmail.com: port cortex to windows
http://code.google.com/p/cortex-vfx/issues/detail?id=49

i have finished this.here is my new header file

Attachments:
IntrusivePtr.inl 5.4 KB

[corte...@googlecode.com]

Comment #7 on issue 49 by hra...@gmail.com: port cortex to windows
http://code.google.com/p/cortex-vfx/issues/detail?id=49

Yes John... I can do that. Sorry the delay in answering but I was on
holiday!

I'll apply the latest IntrusivePtr.inl into the latest trunk and as soon as
I can make it build OK in linux, I'll branch it!

cheers...
-H