[ImageEngine/cortex] 6f9983: USD PrimitiveAlgo : Fix loading of facevarying ski...

[John Haddon]

Branch: refs/heads/RB-10.5
Home: https://github.com/ImageEngine/cortex
Commit: 6f9983b52cac6562d3241f248e1d9024e41625a5
https://github.com/ImageEngine/cortex/commit/6f9983b52cac6562d3241f248e1d9024e41625a5
Author: John Haddon <thehad...@gmail.com>
Date: 2024-09-16 (Mon, 16 Sep 2024)

Changed paths:
M Changes
M contrib/IECoreUSD/src/IECoreUSD/PrimitiveAlgo.cpp
M contrib/IECoreUSD/test/IECoreUSD/USDSceneTest.py
A contrib/IECoreUSD/test/IECoreUSD/data/skinnedFaceVaryingNormals.usda

Log Message:
-----------
USD PrimitiveAlgo : Fix loading of facevarying skinned normals


Commit: fd80130600a78750b94377d807e83cc6ad158aef
https://github.com/ImageEngine/cortex/commit/fd80130600a78750b94377d807e83cc6ad158aef
Author: John Haddon <thehad...@gmail.com>
Date: 2024-09-16 (Mon, 16 Sep 2024)

Changed paths:
M contrib/IECoreUSD/src/IECoreUSD/PrimitiveAlgo.cpp

Log Message:
-----------
USD PrimitiveAlgo : Remove comment

The remapping discussed appears to be performed for us inside `UsdSkelSkinningQuery::ComputeSkinnedPoints()` and `UsdSkelSkinningQuery::ComputeSkinnedNormals()`, as well as in our new facevarying normals code. That would explain why an attempt to apply it manually would lead to things getting jumbled up.


Commit: d9525b8b4cd9b84419d43fe9aeca7760d423ecd3
https://github.com/ImageEngine/cortex/commit/d9525b8b4cd9b84419d43fe9aeca7760d423ecd3
Author: John Haddon <thehad...@gmail.com>
Date: 2024-09-16 (Mon, 16 Sep 2024)

Changed paths:
M Changes
M contrib/IECoreUSD/src/IECoreUSD/PrimitiveAlgo.cpp
M contrib/IECoreUSD/test/IECoreUSD/USDSceneTest.py
A contrib/IECoreUSD/test/IECoreUSD/data/skinnedFaceVaryingNormals.usda

Log Message:
-----------
Merge pull request #1432 from johnhaddon/facevaryingNormalSkinning

USD PrimitiveAlgo : Fix loading of facevarying skinned normals


Compare: https://github.com/ImageEngine/cortex/compare/b6350fba87a5...d9525b8b4cd9

To unsubscribe from these emails, change your notification settings at https://github.com/ImageEngine/cortex/settings/notifications