[ImageEngine/cortex] a3cbdc: USD skinning data : Improve clarity

[John Haddon]

Branch: refs/heads/RB-10.5
Home: https://github.com/ImageEngine/cortex
Commit: a3cbdc106560aed16bc706913113d2d192612cc3
https://github.com/ImageEngine/cortex/commit/a3cbdc106560aed16bc706913113d2d192612cc3
Author: John Haddon <thehad...@gmail.com>
Date: 2024-10-08 (Tue, 08 Oct 2024)

Changed paths:
M contrib/IECoreUSD/test/IECoreUSD/data/skinnedFaceVaryingNormals.usda

Log Message:
-----------
USD skinning data : Improve clarity

- Add stage timecode range, so we get a playback range in `usdview`.
- Rename `Skeleton` prim to "skel", because having it share a name with one of its joints was confusing.


Commit: 96ac74c39fb52c7ef0bf1aef80087ffc57c467b3
https://github.com/ImageEngine/cortex/commit/96ac74c39fb52c7ef0bf1aef80087ffc57c467b3
Author: John Haddon <thehad...@gmail.com>
Date: 2024-10-08 (Tue, 08 Oct 2024)

Changed paths:
M Changes
M contrib/IECoreUSD/src/IECoreUSD/PrimitiveAlgo.cpp
M contrib/IECoreUSD/test/IECoreUSD/data/skinnedFaceVaryingNormals.usda

Log Message:
-----------
USD PrimitiveAlgo : Fix crash loading skinned facevarying normals

The call to `skinningQuery.GetJointMapper()` can not only reorder transforms but can also omit them. This occurs when SkelBindingAPI uses a `skel:joints` attribute to bind a mesh to a subset of joints, allowing the weights for other joints to be omitted. We were assuming that the mapped transform array had the same length as the input array, and were running off the end of the array.


Commit: 3c826b23b75c1659722b9a80108edb2035439bb5
https://github.com/ImageEngine/cortex/commit/3c826b23b75c1659722b9a80108edb2035439bb5
Author: John Haddon <thehad...@gmail.com>
Date: 2024-10-09 (Wed, 09 Oct 2024)

Changed paths:
M Changes
M contrib/IECoreUSD/src/IECoreUSD/PrimitiveAlgo.cpp
M contrib/IECoreUSD/test/IECoreUSD/data/skinnedFaceVaryingNormals.usda

Log Message:
-----------
Merge pull request #1436 from johnhaddon/facevaryingSkinningFix

USD PrimitiveAlgo : Fix crash loading skinned facevarying normals


Compare: https://github.com/ImageEngine/cortex/compare/534d0c5c9cf5...3c826b23b75c

To unsubscribe from these emails, change your notification settings at https://github.com/ImageEngine/cortex/settings/notifications