[ImageEngine/cortex] 1cca93: USDScene : Fix round-tripping of colons in set names

0 views
Skip to first unread message

John Haddon

unread,
Aug 28, 2024, 3:36:53 AM8/28/24
to cortex...@googlegroups.com
Branch: refs/heads/RB-10.5
Home: https://github.com/ImageEngine/cortex
Commit: 1cca93125d0f5b0ee5c375c8c1c0c340c25e488f
https://github.com/ImageEngine/cortex/commit/1cca93125d0f5b0ee5c375c8c1c0c340c25e488f
Author: John Haddon <thehad...@gmail.com>
Date: 2024-08-27 (Tue, 27 Aug 2024)

Changed paths:
M Changes
M contrib/IECoreUSD/src/IECoreUSD/USDScene.cpp
M contrib/IECoreUSD/test/IECoreUSD/USDSceneTest.py

Log Message:
-----------
USDScene : Fix round-tripping of colons in set names

And make some notes on future changes we'll want to make to our name mangling. In theory we could implement round-tripping _now_ either by using metadata to store the "true name" or by implementing the first USD proposal ourselves. But I don't think round-tripping of arbitrary names is pressing enough to warrant the extra effort and ugliness if USD will provide it for us in the medium term.

Note : I removed the first call to `validName()` in `writeSetInternal()` because in that case we're going to make the name valid in the recursive call we're passing the name to.


Commit: 5957180d460ee2b6926f25885187d67408159ccd
https://github.com/ImageEngine/cortex/commit/5957180d460ee2b6926f25885187d67408159ccd
Author: John Haddon <thehad...@gmail.com>
Date: 2024-08-27 (Tue, 27 Aug 2024)

Changed paths:
M Changes
M contrib/IECoreUSD/src/IECoreUSD/USDScene.cpp
M contrib/IECoreUSD/test/IECoreUSD/USDSceneTest.py

Log Message:
-----------
USDScene : Fix hash of bounds from UsdGeomModelAPI


Commit: 0c12a739ed2e9fd8957629dde758ec28febede2b
https://github.com/ImageEngine/cortex/commit/0c12a739ed2e9fd8957629dde758ec28febede2b
Author: John Haddon <thehad...@gmail.com>
Date: 2024-08-28 (Wed, 28 Aug 2024)

Changed paths:
M Changes
M contrib/IECoreUSD/src/IECoreUSD/USDScene.cpp
M contrib/IECoreUSD/test/IECoreUSD/USDSceneTest.py

Log Message:
-----------
Merge pull request #1428 from johnhaddon/usdSetAndBoundFixes

USDScene fixes


Compare: https://github.com/ImageEngine/cortex/compare/0f34fb872a33...0c12a739ed2e

To unsubscribe from these emails, change your notification settings at https://github.com/ImageEngine/cortex/settings/notifications
Reply all
Reply to author
Forward
0 new messages