[ImageEngine/cortex] 77b6aa: IECoreBinding : Use `Py_ssize_t`
0 views
Skip to first unread message
John Haddon
Aug 30, 2024, 4:08:53 AM8/30/24
to cortex...@googlegroups.com
Branch: refs/heads/main
Home: https://github.com/ImageEngine/cortex
Commit: 77b6aa7358b846d151425b20654e1490ed30b538
https://github.com/ImageEngine/cortex/commit/77b6aa7358b846d151425b20654e1490ed30b538
Author: Eric Mehl <er...@thinkhypothetical.com>
Date: 2024-02-23 (Fri, 23 Feb 2024)
Changed paths:
M include/IECorePython/IECoreBinding.h
Log Message:
-----------
IECoreBinding : Use `Py_ssize_t`
MSVC has `SSIZE_T`, but not `ssize_t`, which is not part of the standard
it seems. Python's `pyport.h` file does a `typedef` for it, but
something must have changed between Python `3.7` and `3.10` that causes
that to not be included from what we're using. It does seem that the
official recommendation is to use `Py_ssize_t` now.
Commit: c38f40e703e9bf0424d6902c9dc8a9dc7cabfb9c
https://github.com/ImageEngine/cortex/commit/c38f40e703e9bf0424d6902c9dc8a9dc7cabfb9c
Author: Daniel Dresser <dan...@image-engine.com>
Date: 2024-04-18 (Thu, 18 Apr 2024)
Changed paths:
M SConstruct
M include/IECore/EuclideanToSphericalTransform.h
M include/IECore/SphericalToEuclideanTransform.h
M src/IECorePython/StringAlgoBinding.cpp
Log Message:
-----------
SConstruct : Enable -Wsuggest-override
Commit: d2da6b3341e980ed8f12e67dd8a11c999544a626
https://github.com/ImageEngine/cortex/commit/d2da6b3341e980ed8f12e67dd8a11c999544a626
Author: Daniel Dresser <dan...@image-engine.com>
Date: 2024-04-18 (Thu, 18 Apr 2024)
Changed paths:
M Changes
M src/IECoreScene/MeshPrimitive.cpp
M test/IECoreScene/MeshPrimitive.py
Log Message:
-----------
MeshPrimitive : Interpolation should not be included in the topologyHash
If two meshes differ only by interpolation, primvars can still be transferred directly, so it doesn't make
sense to say they have different topologies
Commit: 2206127f853277131542161015c81d8026cee3fe
https://github.com/ImageEngine/cortex/commit/2206127f853277131542161015c81d8026cee3fe
Author: Daniel Dresser <dan...@image-engine.com>
Date: 2024-04-18 (Thu, 18 Apr 2024)
Changed paths:
M Changes
M include/IECoreScene/MeshPrimitive.h
M src/IECoreScene/MeshPrimitive.cpp
M src/IECoreScene/bindings/MeshPrimitiveBinding.cpp
M test/IECoreScene/MeshPrimitive.py
Log Message:
-----------
MeshPrimitive : Add subdivision options
Commit: 825ee18b5599784aab6c39a74b954c1c14b2e330
https://github.com/ImageEngine/cortex/commit/825ee18b5599784aab6c39a74b954c1c14b2e330
Author: Daniel Dresser <dan...@image-engine.com>
Date: 2024-04-18 (Thu, 18 Apr 2024)
Changed paths:
M contrib/IECoreUSD/src/IECoreUSD/MeshAlgo.cpp
M contrib/IECoreUSD/test/IECoreUSD/USDSceneTest.py
Log Message:
-----------
IECOreUSD : support subdiv options
Commit: ff821fb6c1cbb33881b43db385feb013075827d9
https://github.com/ImageEngine/cortex/commit/ff821fb6c1cbb33881b43db385feb013075827d9
Author: John Haddon <thehad...@gmail.com>
Date: 2024-04-19 (Fri, 19 Apr 2024)
Changed paths:
M Changes
M SConstruct
M contrib/IECoreUSD/src/IECoreUSD/MeshAlgo.cpp
M contrib/IECoreUSD/test/IECoreUSD/USDSceneTest.py
M include/IECore/EuclideanToSphericalTransform.h
M include/IECore/SphericalToEuclideanTransform.h
M include/IECoreScene/MeshPrimitive.h
M src/IECorePython/StringAlgoBinding.cpp
M src/IECoreScene/MeshPrimitive.cpp
M src/IECoreScene/bindings/MeshPrimitiveBinding.cpp
M test/IECoreScene/MeshPrimitive.py
Log Message:
-----------
Merge pull request #1413 from danieldresser-ie/meshBoundary
MeshPrimitive : Add subdivision options
Commit: 50233fe02d6d64cef708563a6bde390073950a15
https://github.com/ImageEngine/cortex/commit/50233fe02d6d64cef708563a6bde390073950a15
Author: John Haddon <thehad...@gmail.com>
Date: 2024-04-19 (Fri, 19 Apr 2024)
Changed paths:
M Changes
M SConstruct
Log Message:
-----------
Bump version to 10.5.7.0
Commit: f8d3b66c33dae9372fc3514a0f33bed32e924837
https://github.com/ImageEngine/cortex/commit/f8d3b66c33dae9372fc3514a0f33bed32e924837
Author: John Haddon <thehad...@gmail.com>
Date: 2024-04-24 (Wed, 24 Apr 2024)
Changed paths:
M include/IECorePython/IECoreBinding.h
Log Message:
-----------
Merge pull request #1411 from ericmehl/Py_ssize_t
IECoreBinding : Use `Py_ssize_t`
Commit: 0590bbfdadaee2c26295e404abd951f98c79b570
https://github.com/ImageEngine/cortex/commit/0590bbfdadaee2c26295e404abd951f98c79b570
Author: John Haddon <thehad...@gmail.com>
Date: 2024-05-14 (Tue, 14 May 2024)
Changed paths:
M Changes
M contrib/IECoreUSD/src/IECoreUSD/ShaderAlgo.cpp
M contrib/IECoreUSD/test/IECoreUSD/USDSceneTest.py
Log Message:
-----------
USD ShaderAlgo : Fix `treatAs*` and `arnold:*` light parameters
The main motivation for this is to allow Arnold-specific parameters written out of Gaffer to render as expected via the `arnold-usd` render delegate. In Gaffer we represent these as standard light parameters named as `arnold:{name}`. But `arnold-usd` made the unfortunate decision not to represent them as standard light inputs in USD, but to store them as primitive variables instead. With a bit of luck, `arnold-usd` will align with the USD convention in future and we can ditch this code.
Commit: 901165c1180343288cd2790bfcd0874103f91cb8
https://github.com/ImageEngine/cortex/commit/901165c1180343288cd2790bfcd0874103f91cb8
Author: John Haddon <thehad...@gmail.com>
Date: 2024-05-15 (Wed, 15 May 2024)
Changed paths:
M Changes
M contrib/IECoreUSD/src/IECoreUSD/ShaderAlgo.cpp
M contrib/IECoreUSD/test/IECoreUSD/USDSceneTest.py
Log Message:
-----------
Merge pull request #1416 from johnhaddon/arnoldLightPrimvars
USD ShaderAlgo : Fix `treatAs*` and `arnold:*` light parameters
Commit: 976e18aad61afeb66ddeb78aa0fcf616104593d3
https://github.com/ImageEngine/cortex/commit/976e18aad61afeb66ddeb78aa0fcf616104593d3
Author: John Haddon <thehad...@gmail.com>
Date: 2024-05-15 (Wed, 15 May 2024)
Changed paths:
M Changes
M SConstruct
Log Message:
-----------
Bump version to 10.5.7.1
Commit: 850a2a6fb02af77edce65f9c86f337735ee55e59
https://github.com/ImageEngine/cortex/commit/850a2a6fb02af77edce65f9c86f337735ee55e59
Author: Daniel Dresser <dan...@image-engine.com>
Date: 2024-05-15 (Wed, 15 May 2024)
Changed paths:
M src/IECoreScene/ShaderNetworkAlgo.cpp
M test/IECoreScene/ShaderNetworkAlgoTest.py
Log Message:
-----------
ShaderNetworkAlgo::removedUnusedShaders : Optimize, fix crash
Commit: ab7556a5c61cc7962513b7f70f87698eb98cbff2
https://github.com/ImageEngine/cortex/commit/ab7556a5c61cc7962513b7f70f87698eb98cbff2
Author: John Haddon <thehad...@gmail.com>
Date: 2024-05-16 (Thu, 16 May 2024)
Changed paths:
M src/IECoreScene/ShaderNetworkAlgo.cpp
M test/IECoreScene/ShaderNetworkAlgoTest.py
Log Message:
-----------
Merge pull request #1417 from danieldresser-ie/removeUnusedCycleCrash
ShaderNetworkAlgo::removedUnusedShaders : Optimize, fix crash in case of cycle
Commit: d7d37691614e145afb27ca0eb89ffbd45b882eb9
https://github.com/ImageEngine/cortex/commit/d7d37691614e145afb27ca0eb89ffbd45b882eb9
Author: John Haddon <thehad...@gmail.com>
Date: 2024-05-16 (Thu, 16 May 2024)
Changed paths:
M Changes
Log Message:
-----------
Update Changes.md
Commit: f233bddb8975c2dae6720830ab59202b39837075
https://github.com/ImageEngine/cortex/commit/f233bddb8975c2dae6720830ab59202b39837075
Author: John Haddon <thehad...@gmail.com>
Date: 2024-05-23 (Thu, 23 May 2024)
Changed paths:
M Changes
M src/IECoreGL/ShaderStateComponent.cpp
Log Message:
-----------
ShaderStateComponent : Handle ToGLTextureConverter exceptions
These were thrown if a GLSL shader had bad values for a texture parameter - the case that motivated this was a custom setup in production that would pass a CompoundData with no channels and an empty data window.
We can't let the exception propagate because `addParametersToShaderSetup()` is called during drawing and the exception would prevent the rest of the scene drawing and/or lead to a corrupted GL state.
Commit: 4bd60005e9dafeed3ad820df1471ccbc2863e08e
https://github.com/ImageEngine/cortex/commit/4bd60005e9dafeed3ad820df1471ccbc2863e08e
Author: John Haddon <thehad...@gmail.com>
Date: 2024-05-28 (Tue, 28 May 2024)
Changed paths:
M Changes
M src/IECoreGL/ShaderStateComponent.cpp
Log Message:
-----------
Merge pull request #1418 from johnhaddon/glFix
ShaderStateComponent : Handle ToGLTextureConverter exceptions
Commit: 278fc09c219814da67b807f271d27b0b2772b144
https://github.com/ImageEngine/cortex/commit/278fc09c219814da67b807f271d27b0b2772b144
Author: John Haddon <thehad...@gmail.com>
Date: 2024-05-29 (Wed, 29 May 2024)
Changed paths:
M .github/workflows/main.yml
M .github/workflows/main/options.posix
M Changes
Log Message:
-----------
CI : Update to GafferHQ/dependencies 8.0.1
Commit: e0606a6626311bb0f7a5509d84a1ed1423939a23
https://github.com/ImageEngine/cortex/commit/e0606a6626311bb0f7a5509d84a1ed1423939a23
Author: John Haddon <thehad...@gmail.com>
Date: 2024-05-29 (Wed, 29 May 2024)
Changed paths:
M test/IECoreImage/data/exr/primitives.exr
Log Message:
-----------
ImageReaderTest : Replace deep test image
This one was ancient and upsets the new EXRCore library with the following error :
```
EXR_ERR_MISSING_REQ_ATTR 'chunkCount' attribute for multipart / deep file not found
```
Replaced with a copy of the image loaded and resaved from Gaffer, also downsizing it to 32x32 because nobody needs a 6Mb file just to check we can recognise a deep image.
Commit: 045266c8cec9a90ee4814bbc74ca5fc5e068664c
https://github.com/ImageEngine/cortex/commit/045266c8cec9a90ee4814bbc74ca5fc5e068664c
Author: John Haddon <thehad...@gmail.com>
Date: 2024-05-29 (Wed, 29 May 2024)
Changed paths:
M test/IECoreImage/ImageReaderTest.py
M test/IECoreImage/ImageThinnerTest.py
Log Message:
-----------
IECoreImageTest : Adapt for GafferHQ/dependencies 8.0.1
This changes error messages and precision subtly, for reasons I don't want to spend the time ascertaining right now.
Commit: 224df0c84f5ceb1e6453030db9dd80b436f7a1e8
https://github.com/ImageEngine/cortex/commit/224df0c84f5ceb1e6453030db9dd80b436f7a1e8
Author: John Haddon <thehad...@gmail.com>
Date: 2024-05-29 (Wed, 29 May 2024)
Changed paths:
M SConstruct
M python/IECore/__init__.py
Log Message:
-----------
IECore module : Add DLL directory for DLL dependencies
This fixes `scons testCorePython` and provides a mechanism for folks to fix
imports in their own environments.
At first I tried to just hardcode the directory to match the directory
layout used by Gaffer, using a path relative to `__file__`. But that didn't
work, because when we run `scons testCorePython`, we haven't installed the IECore
module yet (we test it in place in the local dir). The `IECORE_DLL_DIRECTORIES`
environment variable was the only other option I could see, and I suppose it
at least gives folks a hand if they have their own installation layouts.
Commit: 7f8d4a5727ce5972535e6d090a751d579780f515
https://github.com/ImageEngine/cortex/commit/7f8d4a5727ce5972535e6d090a751d579780f515
Author: John Haddon <jo...@gafferhq.org>
Date: 2024-05-29 (Wed, 29 May 2024)
Changed paths:
M .github/workflows/main.yml
Log Message:
-----------
CI : Don't install before running tests
For two reasons :
- This is how things are intended to be used : you should be able to build and run tests before committing to installing.
- If we install before testing, then USD is picking up two copies of the SceneCacheFileFormat somehow, causing a test failure.
Commit: 9668070a5392dcf34ff10817cf3020a4bd9c3dc3
https://github.com/ImageEngine/cortex/commit/9668070a5392dcf34ff10817cf3020a4bd9c3dc3
Author: Murray Stevenson <50844517+mur...@users.noreply.github.com>
Date: 2024-05-29 (Wed, 29 May 2024)
Changed paths:
M .github/workflows/main.yml
M .github/workflows/main/options.posix
M Changes
M SConstruct
M python/IECore/__init__.py
M test/IECoreImage/ImageReaderTest.py
M test/IECoreImage/ImageThinnerTest.py
M test/IECoreImage/data/exr/primitives.exr
Log Message:
-----------
Merge pull request #1419 from johnhaddon/packageUpdate
CI : Update to GafferHQ/dependencies 8.0.1
Commit: 2e68dc33df637488c68ff4a0cc5e03123f401976
https://github.com/ImageEngine/cortex/commit/2e68dc33df637488c68ff4a0cc5e03123f401976
Author: John Haddon <thehad...@gmail.com>
Date: 2024-06-04 (Tue, 04 Jun 2024)
Changed paths:
M contrib/IECoreUSD/test/IECoreUSD/DataAlgoTest.py
Log Message:
-----------
USD DataAlgoTest : Fix indentation
Commit: b2526dbf69600a9cc8a4483c0d8cd904be84f2b1
https://github.com/ImageEngine/cortex/commit/b2526dbf69600a9cc8a4483c0d8cd904be84f2b1
Author: John Haddon <thehad...@gmail.com>
Date: 2024-06-04 (Tue, 04 Jun 2024)
Changed paths:
M Changes
M contrib/IECoreUSD/src/IECoreUSD/bindings/IEUSDModule.cpp
M contrib/IECoreUSD/test/IECoreUSD/DataAlgoTest.py
Log Message:
-----------
USD module : Bind `DataAlgo::toUSD()`
Commit: 8b3385f0d628e27f6793709969081ec5ab210e51
https://github.com/ImageEngine/cortex/commit/8b3385f0d628e27f6793709969081ec5ab210e51
Author: John Haddon <thehad...@gmail.com>
Date: 2024-06-04 (Tue, 04 Jun 2024)
Changed paths:
M Changes
M contrib/IECoreUSD/src/IECoreUSD/DataAlgo.cpp
M contrib/IECoreUSD/test/IECoreUSD/DataAlgoTest.py
Log Message:
-----------
USD DataAlgo : Fix handling of types not known to `dispatch()`
We now return a sentinel instead of throwing an exception. This is consistent with our existing handling of types known to `dispatch()` but without a corresponding USD type.
Commit: 45db9e4fed0881d45968dea68df20d4b940a44e0
https://github.com/ImageEngine/cortex/commit/45db9e4fed0881d45968dea68df20d4b940a44e0
Author: John Haddon <thehad...@gmail.com>
Date: 2024-06-04 (Tue, 04 Jun 2024)
Changed paths:
M Changes
M contrib/IECoreUSD/src/IECoreUSD/ShaderAlgo.cpp
M contrib/IECoreUSD/test/IECoreUSD/USDSceneTest.py
Log Message:
-----------
USD ShaderAlgo : Emit warning for unsupported parameter types
In conjunction with the previous commit, this means that we now gracefully print a warning message for any parameter types we can't write to USD. Prior to this we were throwing a not very helpful exception and not writing anything at all. This came up in production with a GLSL shader with an ImagePlug input in Gaffer, where we pack an entire image into a CompoundData value.
Commit: 1d2bfd61801bd8f63b42d99f7a2ba890e176c6ac
https://github.com/ImageEngine/cortex/commit/1d2bfd61801bd8f63b42d99f7a2ba890e176c6ac
Author: John Haddon <thehad...@gmail.com>
Date: 2024-06-04 (Tue, 04 Jun 2024)
Changed paths:
M Changes
M contrib/IECoreUSD/src/IECoreUSD/AttributeAlgo.cpp
M contrib/IECoreUSD/test/IECoreUSD/USDSceneTest.py
Log Message:
-----------
USD AttributeAlgo : Don't treat `arnold:*` light primvars as attributes
Since 0590bbfdadaee2c26295e404abd951f98c79b570, they have been converted to light parameters instead.
Commit: a5e12c90b5731c5a30fa6ec14d1f878bf5190572
https://github.com/ImageEngine/cortex/commit/a5e12c90b5731c5a30fa6ec14d1f878bf5190572
Author: John Haddon <thehad...@gmail.com>
Date: 2024-06-05 (Wed, 05 Jun 2024)
Changed paths:
M Changes
M contrib/IECoreUSD/src/IECoreUSD/AttributeAlgo.cpp
M contrib/IECoreUSD/src/IECoreUSD/DataAlgo.cpp
M contrib/IECoreUSD/src/IECoreUSD/ShaderAlgo.cpp
M contrib/IECoreUSD/src/IECoreUSD/bindings/IEUSDModule.cpp
M contrib/IECoreUSD/test/IECoreUSD/DataAlgoTest.py
M contrib/IECoreUSD/test/IECoreUSD/USDSceneTest.py
Log Message:
-----------
Merge pull request #1420 from johnhaddon/usdFixes
USD fixes
Commit: fdfd188a9bf3042547d10ff48ea1762d4c46ba4f
https://github.com/ImageEngine/cortex/commit/fdfd188a9bf3042547d10ff48ea1762d4c46ba4f
Author: John Haddon <thehad...@gmail.com>
Date: 2024-06-05 (Wed, 05 Jun 2024)
Changed paths:
M Changes
M SConstruct
Log Message:
-----------
Bump version to 10.5.8.0
Commit: 8a3a9ea68db55117e4c18ca11ea25f68a58a2d0e
https://github.com/ImageEngine/cortex/commit/8a3a9ea68db55117e4c18ca11ea25f68a58a2d0e
Author: John Haddon <thehad...@gmail.com>
Date: 2024-06-21 (Fri, 21 Jun 2024)
Changed paths:
M Changes
M contrib/IECoreUSD/src/IECoreUSD/USDScene.cpp
M contrib/IECoreUSD/test/IECoreUSD/USDSceneTest.py
Log Message:
-----------
USDScene : Load bounds from UsdGeomModelAPI extents hints
This can provide significant performance improvements where the ModelAPI has been used to provide cached extents. This knocks around 30% off the time taken to open the file and compute the root bound of the ALab in Gaffer. If USD composition time is omitted so only the bound computation is measured in isolation, a full 95% is knocked off the time. In the case of the ALab, the new root bound is also far more reasonable for some reason - I suspect the model extents are masking a bad authored extent on a leaf object elsewhere in the scene.
This has the potential to be surprising for any folks who have authored inaccurate model extents in the past, so I've made it possible to turn off the behaviour using an environment variable. I'd like to default things on in Cortex itself, but we can debate the appropriate default for Gaffer when we next update the Cortex version.
Commit: 94bddf2760385cbbefc91672665d5ec4355250fa
https://github.com/ImageEngine/cortex/commit/94bddf2760385cbbefc91672665d5ec4355250fa
Author: Murray Stevenson <50844517+mur...@users.noreply.github.com>
Date: 2024-06-21 (Fri, 21 Jun 2024)
Changed paths:
M Changes
M contrib/IECoreUSD/src/IECoreUSD/USDScene.cpp
M contrib/IECoreUSD/test/IECoreUSD/USDSceneTest.py
Log Message:
-----------
Merge pull request #1421 from johnhaddon/modelAPIBounds
USDScene : Load bounds from UsdGeomModelAPI extents hints
Commit: 4da134098a2a5004b3ff006c4deeae84aeaba654
https://github.com/ImageEngine/cortex/commit/4da134098a2a5004b3ff006c4deeae84aeaba654
Author: John Haddon <thehad...@gmail.com>
Date: 2024-06-24 (Mon, 24 Jun 2024)
Changed paths:
M Changes
M SConstruct
Log Message:
-----------
Bump version to 10.5.9.0
Commit: 26ee835c2b2fe66903ae173e4418bfb396cf733e
https://github.com/ImageEngine/cortex/commit/26ee835c2b2fe66903ae173e4418bfb396cf733e
Author: Murray Stevenson <50844517+mur...@users.noreply.github.com>
Date: 2024-07-05 (Fri, 05 Jul 2024)
Changed paths:
M .github/workflows/main.yml
Log Message:
-----------
CI : Continue using Node16 for actions
Actions are now run on Node20 by default, but this requires glibc >=2.28 so actions no longer run in our CentOS 7 build container.
Setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true allows us to continue using Node16 for the near future, but support for this may be removed in October...
https://github.blog/changelog/2024-05-17-updated-dates-for-actions-runner-using-node20-instead-of-node16-by-default/
Commit: e320d1bfeac75248d801f15e1a3a4eb9ac0efde3
https://github.com/ImageEngine/cortex/commit/e320d1bfeac75248d801f15e1a3a4eb9ac0efde3
Author: Murray Stevenson <50844517+mur...@users.noreply.github.com>
Date: 2024-07-05 (Fri, 05 Jul 2024)
Changed paths:
M .github/workflows/main.yml
Log Message:
-----------
CI : Update Node12 actions
This matches the action versions used on Gaffer CI and silences the "The following actions uses node12 which is deprecated and will be forced to run on node16" warnings.
There are even newer versions of these actions, such as checkout and upload-artifact v4, but they require Node20 which we're unable to use on our CentOS 7 build container.
Commit: c296aa18f26f9a02573d533f4bf25fd03a4c4666
https://github.com/ImageEngine/cortex/commit/c296aa18f26f9a02573d533f4bf25fd03a4c4666
Author: John Haddon <thehad...@gmail.com>
Date: 2024-07-08 (Mon, 08 Jul 2024)
Changed paths:
M .github/workflows/main.yml
Log Message:
-----------
Merge pull request #1424 from murraystevenson/ciNode16Workaround
CI : Continue using Node16 for actions
Commit: fa90c5d3f50690006624a2873387aefed750dba3
https://github.com/ImageEngine/cortex/commit/fa90c5d3f50690006624a2873387aefed750dba3
Author: John Haddon <thehad...@gmail.com>
Date: 2024-07-09 (Tue, 09 Jul 2024)
Changed paths:
M Changes
M src/IECoreImage/OpenImageIOAlgo.cpp
Log Message:
-----------
OpenImageIOAlgo : Add missing array handlers to `data()`
And consolidate the existing array handling to use the same templated function as everything else. This new version is preferable because it doesn't initialise the data twice (previously the `resize()` was doing a redundant initialisation prior to the `copy()`).
This fixes the loading of ICCProfile metadata, which is the underlying problem reported in https://groups.google.com/g/gaffer-dev/c/qUSJ-r0XuYI/m/y4OMtrBUAAAJ.
Commit: 7de325a18fba986ed2f147e9b7af0000d2df9de6
https://github.com/ImageEngine/cortex/commit/7de325a18fba986ed2f147e9b7af0000d2df9de6
Author: John Haddon <thehad...@gmail.com>
Date: 2024-07-10 (Wed, 10 Jul 2024)
Changed paths:
M Changes
M src/IECoreImage/OpenImageIOAlgo.cpp
Log Message:
-----------
Merge pull request #1425 from johnhaddon/oiioDataFix
OpenImageIOAlgo : Add missing array handlers to `data()`
Commit: 0f34fb872a334f83cfba88b6db0e57067056977b
https://github.com/ImageEngine/cortex/commit/0f34fb872a334f83cfba88b6db0e57067056977b
Author: John Haddon <thehad...@gmail.com>
Date: 2024-07-11 (Thu, 11 Jul 2024)
Changed paths:
M Changes
M SConstruct
Log Message:
-----------
Bump version to 10.5.9.1
Commit: 1cca93125d0f5b0ee5c375c8c1c0c340c25e488f
https://github.com/ImageEngine/cortex/commit/1cca93125d0f5b0ee5c375c8c1c0c340c25e488f
Author: John Haddon <thehad...@gmail.com>
Date: 2024-08-27 (Tue, 27 Aug 2024)
Changed paths:
M Changes
M contrib/IECoreUSD/src/IECoreUSD/USDScene.cpp
M contrib/IECoreUSD/test/IECoreUSD/USDSceneTest.py
Log Message:
-----------
USDScene : Fix round-tripping of colons in set names
And make some notes on future changes we'll want to make to our name mangling. In theory we could implement round-tripping _now_ either by using metadata to store the "true name" or by implementing the first USD proposal ourselves. But I don't think round-tripping of arbitrary names is pressing enough to warrant the extra effort and ugliness if USD will provide it for us in the medium term.
Note : I removed the first call to `validName()` in `writeSetInternal()` because in that case we're going to make the name valid in the recursive call we're passing the name to.
Commit: 5957180d460ee2b6926f25885187d67408159ccd
https://github.com/ImageEngine/cortex/commit/5957180d460ee2b6926f25885187d67408159ccd
Author: John Haddon <thehad...@gmail.com>
Date: 2024-08-27 (Tue, 27 Aug 2024)
Changed paths:
M Changes
M contrib/IECoreUSD/src/IECoreUSD/USDScene.cpp
M contrib/IECoreUSD/test/IECoreUSD/USDSceneTest.py
Log Message:
-----------
USDScene : Fix hash of bounds from UsdGeomModelAPI
Commit: 0c12a739ed2e9fd8957629dde758ec28febede2b
https://github.com/ImageEngine/cortex/commit/0c12a739ed2e9fd8957629dde758ec28febede2b
Author: John Haddon <thehad...@gmail.com>
Date: 2024-08-28 (Wed, 28 Aug 2024)
Changed paths:
M Changes
M contrib/IECoreUSD/src/IECoreUSD/USDScene.cpp
M contrib/IECoreUSD/test/IECoreUSD/USDSceneTest.py
Log Message:
-----------
Merge pull request #1428 from johnhaddon/usdSetAndBoundFixes
USDScene fixes
Commit: 2c37ad1498019ee2eca9eb25919967c0eef494af
https://github.com/ImageEngine/cortex/commit/2c37ad1498019ee2eca9eb25919967c0eef494af
Author: Daniel Dresser <dan...@image-engine.com>
Date: 2024-08-29 (Thu, 29 Aug 2024)
Changed paths:
M src/IECoreScene/CurvesAlgo.cpp
M test/IECoreScene/CurvesAlgoTest.py
Log Message:
-----------
CurvesAlgo::resamplePrimitiveVariables : Support periodic curves
Commit: 897a4dd51675f5c793f1545d9fa43e57ad415919
https://github.com/ImageEngine/cortex/commit/897a4dd51675f5c793f1545d9fa43e57ad415919
Author: christopherle <christ...@image-engine.com>
Date: 2024-08-29 (Thu, 29 Aug 2024)
Changed paths:
M .gitignore
Log Message:
-----------
gitignore : Ignore all sconsdblite files
Commit: e1ee2c877882b22231ccd1ecb81f35b817be661e
https://github.com/ImageEngine/cortex/commit/e1ee2c877882b22231ccd1ecb81f35b817be661e
Author: christopherle <christ...@image-engine.com>
Date: 2024-08-29 (Thu, 29 Aug 2024)
Changed paths:
M Changes
M src/IECoreMaya/ToMayaMeshConverter.cpp
M test/IECoreMaya/ParameterisedHolder.py
M test/IECoreMaya/ToMayaMeshConverterTest.py
Log Message:
-----------
ToMayaMeshConverter : Reverts "ToMayaMeshConverter : No longer set normals"
Reverts changes to no longer set normals when reading from a Cortex
object to Maya mesh since by not reading the normals, we don't take
into account the difference between face and vertex normals meaning
Maya may not recompute the normals as expected. Also, SCCs
published from outside Maya are also likely to be read into Maya with
different than expected normals.
Commit: 341b3de9a05d53ce66e1b8ce215bf5439d20e01b
https://github.com/ImageEngine/cortex/commit/341b3de9a05d53ce66e1b8ce215bf5439d20e01b
Author: Ivan Imanishi <iv...@image-engine.com>
Date: 2024-08-29 (Thu, 29 Aug 2024)
Changed paths:
M .gitignore
M Changes
M src/IECoreMaya/ToMayaMeshConverter.cpp
M test/IECoreMaya/ParameterisedHolder.py
M test/IECoreMaya/ToMayaMeshConverterTest.py
Log Message:
-----------
Merge pull request #1430 from chrisc-lee/revertNotSetNormalsForMesh
ToMayaMeshConverter: Revert "ToMayaMeshConverter : No longer set normals"
Commit: ac86d9bfee4336043053a0f9c8cc159733c01b86
https://github.com/ImageEngine/cortex/commit/ac86d9bfee4336043053a0f9c8cc159733c01b86
Author: John Haddon <thehad...@gmail.com>
Date: 2024-08-30 (Fri, 30 Aug 2024)
Changed paths:
M src/IECoreScene/CurvesAlgo.cpp
M test/IECoreScene/CurvesAlgoTest.py
Log Message:
-----------
Merge pull request #1429 from danieldresser-ie/resampleCurves
CurvesAlgo::resamplePrimitiveVariables : Support periodic curves
Commit: 1be00fbed98f617e189e16758601ec35e5ac3b6a
https://github.com/ImageEngine/cortex/commit/1be00fbed98f617e189e16758601ec35e5ac3b6a
Author: John Haddon <thehad...@gmail.com>
Date: 2024-08-30 (Fri, 30 Aug 2024)
Changed paths:
M Changes
M SConstruct
Log Message:
-----------
Bump version to 10.5.9.2
And add missing entry in Changes.
Commit: e8bc39aa5e3dcbff8bda4cfaa4b1977d9bad0006
https://github.com/ImageEngine/cortex/commit/e8bc39aa5e3dcbff8bda4cfaa4b1977d9bad0006
Author: John Haddon <thehad...@gmail.com>
Date: 2024-08-30 (Fri, 30 Aug 2024)
Changed paths:
M .github/workflows/main.yml
M .github/workflows/main/options.posix
M .gitignore
M Changes
M SConstruct
M contrib/IECoreUSD/src/IECoreUSD/AttributeAlgo.cpp
M contrib/IECoreUSD/src/IECoreUSD/DataAlgo.cpp
M contrib/IECoreUSD/src/IECoreUSD/MeshAlgo.cpp
M contrib/IECoreUSD/src/IECoreUSD/ShaderAlgo.cpp
M contrib/IECoreUSD/src/IECoreUSD/USDScene.cpp
M contrib/IECoreUSD/src/IECoreUSD/bindings/IEUSDModule.cpp
M contrib/IECoreUSD/test/IECoreUSD/DataAlgoTest.py
M contrib/IECoreUSD/test/IECoreUSD/USDSceneTest.py
M include/IECore/EuclideanToSphericalTransform.h
M include/IECore/SphericalToEuclideanTransform.h
M include/IECorePython/IECoreBinding.h
M include/IECoreScene/MeshPrimitive.h
M python/IECore/__init__.py
M src/IECoreGL/ShaderStateComponent.cpp
M src/IECoreImage/OpenImageIOAlgo.cpp
M src/IECoreMaya/ToMayaMeshConverter.cpp
M src/IECorePython/StringAlgoBinding.cpp
M src/IECoreScene/CurvesAlgo.cpp
M src/IECoreScene/MeshPrimitive.cpp
M src/IECoreScene/ShaderNetworkAlgo.cpp
M src/IECoreScene/bindings/MeshPrimitiveBinding.cpp
M test/IECoreImage/ImageReaderTest.py
M test/IECoreImage/ImageThinnerTest.py
M test/IECoreImage/data/exr/primitives.exr
M test/IECoreMaya/ParameterisedHolder.py
M test/IECoreMaya/ToMayaMeshConverterTest.py
M test/IECoreScene/CurvesAlgoTest.py
M test/IECoreScene/MeshPrimitive.py
M test/IECoreScene/ShaderNetworkAlgoTest.py
Log Message:
-----------
Merge branch 'RB-10.5'
Compare: https://github.com/ImageEngine/cortex/compare/634afb6f3fe8...e8bc39aa5e3d
To unsubscribe from these emails, change your notification settings at https://github.com/ImageEngine/cortex/settings/notifications
Home: https://github.com/ImageEngine/cortex
Commit: 77b6aa7358b846d151425b20654e1490ed30b538
https://github.com/ImageEngine/cortex/commit/77b6aa7358b846d151425b20654e1490ed30b538
Author: Eric Mehl <er...@thinkhypothetical.com>
Date: 2024-02-23 (Fri, 23 Feb 2024)
Changed paths:
M include/IECorePython/IECoreBinding.h
Log Message:
-----------
IECoreBinding : Use `Py_ssize_t`
MSVC has `SSIZE_T`, but not `ssize_t`, which is not part of the standard
it seems. Python's `pyport.h` file does a `typedef` for it, but
something must have changed between Python `3.7` and `3.10` that causes
that to not be included from what we're using. It does seem that the
official recommendation is to use `Py_ssize_t` now.
Commit: c38f40e703e9bf0424d6902c9dc8a9dc7cabfb9c
https://github.com/ImageEngine/cortex/commit/c38f40e703e9bf0424d6902c9dc8a9dc7cabfb9c
Author: Daniel Dresser <dan...@image-engine.com>
Date: 2024-04-18 (Thu, 18 Apr 2024)
Changed paths:
M SConstruct
M include/IECore/EuclideanToSphericalTransform.h
M include/IECore/SphericalToEuclideanTransform.h
M src/IECorePython/StringAlgoBinding.cpp
Log Message:
-----------
SConstruct : Enable -Wsuggest-override
Commit: d2da6b3341e980ed8f12e67dd8a11c999544a626
https://github.com/ImageEngine/cortex/commit/d2da6b3341e980ed8f12e67dd8a11c999544a626
Author: Daniel Dresser <dan...@image-engine.com>
Date: 2024-04-18 (Thu, 18 Apr 2024)
Changed paths:
M Changes
M src/IECoreScene/MeshPrimitive.cpp
M test/IECoreScene/MeshPrimitive.py
Log Message:
-----------
MeshPrimitive : Interpolation should not be included in the topologyHash
If two meshes differ only by interpolation, primvars can still be transferred directly, so it doesn't make
sense to say they have different topologies
Commit: 2206127f853277131542161015c81d8026cee3fe
https://github.com/ImageEngine/cortex/commit/2206127f853277131542161015c81d8026cee3fe
Author: Daniel Dresser <dan...@image-engine.com>
Date: 2024-04-18 (Thu, 18 Apr 2024)
Changed paths:
M Changes
M include/IECoreScene/MeshPrimitive.h
M src/IECoreScene/MeshPrimitive.cpp
M src/IECoreScene/bindings/MeshPrimitiveBinding.cpp
M test/IECoreScene/MeshPrimitive.py
Log Message:
-----------
MeshPrimitive : Add subdivision options
Commit: 825ee18b5599784aab6c39a74b954c1c14b2e330
https://github.com/ImageEngine/cortex/commit/825ee18b5599784aab6c39a74b954c1c14b2e330
Author: Daniel Dresser <dan...@image-engine.com>
Date: 2024-04-18 (Thu, 18 Apr 2024)
Changed paths:
M contrib/IECoreUSD/src/IECoreUSD/MeshAlgo.cpp
M contrib/IECoreUSD/test/IECoreUSD/USDSceneTest.py
Log Message:
-----------
IECOreUSD : support subdiv options
Commit: ff821fb6c1cbb33881b43db385feb013075827d9
https://github.com/ImageEngine/cortex/commit/ff821fb6c1cbb33881b43db385feb013075827d9
Author: John Haddon <thehad...@gmail.com>
Date: 2024-04-19 (Fri, 19 Apr 2024)
Changed paths:
M Changes
M SConstruct
M contrib/IECoreUSD/src/IECoreUSD/MeshAlgo.cpp
M contrib/IECoreUSD/test/IECoreUSD/USDSceneTest.py
M include/IECore/EuclideanToSphericalTransform.h
M include/IECore/SphericalToEuclideanTransform.h
M include/IECoreScene/MeshPrimitive.h
M src/IECorePython/StringAlgoBinding.cpp
M src/IECoreScene/MeshPrimitive.cpp
M src/IECoreScene/bindings/MeshPrimitiveBinding.cpp
M test/IECoreScene/MeshPrimitive.py
Log Message:
-----------
Merge pull request #1413 from danieldresser-ie/meshBoundary
MeshPrimitive : Add subdivision options
Commit: 50233fe02d6d64cef708563a6bde390073950a15
https://github.com/ImageEngine/cortex/commit/50233fe02d6d64cef708563a6bde390073950a15
Author: John Haddon <thehad...@gmail.com>
Date: 2024-04-19 (Fri, 19 Apr 2024)
Changed paths:
M Changes
M SConstruct
Log Message:
-----------
Bump version to 10.5.7.0
Commit: f8d3b66c33dae9372fc3514a0f33bed32e924837
https://github.com/ImageEngine/cortex/commit/f8d3b66c33dae9372fc3514a0f33bed32e924837
Author: John Haddon <thehad...@gmail.com>
Date: 2024-04-24 (Wed, 24 Apr 2024)
Changed paths:
M include/IECorePython/IECoreBinding.h
Log Message:
-----------
Merge pull request #1411 from ericmehl/Py_ssize_t
IECoreBinding : Use `Py_ssize_t`
Commit: 0590bbfdadaee2c26295e404abd951f98c79b570
https://github.com/ImageEngine/cortex/commit/0590bbfdadaee2c26295e404abd951f98c79b570
Author: John Haddon <thehad...@gmail.com>
Date: 2024-05-14 (Tue, 14 May 2024)
Changed paths:
M Changes
M contrib/IECoreUSD/src/IECoreUSD/ShaderAlgo.cpp
M contrib/IECoreUSD/test/IECoreUSD/USDSceneTest.py
Log Message:
-----------
USD ShaderAlgo : Fix `treatAs*` and `arnold:*` light parameters
The main motivation for this is to allow Arnold-specific parameters written out of Gaffer to render as expected via the `arnold-usd` render delegate. In Gaffer we represent these as standard light parameters named as `arnold:{name}`. But `arnold-usd` made the unfortunate decision not to represent them as standard light inputs in USD, but to store them as primitive variables instead. With a bit of luck, `arnold-usd` will align with the USD convention in future and we can ditch this code.
Commit: 901165c1180343288cd2790bfcd0874103f91cb8
https://github.com/ImageEngine/cortex/commit/901165c1180343288cd2790bfcd0874103f91cb8
Author: John Haddon <thehad...@gmail.com>
Date: 2024-05-15 (Wed, 15 May 2024)
Changed paths:
M Changes
M contrib/IECoreUSD/src/IECoreUSD/ShaderAlgo.cpp
M contrib/IECoreUSD/test/IECoreUSD/USDSceneTest.py
Log Message:
-----------
Merge pull request #1416 from johnhaddon/arnoldLightPrimvars
USD ShaderAlgo : Fix `treatAs*` and `arnold:*` light parameters
Commit: 976e18aad61afeb66ddeb78aa0fcf616104593d3
https://github.com/ImageEngine/cortex/commit/976e18aad61afeb66ddeb78aa0fcf616104593d3
Author: John Haddon <thehad...@gmail.com>
Date: 2024-05-15 (Wed, 15 May 2024)
Changed paths:
M Changes
M SConstruct
Log Message:
-----------
Bump version to 10.5.7.1
Commit: 850a2a6fb02af77edce65f9c86f337735ee55e59
https://github.com/ImageEngine/cortex/commit/850a2a6fb02af77edce65f9c86f337735ee55e59
Author: Daniel Dresser <dan...@image-engine.com>
Date: 2024-05-15 (Wed, 15 May 2024)
Changed paths:
M src/IECoreScene/ShaderNetworkAlgo.cpp
M test/IECoreScene/ShaderNetworkAlgoTest.py
Log Message:
-----------
ShaderNetworkAlgo::removedUnusedShaders : Optimize, fix crash
Commit: ab7556a5c61cc7962513b7f70f87698eb98cbff2
https://github.com/ImageEngine/cortex/commit/ab7556a5c61cc7962513b7f70f87698eb98cbff2
Author: John Haddon <thehad...@gmail.com>
Date: 2024-05-16 (Thu, 16 May 2024)
Changed paths:
M src/IECoreScene/ShaderNetworkAlgo.cpp
M test/IECoreScene/ShaderNetworkAlgoTest.py
Log Message:
-----------
Merge pull request #1417 from danieldresser-ie/removeUnusedCycleCrash
ShaderNetworkAlgo::removedUnusedShaders : Optimize, fix crash in case of cycle
Commit: d7d37691614e145afb27ca0eb89ffbd45b882eb9
https://github.com/ImageEngine/cortex/commit/d7d37691614e145afb27ca0eb89ffbd45b882eb9
Author: John Haddon <thehad...@gmail.com>
Date: 2024-05-16 (Thu, 16 May 2024)
Changed paths:
M Changes
Log Message:
-----------
Update Changes.md
Commit: f233bddb8975c2dae6720830ab59202b39837075
https://github.com/ImageEngine/cortex/commit/f233bddb8975c2dae6720830ab59202b39837075
Author: John Haddon <thehad...@gmail.com>
Date: 2024-05-23 (Thu, 23 May 2024)
Changed paths:
M Changes
M src/IECoreGL/ShaderStateComponent.cpp
Log Message:
-----------
ShaderStateComponent : Handle ToGLTextureConverter exceptions
These were thrown if a GLSL shader had bad values for a texture parameter - the case that motivated this was a custom setup in production that would pass a CompoundData with no channels and an empty data window.
We can't let the exception propagate because `addParametersToShaderSetup()` is called during drawing and the exception would prevent the rest of the scene drawing and/or lead to a corrupted GL state.
Commit: 4bd60005e9dafeed3ad820df1471ccbc2863e08e
https://github.com/ImageEngine/cortex/commit/4bd60005e9dafeed3ad820df1471ccbc2863e08e
Author: John Haddon <thehad...@gmail.com>
Date: 2024-05-28 (Tue, 28 May 2024)
Changed paths:
M Changes
M src/IECoreGL/ShaderStateComponent.cpp
Log Message:
-----------
Merge pull request #1418 from johnhaddon/glFix
ShaderStateComponent : Handle ToGLTextureConverter exceptions
Commit: 278fc09c219814da67b807f271d27b0b2772b144
https://github.com/ImageEngine/cortex/commit/278fc09c219814da67b807f271d27b0b2772b144
Author: John Haddon <thehad...@gmail.com>
Date: 2024-05-29 (Wed, 29 May 2024)
Changed paths:
M .github/workflows/main.yml
M .github/workflows/main/options.posix
M Changes
Log Message:
-----------
CI : Update to GafferHQ/dependencies 8.0.1
Commit: e0606a6626311bb0f7a5509d84a1ed1423939a23
https://github.com/ImageEngine/cortex/commit/e0606a6626311bb0f7a5509d84a1ed1423939a23
Author: John Haddon <thehad...@gmail.com>
Date: 2024-05-29 (Wed, 29 May 2024)
Changed paths:
M test/IECoreImage/data/exr/primitives.exr
Log Message:
-----------
ImageReaderTest : Replace deep test image
This one was ancient and upsets the new EXRCore library with the following error :
```
EXR_ERR_MISSING_REQ_ATTR 'chunkCount' attribute for multipart / deep file not found
```
Replaced with a copy of the image loaded and resaved from Gaffer, also downsizing it to 32x32 because nobody needs a 6Mb file just to check we can recognise a deep image.
Commit: 045266c8cec9a90ee4814bbc74ca5fc5e068664c
https://github.com/ImageEngine/cortex/commit/045266c8cec9a90ee4814bbc74ca5fc5e068664c
Author: John Haddon <thehad...@gmail.com>
Date: 2024-05-29 (Wed, 29 May 2024)
Changed paths:
M test/IECoreImage/ImageReaderTest.py
M test/IECoreImage/ImageThinnerTest.py
Log Message:
-----------
IECoreImageTest : Adapt for GafferHQ/dependencies 8.0.1
This changes error messages and precision subtly, for reasons I don't want to spend the time ascertaining right now.
Commit: 224df0c84f5ceb1e6453030db9dd80b436f7a1e8
https://github.com/ImageEngine/cortex/commit/224df0c84f5ceb1e6453030db9dd80b436f7a1e8
Author: John Haddon <thehad...@gmail.com>
Date: 2024-05-29 (Wed, 29 May 2024)
Changed paths:
M SConstruct
M python/IECore/__init__.py
Log Message:
-----------
IECore module : Add DLL directory for DLL dependencies
This fixes `scons testCorePython` and provides a mechanism for folks to fix
imports in their own environments.
At first I tried to just hardcode the directory to match the directory
layout used by Gaffer, using a path relative to `__file__`. But that didn't
work, because when we run `scons testCorePython`, we haven't installed the IECore
module yet (we test it in place in the local dir). The `IECORE_DLL_DIRECTORIES`
environment variable was the only other option I could see, and I suppose it
at least gives folks a hand if they have their own installation layouts.
Commit: 7f8d4a5727ce5972535e6d090a751d579780f515
https://github.com/ImageEngine/cortex/commit/7f8d4a5727ce5972535e6d090a751d579780f515
Author: John Haddon <jo...@gafferhq.org>
Date: 2024-05-29 (Wed, 29 May 2024)
Changed paths:
M .github/workflows/main.yml
Log Message:
-----------
CI : Don't install before running tests
For two reasons :
- This is how things are intended to be used : you should be able to build and run tests before committing to installing.
- If we install before testing, then USD is picking up two copies of the SceneCacheFileFormat somehow, causing a test failure.
Commit: 9668070a5392dcf34ff10817cf3020a4bd9c3dc3
https://github.com/ImageEngine/cortex/commit/9668070a5392dcf34ff10817cf3020a4bd9c3dc3
Author: Murray Stevenson <50844517+mur...@users.noreply.github.com>
Date: 2024-05-29 (Wed, 29 May 2024)
Changed paths:
M .github/workflows/main.yml
M .github/workflows/main/options.posix
M Changes
M SConstruct
M python/IECore/__init__.py
M test/IECoreImage/ImageReaderTest.py
M test/IECoreImage/ImageThinnerTest.py
M test/IECoreImage/data/exr/primitives.exr
Log Message:
-----------
Merge pull request #1419 from johnhaddon/packageUpdate
CI : Update to GafferHQ/dependencies 8.0.1
Commit: 2e68dc33df637488c68ff4a0cc5e03123f401976
https://github.com/ImageEngine/cortex/commit/2e68dc33df637488c68ff4a0cc5e03123f401976
Author: John Haddon <thehad...@gmail.com>
Date: 2024-06-04 (Tue, 04 Jun 2024)
Changed paths:
M contrib/IECoreUSD/test/IECoreUSD/DataAlgoTest.py
Log Message:
-----------
USD DataAlgoTest : Fix indentation
Commit: b2526dbf69600a9cc8a4483c0d8cd904be84f2b1
https://github.com/ImageEngine/cortex/commit/b2526dbf69600a9cc8a4483c0d8cd904be84f2b1
Author: John Haddon <thehad...@gmail.com>
Date: 2024-06-04 (Tue, 04 Jun 2024)
Changed paths:
M Changes
M contrib/IECoreUSD/src/IECoreUSD/bindings/IEUSDModule.cpp
M contrib/IECoreUSD/test/IECoreUSD/DataAlgoTest.py
Log Message:
-----------
USD module : Bind `DataAlgo::toUSD()`
Commit: 8b3385f0d628e27f6793709969081ec5ab210e51
https://github.com/ImageEngine/cortex/commit/8b3385f0d628e27f6793709969081ec5ab210e51
Author: John Haddon <thehad...@gmail.com>
Date: 2024-06-04 (Tue, 04 Jun 2024)
Changed paths:
M Changes
M contrib/IECoreUSD/src/IECoreUSD/DataAlgo.cpp
M contrib/IECoreUSD/test/IECoreUSD/DataAlgoTest.py
Log Message:
-----------
USD DataAlgo : Fix handling of types not known to `dispatch()`
We now return a sentinel instead of throwing an exception. This is consistent with our existing handling of types known to `dispatch()` but without a corresponding USD type.
Commit: 45db9e4fed0881d45968dea68df20d4b940a44e0
https://github.com/ImageEngine/cortex/commit/45db9e4fed0881d45968dea68df20d4b940a44e0
Author: John Haddon <thehad...@gmail.com>
Date: 2024-06-04 (Tue, 04 Jun 2024)
Changed paths:
M Changes
M contrib/IECoreUSD/src/IECoreUSD/ShaderAlgo.cpp
M contrib/IECoreUSD/test/IECoreUSD/USDSceneTest.py
Log Message:
-----------
USD ShaderAlgo : Emit warning for unsupported parameter types
In conjunction with the previous commit, this means that we now gracefully print a warning message for any parameter types we can't write to USD. Prior to this we were throwing a not very helpful exception and not writing anything at all. This came up in production with a GLSL shader with an ImagePlug input in Gaffer, where we pack an entire image into a CompoundData value.
Commit: 1d2bfd61801bd8f63b42d99f7a2ba890e176c6ac
https://github.com/ImageEngine/cortex/commit/1d2bfd61801bd8f63b42d99f7a2ba890e176c6ac
Author: John Haddon <thehad...@gmail.com>
Date: 2024-06-04 (Tue, 04 Jun 2024)
Changed paths:
M Changes
M contrib/IECoreUSD/src/IECoreUSD/AttributeAlgo.cpp
M contrib/IECoreUSD/test/IECoreUSD/USDSceneTest.py
Log Message:
-----------
USD AttributeAlgo : Don't treat `arnold:*` light primvars as attributes
Since 0590bbfdadaee2c26295e404abd951f98c79b570, they have been converted to light parameters instead.
Commit: a5e12c90b5731c5a30fa6ec14d1f878bf5190572
https://github.com/ImageEngine/cortex/commit/a5e12c90b5731c5a30fa6ec14d1f878bf5190572
Author: John Haddon <thehad...@gmail.com>
Date: 2024-06-05 (Wed, 05 Jun 2024)
Changed paths:
M Changes
M contrib/IECoreUSD/src/IECoreUSD/AttributeAlgo.cpp
M contrib/IECoreUSD/src/IECoreUSD/DataAlgo.cpp
M contrib/IECoreUSD/src/IECoreUSD/ShaderAlgo.cpp
M contrib/IECoreUSD/src/IECoreUSD/bindings/IEUSDModule.cpp
M contrib/IECoreUSD/test/IECoreUSD/DataAlgoTest.py
M contrib/IECoreUSD/test/IECoreUSD/USDSceneTest.py
Log Message:
-----------
Merge pull request #1420 from johnhaddon/usdFixes
USD fixes
Commit: fdfd188a9bf3042547d10ff48ea1762d4c46ba4f
https://github.com/ImageEngine/cortex/commit/fdfd188a9bf3042547d10ff48ea1762d4c46ba4f
Author: John Haddon <thehad...@gmail.com>
Date: 2024-06-05 (Wed, 05 Jun 2024)
Changed paths:
M Changes
M SConstruct
Log Message:
-----------
Bump version to 10.5.8.0
Commit: 8a3a9ea68db55117e4c18ca11ea25f68a58a2d0e
https://github.com/ImageEngine/cortex/commit/8a3a9ea68db55117e4c18ca11ea25f68a58a2d0e
Author: John Haddon <thehad...@gmail.com>
Date: 2024-06-21 (Fri, 21 Jun 2024)
Changed paths:
M Changes
M contrib/IECoreUSD/src/IECoreUSD/USDScene.cpp
M contrib/IECoreUSD/test/IECoreUSD/USDSceneTest.py
Log Message:
-----------
USDScene : Load bounds from UsdGeomModelAPI extents hints
This can provide significant performance improvements where the ModelAPI has been used to provide cached extents. This knocks around 30% off the time taken to open the file and compute the root bound of the ALab in Gaffer. If USD composition time is omitted so only the bound computation is measured in isolation, a full 95% is knocked off the time. In the case of the ALab, the new root bound is also far more reasonable for some reason - I suspect the model extents are masking a bad authored extent on a leaf object elsewhere in the scene.
This has the potential to be surprising for any folks who have authored inaccurate model extents in the past, so I've made it possible to turn off the behaviour using an environment variable. I'd like to default things on in Cortex itself, but we can debate the appropriate default for Gaffer when we next update the Cortex version.
Commit: 94bddf2760385cbbefc91672665d5ec4355250fa
https://github.com/ImageEngine/cortex/commit/94bddf2760385cbbefc91672665d5ec4355250fa
Author: Murray Stevenson <50844517+mur...@users.noreply.github.com>
Date: 2024-06-21 (Fri, 21 Jun 2024)
Changed paths:
M Changes
M contrib/IECoreUSD/src/IECoreUSD/USDScene.cpp
M contrib/IECoreUSD/test/IECoreUSD/USDSceneTest.py
Log Message:
-----------
Merge pull request #1421 from johnhaddon/modelAPIBounds
USDScene : Load bounds from UsdGeomModelAPI extents hints
Commit: 4da134098a2a5004b3ff006c4deeae84aeaba654
https://github.com/ImageEngine/cortex/commit/4da134098a2a5004b3ff006c4deeae84aeaba654
Author: John Haddon <thehad...@gmail.com>
Date: 2024-06-24 (Mon, 24 Jun 2024)
Changed paths:
M Changes
M SConstruct
Log Message:
-----------
Bump version to 10.5.9.0
Commit: 26ee835c2b2fe66903ae173e4418bfb396cf733e
https://github.com/ImageEngine/cortex/commit/26ee835c2b2fe66903ae173e4418bfb396cf733e
Author: Murray Stevenson <50844517+mur...@users.noreply.github.com>
Date: 2024-07-05 (Fri, 05 Jul 2024)
Changed paths:
M .github/workflows/main.yml
Log Message:
-----------
CI : Continue using Node16 for actions
Actions are now run on Node20 by default, but this requires glibc >=2.28 so actions no longer run in our CentOS 7 build container.
Setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true allows us to continue using Node16 for the near future, but support for this may be removed in October...
https://github.blog/changelog/2024-05-17-updated-dates-for-actions-runner-using-node20-instead-of-node16-by-default/
Commit: e320d1bfeac75248d801f15e1a3a4eb9ac0efde3
https://github.com/ImageEngine/cortex/commit/e320d1bfeac75248d801f15e1a3a4eb9ac0efde3
Author: Murray Stevenson <50844517+mur...@users.noreply.github.com>
Date: 2024-07-05 (Fri, 05 Jul 2024)
Changed paths:
M .github/workflows/main.yml
Log Message:
-----------
CI : Update Node12 actions
This matches the action versions used on Gaffer CI and silences the "The following actions uses node12 which is deprecated and will be forced to run on node16" warnings.
There are even newer versions of these actions, such as checkout and upload-artifact v4, but they require Node20 which we're unable to use on our CentOS 7 build container.
Commit: c296aa18f26f9a02573d533f4bf25fd03a4c4666
https://github.com/ImageEngine/cortex/commit/c296aa18f26f9a02573d533f4bf25fd03a4c4666
Author: John Haddon <thehad...@gmail.com>
Date: 2024-07-08 (Mon, 08 Jul 2024)
Changed paths:
M .github/workflows/main.yml
Log Message:
-----------
Merge pull request #1424 from murraystevenson/ciNode16Workaround
CI : Continue using Node16 for actions
Commit: fa90c5d3f50690006624a2873387aefed750dba3
https://github.com/ImageEngine/cortex/commit/fa90c5d3f50690006624a2873387aefed750dba3
Author: John Haddon <thehad...@gmail.com>
Date: 2024-07-09 (Tue, 09 Jul 2024)
Changed paths:
M Changes
M src/IECoreImage/OpenImageIOAlgo.cpp
Log Message:
-----------
OpenImageIOAlgo : Add missing array handlers to `data()`
And consolidate the existing array handling to use the same templated function as everything else. This new version is preferable because it doesn't initialise the data twice (previously the `resize()` was doing a redundant initialisation prior to the `copy()`).
This fixes the loading of ICCProfile metadata, which is the underlying problem reported in https://groups.google.com/g/gaffer-dev/c/qUSJ-r0XuYI/m/y4OMtrBUAAAJ.
Commit: 7de325a18fba986ed2f147e9b7af0000d2df9de6
https://github.com/ImageEngine/cortex/commit/7de325a18fba986ed2f147e9b7af0000d2df9de6
Author: John Haddon <thehad...@gmail.com>
Date: 2024-07-10 (Wed, 10 Jul 2024)
Changed paths:
M Changes
M src/IECoreImage/OpenImageIOAlgo.cpp
Log Message:
-----------
Merge pull request #1425 from johnhaddon/oiioDataFix
OpenImageIOAlgo : Add missing array handlers to `data()`
Commit: 0f34fb872a334f83cfba88b6db0e57067056977b
https://github.com/ImageEngine/cortex/commit/0f34fb872a334f83cfba88b6db0e57067056977b
Author: John Haddon <thehad...@gmail.com>
Date: 2024-07-11 (Thu, 11 Jul 2024)
Changed paths:
M Changes
M SConstruct
Log Message:
-----------
Bump version to 10.5.9.1
Commit: 1cca93125d0f5b0ee5c375c8c1c0c340c25e488f
https://github.com/ImageEngine/cortex/commit/1cca93125d0f5b0ee5c375c8c1c0c340c25e488f
Author: John Haddon <thehad...@gmail.com>
Date: 2024-08-27 (Tue, 27 Aug 2024)
Changed paths:
M Changes
M contrib/IECoreUSD/src/IECoreUSD/USDScene.cpp
M contrib/IECoreUSD/test/IECoreUSD/USDSceneTest.py
Log Message:
-----------
USDScene : Fix round-tripping of colons in set names
And make some notes on future changes we'll want to make to our name mangling. In theory we could implement round-tripping _now_ either by using metadata to store the "true name" or by implementing the first USD proposal ourselves. But I don't think round-tripping of arbitrary names is pressing enough to warrant the extra effort and ugliness if USD will provide it for us in the medium term.
Note : I removed the first call to `validName()` in `writeSetInternal()` because in that case we're going to make the name valid in the recursive call we're passing the name to.
Commit: 5957180d460ee2b6926f25885187d67408159ccd
https://github.com/ImageEngine/cortex/commit/5957180d460ee2b6926f25885187d67408159ccd
Author: John Haddon <thehad...@gmail.com>
Date: 2024-08-27 (Tue, 27 Aug 2024)
Changed paths:
M Changes
M contrib/IECoreUSD/src/IECoreUSD/USDScene.cpp
M contrib/IECoreUSD/test/IECoreUSD/USDSceneTest.py
Log Message:
-----------
USDScene : Fix hash of bounds from UsdGeomModelAPI
Commit: 0c12a739ed2e9fd8957629dde758ec28febede2b
https://github.com/ImageEngine/cortex/commit/0c12a739ed2e9fd8957629dde758ec28febede2b
Author: John Haddon <thehad...@gmail.com>
Date: 2024-08-28 (Wed, 28 Aug 2024)
Changed paths:
M Changes
M contrib/IECoreUSD/src/IECoreUSD/USDScene.cpp
M contrib/IECoreUSD/test/IECoreUSD/USDSceneTest.py
Log Message:
-----------
Merge pull request #1428 from johnhaddon/usdSetAndBoundFixes
USDScene fixes
Commit: 2c37ad1498019ee2eca9eb25919967c0eef494af
https://github.com/ImageEngine/cortex/commit/2c37ad1498019ee2eca9eb25919967c0eef494af
Author: Daniel Dresser <dan...@image-engine.com>
Date: 2024-08-29 (Thu, 29 Aug 2024)
Changed paths:
M src/IECoreScene/CurvesAlgo.cpp
M test/IECoreScene/CurvesAlgoTest.py
Log Message:
-----------
CurvesAlgo::resamplePrimitiveVariables : Support periodic curves
Commit: 897a4dd51675f5c793f1545d9fa43e57ad415919
https://github.com/ImageEngine/cortex/commit/897a4dd51675f5c793f1545d9fa43e57ad415919
Author: christopherle <christ...@image-engine.com>
Date: 2024-08-29 (Thu, 29 Aug 2024)
Changed paths:
M .gitignore
Log Message:
-----------
gitignore : Ignore all sconsdblite files
Commit: e1ee2c877882b22231ccd1ecb81f35b817be661e
https://github.com/ImageEngine/cortex/commit/e1ee2c877882b22231ccd1ecb81f35b817be661e
Author: christopherle <christ...@image-engine.com>
Date: 2024-08-29 (Thu, 29 Aug 2024)
Changed paths:
M Changes
M src/IECoreMaya/ToMayaMeshConverter.cpp
M test/IECoreMaya/ParameterisedHolder.py
M test/IECoreMaya/ToMayaMeshConverterTest.py
Log Message:
-----------
ToMayaMeshConverter : Reverts "ToMayaMeshConverter : No longer set normals"
Reverts changes to no longer set normals when reading from a Cortex
object to Maya mesh since by not reading the normals, we don't take
into account the difference between face and vertex normals meaning
Maya may not recompute the normals as expected. Also, SCCs
published from outside Maya are also likely to be read into Maya with
different than expected normals.
Commit: 341b3de9a05d53ce66e1b8ce215bf5439d20e01b
https://github.com/ImageEngine/cortex/commit/341b3de9a05d53ce66e1b8ce215bf5439d20e01b
Author: Ivan Imanishi <iv...@image-engine.com>
Date: 2024-08-29 (Thu, 29 Aug 2024)
Changed paths:
M .gitignore
M Changes
M src/IECoreMaya/ToMayaMeshConverter.cpp
M test/IECoreMaya/ParameterisedHolder.py
M test/IECoreMaya/ToMayaMeshConverterTest.py
Log Message:
-----------
Merge pull request #1430 from chrisc-lee/revertNotSetNormalsForMesh
ToMayaMeshConverter: Revert "ToMayaMeshConverter : No longer set normals"
Commit: ac86d9bfee4336043053a0f9c8cc159733c01b86
https://github.com/ImageEngine/cortex/commit/ac86d9bfee4336043053a0f9c8cc159733c01b86
Author: John Haddon <thehad...@gmail.com>
Date: 2024-08-30 (Fri, 30 Aug 2024)
Changed paths:
M src/IECoreScene/CurvesAlgo.cpp
M test/IECoreScene/CurvesAlgoTest.py
Log Message:
-----------
Merge pull request #1429 from danieldresser-ie/resampleCurves
CurvesAlgo::resamplePrimitiveVariables : Support periodic curves
Commit: 1be00fbed98f617e189e16758601ec35e5ac3b6a
https://github.com/ImageEngine/cortex/commit/1be00fbed98f617e189e16758601ec35e5ac3b6a
Author: John Haddon <thehad...@gmail.com>
Date: 2024-08-30 (Fri, 30 Aug 2024)
Changed paths:
M Changes
M SConstruct
Log Message:
-----------
Bump version to 10.5.9.2
And add missing entry in Changes.
Commit: e8bc39aa5e3dcbff8bda4cfaa4b1977d9bad0006
https://github.com/ImageEngine/cortex/commit/e8bc39aa5e3dcbff8bda4cfaa4b1977d9bad0006
Author: John Haddon <thehad...@gmail.com>
Date: 2024-08-30 (Fri, 30 Aug 2024)
Changed paths:
M .github/workflows/main.yml
M .github/workflows/main/options.posix
M .gitignore
M Changes
M SConstruct
M contrib/IECoreUSD/src/IECoreUSD/AttributeAlgo.cpp
M contrib/IECoreUSD/src/IECoreUSD/DataAlgo.cpp
M contrib/IECoreUSD/src/IECoreUSD/MeshAlgo.cpp
M contrib/IECoreUSD/src/IECoreUSD/ShaderAlgo.cpp
M contrib/IECoreUSD/src/IECoreUSD/USDScene.cpp
M contrib/IECoreUSD/src/IECoreUSD/bindings/IEUSDModule.cpp
M contrib/IECoreUSD/test/IECoreUSD/DataAlgoTest.py
M contrib/IECoreUSD/test/IECoreUSD/USDSceneTest.py
M include/IECore/EuclideanToSphericalTransform.h
M include/IECore/SphericalToEuclideanTransform.h
M include/IECorePython/IECoreBinding.h
M include/IECoreScene/MeshPrimitive.h
M python/IECore/__init__.py
M src/IECoreGL/ShaderStateComponent.cpp
M src/IECoreImage/OpenImageIOAlgo.cpp
M src/IECoreMaya/ToMayaMeshConverter.cpp
M src/IECorePython/StringAlgoBinding.cpp
M src/IECoreScene/CurvesAlgo.cpp
M src/IECoreScene/MeshPrimitive.cpp
M src/IECoreScene/ShaderNetworkAlgo.cpp
M src/IECoreScene/bindings/MeshPrimitiveBinding.cpp
M test/IECoreImage/ImageReaderTest.py
M test/IECoreImage/ImageThinnerTest.py
M test/IECoreImage/data/exr/primitives.exr
M test/IECoreMaya/ParameterisedHolder.py
M test/IECoreMaya/ToMayaMeshConverterTest.py
M test/IECoreScene/CurvesAlgoTest.py
M test/IECoreScene/MeshPrimitive.py
M test/IECoreScene/ShaderNetworkAlgoTest.py
Log Message:
-----------
Merge branch 'RB-10.5'
Compare: https://github.com/ImageEngine/cortex/compare/634afb6f3fe8...e8bc39aa5e3d
To unsubscribe from these emails, change your notification settings at https://github.com/ImageEngine/cortex/settings/notifications
Reply all
Reply to author
Forward
0 new messages