Re: Issue 592 in corsix-th: Exhausted staff members don't go to staff room - patch though causes another issue

[cors...@googlecode.com]

Updates:
Summary: Exhausted staff members don't go to staff room - patch though
causes another issue
Status: Started

Comment #71 on issue 592 by maartenp...@hotmail.nl: Exhausted staff members
don't go to staff room - patch though causes another issue
http://code.google.com/p/corsix-th/issues/detail?id=592

Could you provide some saves with this situartion?

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[cors...@googlecode.com]

Comment #72 on issue 592 by mark.l1...@hotmail.co.uk: Exhausted staff

members don't go to staff room - patch though causes another issue
http://code.google.com/p/corsix-th/issues/detail?id=592

(No comment was entered for this change.)

Attachments:
not going 4 break.sav 316 KB

[cors...@googlecode.com]

Comment #73 on issue 592 by maartenp...@hotmail.nl: Exhausted staff members

don't go to staff room - patch though causes another issue
http://code.google.com/p/corsix-th/issues/detail?id=592

But directly after I unpause, the docotor goes to the staff room. Do you
have more saves with this situation and where he does not go to the staff
room?

[cors...@googlecode.com]

Comment #74 on issue 592 by mark.l1...@hotmail.co.uk: Exhausted staff

members don't go to staff room - patch though causes another issue
http://code.google.com/p/corsix-th/issues/detail?id=592

Oddly in the copy here he rests. Here is another copy and it is both Dr's
in the GP office that are not resting but walk up and down the room instead.

https://www.dropbox.com/s/ryds22tkmevgcn8/notresting.wmv

Attachments:
not going 4 break2.sav 319 KB

[cors...@googlecode.com]

Updates:
Labels: -Priority-High Priority-Medium

Comment #75 on issue 592 by maartenp...@hotmail.nl: Exhausted staff members

don't go to staff room - patch though causes another issue
http://code.google.com/p/corsix-th/issues/detail?id=592

(No comment was entered for this change.)

[cors...@googlecode.com]

Comment #76 on issue 592 by Grim...@gmail.com: Exhausted staff members

don't go to staff room - patch though causes another issue
http://code.google.com/p/corsix-th/issues/detail?id=592

From your latest save i get this error after a few seconds:


Savegame version changed from 74 (Trunk) to 76 (Trunk). The save was
created usi
ng 74 (Trunk)
An error has occured!
Almost anything can be the cause, but the detailed information below can
help th
e developers find the source of the error.
Running: The timer handler.
A stack trace is included below, and the handler has been disconnected.
C:\Games\CorsixTH\Lua\room.lua:210: bad argument #1 to '(for generator)'
(table
expected, got nil)
stack traceback:
[C]: in function '(for generator)'
C:\Games\CorsixTH\Lua\room.lua:210: in function 'getMissingStaff'
C:\Games\CorsixTH\Lua\room.lua:230: in function 'testStaffCriteria'
C:\Games\CorsixTH\Lua\humanoid_actions\meander.lua:42: in
function '?'
C:\Games\CorsixTH\Lua\entities\humanoid.lua:547: in
function 'Humanoid_s
tartAction'
C:\Games\CorsixTH\Lua\entities\humanoid.lua:639: in
function 'finishActi
on'
C:\Games\CorsixTH\Lua\humanoid_actions\walk.lua:144: in
function 'timer_
function'
C:\Games\CorsixTH\Lua\entity.lua:166: in function 'tick'
C:\Games\CorsixTH\Lua\entities\staff.lua:146: in function 'tick'
C:\Games\CorsixTH\Lua\world.lua:1023: in function 'onTick'
C:\Games\CorsixTH\Lua\app.lua:796: in function 'dispatch'
C:\Games\CorsixTH\Lua\app.lua:697: in function
<C:\Games\CorsixTH\Lua\ap
p.lua:692>

Error in timer handler:
C:\Games\CorsixTH\Lua\room.lua:210: bad argument #1 to '(for generator)'
(table
expected, got nil)
stack traceback:
[C]: in function '(for generator)'
C:\Games\CorsixTH\Lua\room.lua:210: in function 'getMissingStaff'
C:\Games\CorsixTH\Lua\room.lua:230: in function 'testStaffCriteria'
C:\Games\CorsixTH\Lua\humanoid_actions\meander.lua:42: in
function '?'
C:\Games\CorsixTH\Lua\entities\humanoid.lua:547: in
function 'Humanoid_s
tartAction'
C:\Games\CorsixTH\Lua\entities\humanoid.lua:639: in
function 'finishActi
on'
C:\Games\CorsixTH\Lua\humanoid_actions\walk.lua:144: in
function 'timer_
function'
C:\Games\CorsixTH\Lua\entity.lua:166: in function 'tick'
C:\Games\CorsixTH\Lua\entities\staff.lua:146: in function 'tick'
C:\Games\CorsixTH\Lua\world.lua:1023: in function 'onTick'
C:\Games\CorsixTH\Lua\app.lua:796: in function 'dispatch'
C:\Games\CorsixTH\Lua\app.lua:697: in function
<C:\Games\CorsixTH\Lua\ap
p.lua:692>
Warning: No event handler for timer

[cors...@googlecode.com]

Comment #77 on issue 592 by mark.l1...@hotmail.co.uk: Exhausted staff

members don't go to staff room - patch though causes another issue
http://code.google.com/p/corsix-th/issues/detail?id=592

getMissingStaff was altered I think when adding more than one nurse can
work in the ward. So perhaps that change has broken this save, nothing to
do with the issue at hand though.

[cors...@googlecode.com]

Updates:
Cc: -edvin.li...@gmail.com

Comment #78 on issue 592 by mark.l1...@hotmail.co.uk: Exhausted staff

members don't go to staff room - patch though causes another issue
http://code.google.com/p/corsix-th/issues/detail?id=592

at comment 76
The reason you got that error is the save version is the same as when more
desks in wards was made possible.
If you want to avoid the error you can open ward.lua and look for the if
old < and change the number to 75. It will then get the new variable added.

[cors...@googlecode.com]

Updates:
Status: Done

Comment #79 on issue 592 by mark.l1...@hotmail.co.uk: Exhausted staff

members don't go to staff room - patch though causes another issue

https://code.google.com/p/corsix-th/issues/detail?id=592

Transferred to our github account end of 2014

https://github.com/CorsixTH/CorsixTH