Issue 760 in corsix-th: control panel of radiation shield part of x-ray room is always grey

[cors...@googlecode.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 760 by Alberth289346: control panel of radiation shield part of
x-ray room is always grey
http://code.google.com/p/corsix-th/issues/detail?id=760

What steps will reproduce the problem?
1. from example town level, start building a x-ray room.
2. the control panel of the radiation shield is grey while the other parts
are blue-ish when they are positioned correctly.
3. on placing, the control panel stays grey, and the console emits a
message like

Warning: Multiple objects on tile 66,59 - only one will be encoded

r1238, linux

[cors...@googlecode.com]

Comment #1 on issue 760 by mark.l1...@hotmail.co.uk: control panel of

radiation shield part of x-ray room is always grey
http://code.google.com/p/corsix-th/issues/detail?id=760

are you sure that the room was large enough for its placement?
I had a similar issue when the shield was first implemented and then found
that it was due to the room not being large enough. Making the room just
one square bigger may be enough to allow for its placement as you have to
also allow for movement around the console as well as access to the xray
itself.

[cors...@googlecode.com]

Comment #2 on issue 760 by Alberth289346: control panel of radiation shield

part of x-ray room is always grey
http://code.google.com/p/corsix-th/issues/detail?id=760

Yes I am sure.
I have created a room almost as big as the entire hospital for testing.
Also, the other part of the radiation shield (with the radiation on it, and
the chair) coloured from grey to blue-ish metal colour.
Last but not least, the program released the shield from my mouse cursor,
which imho also indicates that the program believes it is positioned
correctly.

[cors...@googlecode.com]

Comment #3 on issue 760 by mark.l1...@hotmail.co.uk: control panel of

radiation shield part of x-ray room is always grey
http://code.google.com/p/corsix-th/issues/detail?id=760

It looks like there are two issues.
I can confirm that the lua window does display the message about mulitple
objects in tile blah blah.
Also the minimum room size of 6 x 6 is the same as TH, but in CTH it is not
possible to build the room and place the default objects in a 6 x 6 room.
You need a room of at least 7 x 6 to place both objects.

Attachments:
screen.PNG 68.3 KB

[cors...@googlecode.com]

Comment #4 on issue 760 by cgja...@gmail.com: control panel of radiation

shield part of x-ray room is always grey
http://code.google.com/p/corsix-th/issues/detail?id=760

You can fit everything into an x-ray room in 6x6. But note the clipping
errors through the wall.

Attachments:
xray.png 29.3 KB

[cors...@googlecode.com]

Comment #5 on issue 760 by Hugh.A.L...@gmail.com: control panel of

radiation shield part of x-ray room is always grey
http://code.google.com/p/corsix-th/issues/detail?id=760

There is something else going on here. It seems like the combination in
Cgia's photo above is the only possible one. However all the positions
below should be allowed in a 6x6 room as the console is 3x3 and the x-ray
is mostly 3x3 with the exception of one tile which sticks out.

Attachments:
x-ray1.jpg 23.6 KB
x-ray2.jpg 24.5 KB
x-ray3.jpg 25.7 KB
x-ray4.jpg 28.0 KB
x-ray5.jpg 25.1 KB

[cors...@googlecode.com]

Comment #6 on issue 760 by mark.l1...@hotmail.co.uk: control panel of

radiation shield part of x-ray room is always grey
http://code.google.com/p/corsix-th/issues/detail?id=760

I think you are right, it has something to do with the footprints.
I have altered them in this patch, but I don't have the time to test it to
see if it causes problems. It was something I was look at a while back,
but at the moment I have too much happening in my life and don't have the
time to spare testing things.

If you want to do this it would help me no end.

Attachments:
xray.patch 1.8 KB

[cors...@googlecode.com]

Comment #7 on issue 760 by Grimdoc: control panel of radiation shield part

of x-ray room is always grey
http://code.google.com/p/corsix-th/issues/detail?id=760

Issue 1122 has been merged into this issue.

[cors...@googlecode.com]

Comment #8 on issue 760 by Hugh.A.L...@gmail.com: control panel of

radiation shield part of x-ray room is always grey
http://code.google.com/p/corsix-th/issues/detail?id=760

Sorry Mark, The patch is no good, can't even load a save or create a new
game now.

[cors...@googlecode.com]

Comment #9 on issue 760 by mark.l1...@hotmail.co.uk: control panel of

radiation shield part of x-ray room is always grey
http://code.google.com/p/corsix-th/issues/detail?id=760

thanks for testing, we'll have to leave this one to the dev's to fix.

[cors...@googlecode.com]

Comment #10 on issue 760 by mark.l1...@hotmail.co.uk: control panel of

radiation shield part of x-ray room is always grey
http://code.google.com/p/corsix-th/issues/detail?id=760

Just thought, do you know how to reverse the patch?

Basically copy these two lua files over what you have now from your latest
downloaded copy
radiation_shield.lua
x_ray.lua
if you look in the patch you will see which directories to copy them to.
Or just copy the whole lua file and it will replace the alertered files
along with the others

[cors...@googlecode.com]

Comment #11 on issue 760 by Hugh.A.L...@gmail.com: control panel of

radiation shield part of x-ray room is always grey
http://code.google.com/p/corsix-th/issues/detail?id=760

I just downloaded the latest version from
http://th.corsix.org/corsix-th-latest-win32.zip again.

On another note it might be a good idea to place a link to this on the
downloads page, with an appropriate description, so people can download it
if they want.

[cors...@googlecode.com]

Comment #12 on issue 760 by maartenp...@hotmail.nl: control panel of

radiation shield part of x-ray room is always grey
http://code.google.com/p/corsix-th/issues/detail?id=760

Will these bugs ever been fixed? :)

[cors...@googlecode.com]

Comment #13 on issue 760 by Alberth2...@gmail.com: control panel of

radiation shield part of x-ray room is always grey
http://code.google.com/p/corsix-th/issues/detail?id=760

It seems fixed, or should other things get changed as well?


Attachments:
xray_solved.png 41.9 KB
xray_solved1.png 35.3 KB

[cors...@googlecode.com]

Comment #14 on issue 760 by maartenp...@hotmail.nl: control panel of

radiation shield part of x-ray room is always grey
http://code.google.com/p/corsix-th/issues/detail?id=760

I still have the issues from comment four and five.

[cors...@googlecode.com]

Comment #15 on issue 760 by mark.l1...@hotmail.co.uk: control panel of

radiation shield part of x-ray room is always grey
http://code.google.com/p/corsix-th/issues/detail?id=760

That is odd, because I have had some problems placing both in a larger room
than that one!
It seems to me that the xray takes up more room in one direction than the
other and also looks like sometimes you cannot place the console against
the wall, but one tile out.

[cors...@googlecode.com]

Comment #16 on issue 760 by maartenp...@hotmail.nl: control panel of

radiation shield part of x-ray room is always grey
http://code.google.com/p/corsix-th/issues/detail?id=760

Sorry, I mean only from comment 4!

[cors...@googlecode.com]

Comment #17 on issue 760 by Alberth2...@gmail.com: control panel of

radiation shield part of x-ray room is always grey
http://code.google.com/p/corsix-th/issues/detail?id=760

@15: Placement of the machine is critical, if you move it to another corner
you'll have major troubles.

@16: The clipping? That's technically a different issue (with a different
solution), so either
- a new one should be created (if it does not exist already) and this one
should be closed, or
- this issue should renamed to reflect it is now for a different problem.

[cors...@googlecode.com]

Updates:
Status: Done

Comment #18 on issue 760 by mark.l1...@hotmail.co.uk: control panel of

radiation shield part of x-ray room is always grey

https://code.google.com/p/corsix-th/issues/detail?id=760

Transferred to our github account end of 2014

https://github.com/CorsixTH/CorsixTH

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings