Rant / guideline

71 views
Skip to first unread message

Stephen Baker

unread,
Mar 1, 2016, 10:27:30 PM3/1/16
to corsix...@googlegroups.com
I'm about 4-5 hours into sorting through a pull request and I have
something I want to get off my chest; maybe this should go in
contributing.txt

1. Do not refactor existing code in the same pull request that you add a
feature.
2. If you insist on breaking rule #1 (e.g. because it makes your feature
much cleaner) then do all refactoring at the beginning of your pull
request (independent of and before your feature commits).

Edvin Linge

unread,
Mar 2, 2016, 12:14:08 AM3/2/16
to corsix...@googlegroups.com
Sounds good to me.

/Edvin
Reply all
Reply to author
Forward
0 new messages