Pushed a branch

[Ian C]

Hi All,

I just pushed my ODF Lenses branch - I think I edited the header correctly.
Just so the world can see it.

It still needs some (quite a bit) cleaning, to get rid of some
warnings, and trace messages.

It builds and generates a dfconvert to perform a get and a put of a
simple document.

If you do one of a couple of things the resulting document will have your edit.
Example is change the content of a simple paragraph - manually in the
html, then put.

It's a start....

I also have a fledgling CorinthiaNode experiment which is giving me
some problems.
It does take in an ODF document, call dfconvert and render the
resulting HTML with a couple of additions to make it play as an editor
(title, a button so I can toggle editable, a button so I can save). I
can then save the html (post to server) and call dfconvert with a put,
having edited a simple paragraph. And whoo hoo the document is there
on the server with the edit.

Just got to make it downloadable back to the user.

I was going to create a CorinthiaNode repo to house this experiment.
Unless someone suggests something different.

But getting tired now so going to put my feet up, and have a wee drink.

--
Cheers,

Ian C

[Peter Kelly]

Hi Ian, I’ve finally had a chance to look at your code.

I noticed a problem with nested spans. I created with four words, "Three four five six", marking "four" as bold, and "five" as italic. OpenOffice saved this as follows:

<text:p text:style-name="Standard">

    Three

    <text:span text:style-name="T1">four</text:span>

    <text:span text:style-name="T2">five</text:span>

    six

</text:p>

ODFParagraphContentGet only handles text nodes right now. I guess you're probably aware of the above issue, but just figured I'd mention it as it's the first problem I ran into.

I can confirm that changing text node directly inside a paragraph causes it to be updated in the odt file after a put operation.

I also tried adding a new paragraph to the HTML file, but that wasn't reflected after an update.

There's quite a few colour macros used here, e.g.:

    printf(CYAN "ODFParagraphContentGet\n" RESET);

These colours could perhaps be integrated with Gabriela's logging framework, so they're not explicitly specified by filter code, and can be turned on/off or customised easily. We could perhaps have one colour per level, or alternatively an additional parameter to specify the colour. Gabriela - any thoughts on this?

There were also three files I found that had an ASF license header:

DocFormats/api/src/Operations.c

DocFormats/filters/odf/src/lenses/ODFDocument.c

DocFormats/filters/odf/src/lenses/ODFHeader.c

On the corinthia-node suggestion - I would recommend putting it into corinthia-webapp repository instead. Franz has also been working on a node-based server, so perhaps the two of you could collaborate on this.

--
Dr. Peter M. Kelly
kell...@gmail.com

http://www.kellypmk.net/

PGP key: http://www.kellypmk.net/pgp-key

(fingerprint 5435 6718 59F0 DD1F BFA0 5E46 2523 BAA1 44AE 2966)

--
You received this message because you are subscribed to the Google Groups "CorinthiaTeam" group.
To unsubscribe from this group and stop receiving emails from it, send an email to corinthiatea...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.