metadata.squash_notes _with_ metadata.map_references?

[sudoforge]

I have a workflow that imports a SoT and generates a summary of the changes using metadata.squash_notes(). Often times, these messages can include references like "#34", which left unchecked, would point to issues/PRs within my repository (and not the source of truth, like it should) on most platforms (e.g. GitHub).

To address this, I'd like to change "#34" to "foo/bar#34" within the squashed notes, which would change the reference that is linked on platforms like GitHub to the appropriate issue/PR within the appropriate user/org repository. To accomplish this, I have a pretty simple transformation:

metadata.map_references(
        before = "#${reference}",
        after = "foo/bar#${reference}",
        regex_groups = {
            "before_ref": "[0-9]+",
            "after_ref": "[0-9]+",
        },
)

This transformation does not seem to work in conjunction with metadata.squash_notes(), regardless of the transformation ordering. Is there something I am missing that would help me accomplish my goal?

[Miguel Alcon]

The problem is that currently map_references works for SHAs but not for PR numbers. It was developed for submitted code (e.g "Rollback abca23432"). The idea makes sense but it is not trivial to implement.

--
You received this message because you are subscribed to the Google Groups "Copybara OSS" group.
To unsubscribe from this group and stop receiving emails from it, send an email to copybara-discu...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/copybara-discuss/4d2d7e46-ccaa-4981-9276-43c55bbc32f6n%40googlegroups.com.

[Ben Denhartog]

I'll make some time to look into a solution for this. Does refactoring `map_references()` to address this use case make sense, or is this something better addressed through refactoring `squash_notes()`?

-- 

  Ben Denhartog

  b...@sudoforge.com

[Miguel Alcon]

Squash_notes should be fine. I think the main change is in map_references logic to ask the destination to also ask after that the origin. Also the destination and origins themselves.