Issue 2 in constants-to-enum-eclipse-plugin: Refactoring Wizard

2 views
Skip to first unread message

codesite...@google.com

unread,
Aug 27, 2009, 9:20:36 PM8/27/09
to convert_constant...@googlegroups.com
Updates:
Status: Accepted

Comment #18 on issue 2 by raffi.t.khatchadourian: Refactoring Wizard
http://code.google.com/p/constants-to-enum-eclipse-plugin/issues/detail?id=2

(No comment was entered for this change.)

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

codesite...@google.com

unread,
Aug 28, 2009, 9:33:34 AM8/28/09
to convert_constant...@googlegroups.com
Updates:
Owner: b.muskalla

Comment #19 on issue 2 by b.muskalla: Refactoring Wizard
http://code.google.com/p/constants-to-enum-eclipse-plugin/issues/detail?id=2

I'll try to come up with an initial UI for the refactoring in the next days.

codesite...@google.com

unread,
Aug 28, 2009, 9:41:42 AM8/28/09
to convert_constant...@googlegroups.com

Comment #20 on issue 2 by raffi.t.khatchadourian: Refactoring Wizard
http://code.google.com/p/constants-to-enum-eclipse-plugin/issues/detail?id=2

Great! I've started a refactoring wizard, but its basically use the one
taken from the example. The problem I was
incurring (as I may have previously mentioned) is how to incorporate the
new enum type into the change set so
that if the user cancels the refactoring, the new enum type is not created.
I am a bit slammed for the upcoming
week, but if there are any specific tasks that need to be done, I will see
about allocating some resources to get it
done. Let me know.

codesite...@google.com

unread,
Aug 28, 2009, 9:56:14 PM8/28/09
to convert_constant...@googlegroups.com
Updates:
Status: Fixed

Comment #21 on issue 2 by b.muskalla: Refactoring Wizard
http://code.google.com/p/constants-to-enum-eclipse-plugin/issues/detail?id=2

Just commited an initial version of the wizard. It's still in a pretty
early stage
but now we can refine it task by task.
Regarding the undo of the enum creation, this is covered by issue 16.

I'm closing this one as we now have an initial UI up and running. Further
action
requires some restructuring of the refactoring itself (so the refactoring
can check
the conditions instead of the wizard). These things will be covered by
separate bugs.

btw: as the refactoring now consists of a command/handler, you can easily
bind it to
a keybinding (Keys preference page) to test it.

codesite...@google.com

unread,
Aug 31, 2009, 8:38:06 PM8/31/09
to convert_constant...@googlegroups.com

Comment #22 on issue 2 by raffi.t.khatchadourian: Refactoring Wizard
http://code.google.com/p/constants-to-enum-eclipse-plugin/issues/detail?id=2

Isn't it standard to have the wizard check the pre-conditions? I could be
wrong.

Reply all
Reply to author
Forward
0 new messages