Re: Convert Constants to Enum
Raffi Khatchadourian
Thanks for contacting me. In fact, I've been meeting to send you an
email regarding this and I'm glad you beat me to the punch. My
comments are listed below.
On Aug 22, 2009, at 6:23 PM, Benjamin Muskalla wrote:
> I just stumbled across the refactoring again on google code
> (http://code.google.com/p/constants-to-enum-eclipse-plugin/). As I'm
> still *very* interested to see a working version of this and I'd love
> to contribute to the effort.
Great! We are looking for help, so that would work out well.
> As far as I can see the current implementation is pretty desolate.
Yes, it is in a research prototype state.
> In my eyes the first thing to do is to setup a proper infrastructure
> before really working on this. This would include things like *
> continuous build * test infrastructure * automated tests * update site
Currently, we have been working on the refactoring wizard but haven't
gotten very far. One of the problems we have been incurring is that
that we need to produce a new type, however, its not clear how to
incorporate this into the refactoring changes that would be committed
by the user. As such, regardless of whether or not the user commits
the refactoring change, the new enum type is created (with a default
name for the time being) via a call to the "Create New Enum Wizard"
representative class instance. The user interface has been basically
our priority at this point, but the things you mention above are
important as well.
> With the test infrastructure in place, we should take at several
> implementation details as the plugin currently uses many deprecated
> things of Eclipse (eg. actionSets) and should be cleaned up a little
> bit.
Agreed.
> Backed up by tests it should get easier to really work on the code as
> we have the safety net while working.
Right. I have begun to make a few test cases. You can take a look at
them in the resource directly. The testing infrastructure has not been
put into place, however.
> Please tell me what you and your partner (bina) are currently working
> on. I'd really love to help out on this project.
As I mentioned above, the priority has been on the UI (the refactoring
wizard in particular). If you would like to work on that, that would
be great. Otherwise, if there is something else you'd rather work on
(code cleanup, testing, etc.), that would great as well. Any and all
help would be greatly appreciated! Please let me know if there is any
way I can assist you; although, keep in mind that my time is quite
limited at the moment as I am preparing to undergo my candidacy
examination in the upcoming months. Thanks!
Raffi
Raffi Khatchadourian
code project.
On Aug 22, 2009, at 6:23 PM, Benjamin Muskalla wrote:
> Hi Raffi,
>
> I just stumbled across the refactoring again on google code (http://code.google.com/p/constants-to-enum-eclipse-plugin/
> ).
> As I'm still *very* interested to see a working version of this and
> I'd love to contribute to the effort.
>
> As far as I can see the current implementation is pretty desolate.
> In my eyes the first thing to do is to setup a proper infrastructure
> before really working on this.
> This would include things like
> * continuous build
> * test infrastructure
> * automated tests
> * update site
>
> With the test infrastructure in place, we should take at several
> implementation details as the plugin currently uses many deprecated
> things of Eclipse (eg. actionSets) and should be cleaned up a little
> bit.
> Backed up by tests it should get easier to really work on the code
> as we have the safety net while working.
>
> Please tell me what you and your partner (bina) are currently
> working on. I'd really love to help out on this project.
>
> Regards,
> Benjamin
>
> Raffi Khatchadourian wrote:
>> Sounds good Benny! Good luck!
>>
>> On Apr 8, 2009, at 5:02 AM, Benjamin Muskalla wrote:
>>
>>> Hi Raffi,
>>>
>>> in the end I decided to not submit an application for your project
>>> idea because I'm going to work together with the JDT team to fix
>>> some bugs in the Extract method refactoring. But I'm still really
>>> interested in the project (as developer and as user). I'd love to
>>> see progress in this area. Maybe I'll join the effort again after
>>> GSoC depending how far the interested student gets the
>>> implementation.
>>>
>>> So - looking forward to see the refactoring in 3.6 and just ping
>>> me if you need additional resources to work on it.
>>>
>>> Cheers
>>> Benny
>>>
>>> Raffi Khatchadourian wrote:
>>>> Hi Benjamin,
>>>>
>>>> I am glad to see that you are interested in my project proposal
>>>> for Google SoC. Would you like to tell me about yourself, goals,
>>>> interests? Do you need any further information from myself in
>>>> regards to the project? Thanks and I look forward to hearing from
>>>> you!
>>>>
>>
>
Benjamin Muskalla
Really looking forward to work on the refactoring.
On Aug 25, 12:11 am, Raffi Khatchadourian <khatc...@cse.ohio-
Raffi Khatchadourian
questions about the code and thanks for your help!
Benjamin Muskalla
One thing you could give me your opinion about is Issue 6:
http://code.google.com/p/constants-to-enum-eclipse-plugin/issues/detail?id=6