Enum refactoring plugin development
Raffi Khatchadourian
I thought perhaps we could make some progress on the enum plugin while the GSoC applications are pending. Is there any issues in the list (http://code.google.com/p/constants-to-enum-eclipse-plugin/issues/list) that you are interested/comfortable working on? Probably the most important issue right now pertains to developing the refactoring wizard.
Benjamin, any thoughts?
Raffi
George Trigeorgis
Unfortunately I am very busy with exam period now, so I don't have much
time for the plugin, but while checking out the plugin, I found some
major bugs just by using some simple static final int to convert to
enums where it would convert each constant into a different enum entry.
The other one as you pointed is the wizard, which needs a lot of work
(also to let the user select which constants to convert etc.). I d love
to work on these two things first, maybe starting with the wizard to get
familiar with the plugin!
Regards,
George
Raffi Khatchadourian
On Apr 14, 2010, at 7:12 PM, George Trigeorgis wrote:
> Unfortunately I am very busy with exam period now, so I don't have much
> time for the plugin, but while checking out the plugin, I found some
> major bugs just by using some simple static final int to convert to
> enums where it would convert each constant into a different enum entry.
What exactly do you mean by this? Do you mean that each constant would be a "singleton" in an individual enum type?
> The other one as you pointed is the wizard, which needs a lot of work
Agreed, but it's off to a good start thanks to Benjamin.
> (also to let the user select which constants to convert etc.).
Ah, I see the problem. You can do this by selecting multiple constants prior to starting the refactoring. Let me know if that helps.
> I d love
> to work on these two things first, maybe starting with the wizard to get
> familiar with the plugin!
Yes, that may be a good start. In fact, what would be very helpful would be to break down all the issues with the wizard into google code issues. Good luck with the exams!
Raffi
George Trigeorgis
busy lately.
> Hi George,
>
> On Apr 14, 2010, at 7:12 PM, George Trigeorgis wrote:
>
> > Unfortunately I am very busy with exam period now, so I don't have much
> > time for the plugin, but while checking out the plugin, I found some
> > major bugs just by using some simple static final int to convert to
> > enums where it would convert each constant into a different enum entry.
>What exactly do you mean by this? Do you mean that each constant would be a "singleton" in an individual enum type?
>
> > The other one as you pointed is the wizard, which needs a lot of work
>
> Agreed, but it's off to a good start thanks to Benjamin.
>
> > (also to let the user select which constants to convert etc.).
>
> Ah, I see the problem. You can do this by selecting multiple constants prior to starting the refactoring. Let me know if that helps.
"singleton" in an individual enum type.
> > I d love
> > to work on these two things first, maybe starting with the wizard to get
> > familiar with the plugin!
>
> Yes, that may be a good start. In fact, what would be very helpful would be to break down all the issues with the wizard into google code issues. Good luck with the exams!
>
Regards George
> Raffi
>
--
You received this message because you are subscribed to the Google Groups "convert_constants_to_enum-dev" group.
To post to this group, send email to convert_consta...@googlegroups.com.
To unsubscribe from this group, send email to convert_constants_to...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/convert_constants_to_enum-dev?hl=en.
Raffi Khatchadourian
On Apr 18, 2010, at 7:05 PM, George Trigeorgis wrote:
> Firstly Im really sorry about the delayed response, but I was really
> busy lately.
>> Hi George,
>>
>> On Apr 14, 2010, at 7:12 PM, George Trigeorgis wrote:
>>
>>> Unfortunately I am very busy with exam period now, so I don't have much
>>> time for the plugin, but while checking out the plugin, I found some
>>> major bugs just by using some simple static final int to convert to
>>> enums where it would convert each constant into a different enum entry.
>> What exactly do you mean by this? Do you mean that each constant would be a "singleton" in an individual enum type?
> Yes thats exactly what I mean :)
>
>>
>>> The other one as you pointed is the wizard, which needs a lot of work
>>
>> Agreed, but it's off to a good start thanks to Benjamin.
>>
>>> (also to let the user select which constants to convert etc.).
>>
>> Ah, I see the problem. You can do this by selecting multiple constants prior to starting the refactoring. Let me know if that helps.
> I tried that but the result was that each constant would be a
> "singleton" in an individual enum type.
>>
>>> I d love
>>> to work on these two things first, maybe starting with the wizard to get
>>> familiar with the plugin!
>>
>> Yes, that may be a good start. In fact, what would be very helpful would be to break down all the issues with the wizard into google code issues. Good luck with the exams!
>>
> Ok ! I will do that!
George Trigeorgis
> George,
>
> On Apr 18, 2010, at 7:05 PM, George Trigeorgis wrote:
>
> > Firstly Im really sorry about the delayed response, but I was really
> > busy lately.
>
> Not a problem.
>
> >> Hi George,
> >>
> >> On Apr 14, 2010, at 7:12 PM, George Trigeorgis wrote:
> >>
> >>> Unfortunately I am very busy with exam period now, so I don't have much
> >>> time for the plugin, but while checking out the plugin, I found some
> >>> major bugs just by using some simple static final int to convert to
> >>> enums where it would convert each constant into a different enum entry.
> >> What exactly do you mean by this? Do you mean that each constant would be a "singleton" in an individual enum type?
> > Yes thats exactly what I mean :)
> >
> >>
> >>> The other one as you pointed is the wizard, which needs a lot of work
> >>
> >> Agreed, but it's off to a good start thanks to Benjamin.
> >>
> >>> (also to let the user select which constants to convert etc.).
> >>
> >> Ah, I see the problem. You can do this by selecting multiple constants prior to starting the refactoring. Let me know if that helps.
> > I tried that but the result was that each constant would be a
> > "singleton" in an individual enum type.
>
> I see. Could you post an issue about this on google code? Please include any steps needed to reproduce the problem. To note, the enum type creation is a bit ad hoc at the moment (see issue 16 http://tinyurl.com/y2zuv76), but multiple constants should be grouped together if all those constants are compatible. If you can, please let us know the test code you were using.
>
posted another issue, regarding refactoring history.
I will be able to provide more technical details on the bugs as soon we
are finished with the exams!
> >>
> >>> I d love
> >>> to work on these two things first, maybe starting with the wizard to get
> >>> familiar with the plugin!
> >>
> >> Yes, that may be a good start. In fact, what would be very helpful would be to break down all the issues with the wizard into google code issues. Good luck with the exams!
> >>
> > Ok ! I will do that!
>
> Great! I look forward to reviewing the new issues!
>
> Raffi
>
Regards,
George
Raffi Khatchadourian
On Apr 20, 2010, at 7:54 PM, George Trigeorgis wrote:
> Looking forward to work with you during the summer!
Raffi
George Trigeorgis
> Hi George,
>
> On Apr 20, 2010, at 7:54 PM, George Trigeorgis wrote:
>
> > Looking forward to work with you during the summer!
>
> Thanks for submitting the issues on google code. If the SOC grant does not go through, are you still interested in working on the plug-in?
>
full-time, but I would be still interested, though!