The plan for dialogs

2623 views
Skip to first unread message

Jonathan Giles

unread,
Aug 21, 2014, 12:50:38 AM8/21/14
to control...@googlegroups.com
Hi all,

ControlsFX has been a victim of its own success. This is a good thing,
but also a time and API destroying thing.

In short, and in case you missed the long-winded discussion over on Jira
[1], the ControlsFX dialogs have been accepted and promoted up to be
part of OpenJFX, starting in the next feature release (JavaFX 8u40).
However, the API that is in ControlsFX is very, very, very different
than the API that is going to be in JavaFX 8u40. For the last few months
all I have been doing is working on dialogs for JavaFX 8u40.

This leaves us in something of a conundrum - we've architected our own
demise. We have a few options, all of which result in users of the
ControlsFX dialogs API eventually being forced off it in favour of the
official API. Even though there are more features in ControlsFX dialogs,
we feel it is important that we do not duplicate functionality. For this
reason, Eugene and I have developed the following plan:

1) We have created a (currently private) repo that contains a fork of
the OpenJFX dialogs API and implementation.

2) From this repo we will be doing builds and pushing the resulting jar
to Maven Central. This build will be necessarily licensed under the
GPLv2 + classpath exception license, as it is taken from OpenJDK (even
if it originally originated from us, this is the best option legally, I
would think, especially as we want to continue to refresh the dialogs
code occasionally from upstream where the ownership swings more into
Oracle's favour).

3) ControlsFX will be adapted to have a dependency on this library for
all releases until we baseline on JavaFX 8u40. Once we baseline on 8u40
this jar will no longer be necessary and we will drop the dependency.

4) The existing dialogs API in ControlsFX will be deprecated but not
removed. This API will be removed when we baseline on JavaFX 8u40. If
you use ControlsFX dialogs, please take the time to transition away from
the old API as soon as possible. If there are things you could once do
that now you can't, please file bugs, although note that we will not be
bringing back all functionality (e.g. I'm sorry to say I won't be
bringing back lightweight dialogs unless someone hands over a big bag of
money).

5) We will use the new openjfx-dialogs.jar to build out a new set of
pre-built dialogs (e.g. font chooser, progress, command link, exception,
etc). This new API will follow the API of the OpenJFX dialogs API, so it
will be different.

So, that's the plan. I hope people can appreciate we're doing our best
to ease the transition, even though it is more work for us. I was quite
happy to make you all go cold turkey and strip out our old dialogs from
the next release, so you should all thank Eugene for caring about you :-)

[1] javafx-jira.kenai.com/browse/RT-12643

--

-- Jonathan

Werner Lehmann

unread,
Aug 21, 2014, 4:42:48 AM8/21/14
to control...@googlegroups.com
Hi,

On 21.08.2014 06:50, Jonathan Giles wrote:
> the old API as soon as possible. If there are things you could once do
> that now you can't, please file bugs, although note that we will not be
> bringing back all functionality (e.g. I'm sorry to say I won't be
> bringing back lightweight dialogs unless someone hands over a big bag of
> money).

do you have some keywords as to which features would be dropped? For
example, we have a dialog with custom content...

> the next release, so you should all thank Eugene for caring about you :-)

I really appreciate the effort to bring good dialog support to FX. IMO
Swing was leaving some things to be desired here. And a big thank you
goes to Eugene for caring :)

Werner

Jonathan Giles

unread,
Aug 21, 2014, 4:46:47 AM8/21/14
to control...@googlegroups.com, Werner Lehmann
Custom content will still definitely be supported in the new API. It already exists in the 8u40 API I've been working on.

Some missing functionality is lightweight dialogs, no cross platform styling, no actions support, etc. Hope that helps.

-- Jonathan
Sent from a touch device. Please excuse my brevity.

Werner Lehmann

unread,
Aug 21, 2014, 5:07:37 AM8/21/14
to Jonathan Giles, control...@googlegroups.com
Makes sense and looks as if we won't have problems because of it.
Platform button order would be nice but I guess it is not a must have.

Werner

Jonathan Giles

unread,
Aug 21, 2014, 5:09:43 AM8/21/14
to Werner Lehmann, control...@googlegroups.com
Platform button order is part of the 8u40 dialogs, so it will be included.


-- Jonathan
Sent from a touch device. Please excuse my brevity.

cleem...@googlemail.com

unread,
Oct 2, 2014, 9:14:52 AM10/2/14
to control...@googlegroups.com, Jona...@jonathangiles.net
Hi,

I'm trying to update controlsfx from 8.0.6_20 to 8.20.7 in my project.
I'm wondering what's happend with the class org.controlsfx.dialog.DefaultDialogAction?

We have a few Dialogs which uses this class.. I can't find the class neither in controlsfx-8.20.7 nor in openjfx-dialogs-1.0.2.
Do you have any suggestions how to deal with this change?

thanks!


org.controlsfx.dialog.DefaultDialogAction

Eugene Ryzhikov

unread,
Oct 2, 2014, 5:30:11 PM10/2/14
to control...@googlegroups.com, Jona...@jonathangiles.net
If I'm not mistaken it is renamed to DialogAction. 

Charles Monteiro

unread,
Dec 17, 2014, 6:36:16 AM12/17/14
to control...@googlegroups.com, Jona...@jonathangiles.net
Its unfortunate that lightweight dialogs have been killed off, its a very nice look for one i.e. the opaque overlay, and also unfortunate is that I don't have a bag of money to give :)

Christopher Merrill

unread,
Oct 22, 2015, 10:03:19 PM10/22/15
to ControlsFX, Jona...@jonathangiles.net
On Thursday, August 21, 2014 at 12:50:38 AM UTC-4, Jonathan Giles wrote:
that now you can't, please file bugs, although note that we will not be
bringing back all functionality (e.g. I'm sorry to say I won't be
bringing back lightweight dialogs unless someone hands over a big bag of
money).



<crying>

So sad, those were very elegant.  I'm going to miss them, and I expect my users will too. Throwing up modal dialogs feels so archaic.

</crying>

charles....@gmail.com

unread,
Oct 23, 2015, 8:22:31 AM10/23/15
to control...@googlegroups.com, Jona...@jonathangiles.net
I concur

Sent from my whatever 
--
You received this message because you are subscribed to a topic in the Google Groups "ControlsFX" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/controlsfx-dev/APokeoMFnHE/unsubscribe.
To unsubscribe from this group and all its topics, send an email to controlsfx-de...@googlegroups.com.
To post to this group, send email to control...@googlegroups.com.
Visit this group at http://groups.google.com/group/controlsfx-dev.
To view this discussion on the web visit https://groups.google.com/d/msgid/controlsfx-dev/286f4264-90e8-48fc-9b24-c71266d58b34%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply all
Reply to author
Forward
0 new messages