Ready to cut 1.2?

8 views
Skip to first unread message

Saad Ali

unread,
Sep 11, 2019, 8:00:25 PM9/11/19
to container-storage-interface-community, Jie Yu, James DeFelice, Hjortshoj, Julian, Deep Debroy, Hemant Kumar, Swartzlander, Ben, David Zhu, Tom Manville, Hakan Memisoglu
CSI Community,

How do folks feel about cutting a 1.2 release? 

We got a few big changes in since the 1.1 release:
  • Secrets field to ListSnapshotsRequest
  • Add PublishedNodes field to ListVolumes Response
The outstanding pending work right now is
  • containerizing builds
  • various volume expansion improvements
The first item doesn't impact the API, but the second one does.

Should we wait for the volume expansion work to land (how long would that take)? Or should we cut 1.2 now to unblock merged feature implementation? I'm leaning towards the latter.

Regards,

Saad Ali

Swartzlander, Ben

unread,
Sep 11, 2019, 8:35:08 PM9/11/19
to Saad Ali, container-storage-interface-community, Jie Yu, James DeFelice, Hjortshoj, Julian, Deep Debroy, Hemant Kumar, Swartzlander, Ben, David Zhu, Tom Manville, Hakan Memisoglu
I'm keen to get the volume expansion changes in before 1.2. If not, then I'll want to push for a 1.3 very soon after so we have a chance of propagating the improvements to Kubernetes in 1.17.

On September 11, 2019 8:00:55 PM Saad Ali <saa...@google.com> wrote:

NetApp Security WARNING: This is an external email. Do not click links or open attachments unless you recognize the sender and know the content is safe.

Jie Yu

unread,
Sep 12, 2019, 12:41:28 AM9/12/19
to Swartzlander, Ben, Saad Ali, container-storage-interface-community, James DeFelice, Hjortshoj, Julian, Deep Debroy, Hemant Kumar, David Zhu, Tom Manville, Hakan Memisoglu
+1 on cutting 1.2 now and cutting 1.3 once volume expansion stuffs land.

Sent from my iPhone

Hakan Memisoglu

unread,
Sep 12, 2019, 12:54:26 AM9/12/19
to Jie Yu, Swartzlander, Ben, Saad Ali, container-storage-interface-community, James DeFelice, Hjortshoj, Julian, Deep Debroy, Hemant Kumar, David Zhu, Tom Manville
I also support cutting 1.2 now. 
--
- Hakan

David Zhu

unread,
Sep 12, 2019, 2:31:54 PM9/12/19
to Hakan Memisoglu, Jie Yu, Swartzlander, Ben, Saad Ali, container-storage-interface-community, James DeFelice, Hjortshoj, Julian, Deep Debroy, Hemant Kumar, Tom Manville
+1 on cutting 1.2 now

--

David Zhu | Software Engineer | dy...@google.com | 412-436-6859

Saad Ali

unread,
Sep 12, 2019, 3:28:36 PM9/12/19
to David Zhu, Hakan Memisoglu, Jie Yu, Swartzlander, Ben, container-storage-interface-community, James DeFelice, Hjortshoj, Julian, Deep Debroy, Hemant Kumar, Tom Manville
Kubernetes 1.16 ships next week, so too late to get any of these features in to that release.
But I want to avoid having 2 CSI releases (CSI 1.2 and 1.3) cut before the Kubernetes 1.17 release (code freeze November, ship December).
So if we cut CSI 1.2 now then Kubernetes 1.17 can pick it up. But we should wait until Kubernetes 1.18 (Feb/March next year) to pick up the resizing changes CSI 1.3. Is that ok with everyone?

Ben Swartzlander

unread,
Sep 12, 2019, 3:39:21 PM9/12/19
to container-storage-...@googlegroups.com
On 9/12/19 3:27 PM, 'Saad Ali' via container-storage-interface-community
wrote:
> Kubernetes 1.16 ships next week, so too late to get any of these
> features in to that release.
> But I want to avoid having 2 CSI releases (CSI 1.2 and 1.3) cut before
> the Kubernetes 1.17 release (code freeze November, ship December).
> So if we cut CSI 1.2 now then Kubernetes 1.17 can pick it up. But we
> should wait until Kubernetes 1.18 (Feb/March next year) to pick up the
> resizing changes CSI 1.3. Is that ok with everyone?

I would consider it a shame to not get the volume expansion changes into
kubernetes 1.17, so I'm against it. What can we do to try to close on
the volume expansion changes before CSI 1.2?

-Ben

> On Thu, Sep 12, 2019 at 11:31 AM David Zhu <dy...@google.com
> <mailto:dy...@google.com>> wrote:
>
> +1 on cutting 1.2 now
>
> On Wed, Sep 11, 2019 at 9:54 PM Hakan Memisoglu <ha...@kasten.io
> <mailto:ha...@kasten.io>> wrote:
>
> I also support cutting 1.2 now.
>
> On Wed, Sep 11, 2019 at 9:41 PM Jie Yu <j...@d2iq.com
> <mailto:j...@d2iq.com>> wrote:
>
> +1 on cutting 1.2 now and cutting 1.3 once volume expansion
> stuffs land.
>
> Sent from my iPhone
>
> On Sep 11, 2019, at 5:35 PM, Swartzlander, Ben
> <Ben.Swar...@netapp.com
> <mailto:Ben.Swar...@netapp.com>> wrote:
>
>> I'm keen to get the volume expansion changes in before
>> 1.2. If not, then I'll want to push for a 1.3 very soon
>> after so we have a chance of propagating the improvements
>> to Kubernetes in 1.17.
>>
>> On September 11, 2019 8:00:55 PM Saad Ali
>> <saa...@google.com <mailto:saa...@google.com>> wrote:
>>
>>> *NetApp Security WARNING*: This is an external email. Do
>>> not click links or open attachments unless you recognize
>>> the sender and know the content is safe.
>>>
>>>
>>>
>>>
>>> CSI Community,
>>>
>>> How do folks feel about cutting a 1.2 release?
>>>
>>> We got a few big changes in since the 1.1 release:
>>>
>>> * Secrets field to ListSnapshotsRequest
>>> * Add PublishedNodes field to ListVolumes Response
>>>
>>> The outstanding pending work right now is
>>>
>>> * containerizing builds
>>> * various volume expansion improvements
>>>
>>> The first item doesn't impact the API, but the second one
>>> does.
>>>
>>> Should we wait for the volume expansion work to land (how
>>> long would that take)? Or should we cut 1.2 now to
>>> unblock merged feature implementation? I'm leaning
>>> towards the latter.
>>>
>>> Regards,
>>>
>>> Saad Ali
>>
>
>
> --
> - Hakan
>
>
>
> --
>
> David Zhu | Software Engineer |dy...@google.com
> <mailto:dy...@google.com> |412-436-6859 <tel:(412)%20436-6859>
>
> --
> You received this message because you are subscribed to the Google
> Groups "container-storage-interface-community" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to
> container-storage-interf...@googlegroups.com
> <mailto:container-storage-interf...@googlegroups.com>.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/container-storage-interface-community/CABBBJP0yvxYDokfKXscs1Kh%3DdeS5m7VrisS5ArWn%2BOM61dvvtg%40mail.gmail.com
> <https://groups.google.com/d/msgid/container-storage-interface-community/CABBBJP0yvxYDokfKXscs1Kh%3DdeS5m7VrisS5ArWn%2BOM61dvvtg%40mail.gmail.com?utm_medium=email&utm_source=footer>.

Saad Ali

unread,
Sep 12, 2019, 4:50:29 PM9/12/19
to Ben Swartzlander, Hemant Kumar, container-storage-interface-community
Code freeze for Kubernetes 1.17 will likely be mid-November. We would want to cut a CSI release no later than mid-late October (the sooner the better). So if we can get the CSI volume expansion changes wrapped up within 1 month, we can cut one CSI release, and pick it up in Kubernetes 1.17.

If you can Hemant believe that you can get the changes in, code reviewed, and merged by then, I would support holding the release. What do others think?

To unsubscribe from this group and stop receiving emails from it, send an email to container-storage-interf...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/container-storage-interface-community/0fcd23ca-9d98-8bbb-fdf5-6a981171e310%40swartzlander.org.

Hemant Kumar

unread,
Sep 13, 2019, 1:52:15 PM9/13/19
to Saad Ali, Ben Swartzlander, container-storage-interface-community
I think that most critical of changes for expansion can be picked up in 1 month. But it depends on how much time it takes to deliberate on some of the stuff. I am working with Ben to have a draft PR before Wednesday's call and if it mostly looks good then we can wait for 1.2 release cut but changes proposed look problematic then we might want to cut 1.2 now and wait for expansion changes.





Saad Ali

unread,
Sep 13, 2019, 2:01:02 PM9/13/19
to Hemant Kumar, Ben Swartzlander, container-storage-interface-community
That sounds like a good plan to me.

David Zhu

unread,
Oct 10, 2019, 4:18:28 PM10/10/19
to container-storage-interface-community
Want to restart discussion on this since its been ~1 month since the original proposal. How are we looking on the expansion changes. Will we be ready to cut v1.2 in the near future?

Best,
David
>             <Ben.Swa...@netapp.com
To unsubscribe from this group and stop receiving emails from it, send an email to container-storage-interface-community+unsubscribe@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "container-storage-interface-community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to container-storage-interface-community+unsubscribe@googlegroups.com.

Hemant Kumar

unread,
Oct 10, 2019, 4:40:06 PM10/10/19
to David Zhu, container-storage-interface-community
There are two PRs that needs to be merged:


I am hesitant to include readonly handling in expansion calls for now (and I do not think this is urgent) and would like to spend more time considering its design.




To unsubscribe from this group and stop receiving emails from it, send an email to container-storage-interf...@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "container-storage-interface-community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to container-storage-interf...@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "container-storage-interface-community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to container-storage-interf...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/container-storage-interface-community/4af5c5df-dc56-4891-b662-08bda7f362ee%40googlegroups.com.

Saad Ali

unread,
Oct 18, 2019, 3:06:06 PM10/18/19
to Hemant Kumar, David Zhu, container-storage-interface-community
Both those PRs have been merged. I believe we are ready to cut a 1.2.

Unless there are any objections, I will cut the RC and start the release process this afternoon. 

Paul....@dell.com

unread,
Oct 21, 2019, 12:17:22 PM10/21/19
to ha...@kasten.io, j...@d2iq.com, Ben.Swar...@netapp.com, saa...@google.com, container-storage-...@googlegroups.com, james.d...@gmail.com, Julian.H...@dell.com, dde...@docker.com, hek...@redhat.com, dy...@google.com, t...@kasten.io

​+1 on 1.2 now


From: container-storage-...@googlegroups.com <container-storage-...@googlegroups.com> on behalf of Hakan Memisoglu <ha...@kasten.io>
Sent: Wednesday, September 11, 2019 9:53 PM
To: Jie Yu
Cc: Swartzlander, Ben; Saad Ali; container-storage-interface-community; James DeFelice; Hjortshoj, Julian; Deep Debroy; Hemant Kumar; David Zhu; Tom Manville
Subject: Re: Ready to cut 1.2?
 

[EXTERNAL EMAIL]

--
You received this message because you are subscribed to the Google Groups "container-storage-interface-community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to container-storage-interf...@googlegroups.com.
Reply all
Reply to author
Forward
0 new messages